mirror of
https://github.com/torvalds/linux.git
synced 2025-11-03 10:10:33 +02:00
Based on grepping through the source code this driver appears to be
missing a call to drm_atomic_helper_shutdown() at system shutdown
time. Among other things, this means that if a panel is in use that it
won't be cleanly powered off at system shutdown time.
The fact that we should call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
This driver was fairly easy to update. The drm_device is stored in the
drvdata so we just have to make sure the drvdata is NULL whenever the
device is not bound. To make things simpler,
drm_atomic_helper_shutdown() has been modified to consider a NULL
drm_device as a noop in the patch ("drm/atomic-helper:
drm_atomic_helper_shutdown(NULL) should be a noop").
Suggested-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230901164111.RFT.1.I3d5598bd73a59b5ded71430736c93f67dc5dea61@changeid
|
||
|---|---|---|
| .. | ||
| armada_510.c | ||
| armada_crtc.c | ||
| armada_crtc.h | ||
| armada_debugfs.c | ||
| armada_drm.h | ||
| armada_drv.c | ||
| armada_fb.c | ||
| armada_fb.h | ||
| armada_fbdev.c | ||
| armada_gem.c | ||
| armada_gem.h | ||
| armada_hw.h | ||
| armada_ioctlP.h | ||
| armada_overlay.c | ||
| armada_plane.c | ||
| armada_plane.h | ||
| armada_trace.c | ||
| armada_trace.h | ||
| Kconfig | ||
| Makefile | ||