mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	drm_exec_prepare_obj() and drm_exec_prepare_array() both reserve
dma-fence slots and hence a dma_resv_list without ever freeing it.
Make sure to call drm_gem_private_object_fini() for each GEM object
passed to drm_exec_prepare_obj()/drm_exec_prepare_array() throughout the
test to fix this up.
While at it, remove some trailing empty lines.
Fixes: 9710631cc8 ("drm: add drm_exec selftests v4")
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230809225034.8803-1-dakr@redhat.com
Signed-off-by: Christian König <christian.koenig@amd.com>
		
	
			
		
			
				
	
	
		
			213 lines
		
	
	
	
		
			4.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			213 lines
		
	
	
	
		
			4.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: MIT
 | 
						|
/*
 | 
						|
 * Copyright 2022 Advanced Micro Devices, Inc.
 | 
						|
 */
 | 
						|
 | 
						|
#define pr_fmt(fmt) "drm_exec: " fmt
 | 
						|
 | 
						|
#include <kunit/test.h>
 | 
						|
 | 
						|
#include <linux/module.h>
 | 
						|
#include <linux/prime_numbers.h>
 | 
						|
 | 
						|
#include <drm/drm_exec.h>
 | 
						|
#include <drm/drm_device.h>
 | 
						|
#include <drm/drm_drv.h>
 | 
						|
#include <drm/drm_gem.h>
 | 
						|
#include <drm/drm_kunit_helpers.h>
 | 
						|
 | 
						|
#include "../lib/drm_random.h"
 | 
						|
 | 
						|
struct drm_exec_priv {
 | 
						|
	struct device *dev;
 | 
						|
	struct drm_device *drm;
 | 
						|
};
 | 
						|
 | 
						|
static int drm_exec_test_init(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec_priv *priv;
 | 
						|
 | 
						|
	priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL);
 | 
						|
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
 | 
						|
 | 
						|
	test->priv = priv;
 | 
						|
 | 
						|
	priv->dev = drm_kunit_helper_alloc_device(test);
 | 
						|
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev);
 | 
						|
 | 
						|
	priv->drm = __drm_kunit_helper_alloc_drm_device(test, priv->dev, sizeof(*priv->drm), 0,
 | 
						|
							DRIVER_MODESET);
 | 
						|
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->drm);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void sanitycheck(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec exec;
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
	KUNIT_SUCCEED(test);
 | 
						|
}
 | 
						|
 | 
						|
static void test_lock(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec_priv *priv = test->priv;
 | 
						|
	struct drm_gem_object gobj = { };
 | 
						|
	struct drm_exec exec;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
 | 
						|
	drm_exec_until_all_locked(&exec) {
 | 
						|
		ret = drm_exec_lock_obj(&exec, &gobj);
 | 
						|
		drm_exec_retry_on_contention(&exec);
 | 
						|
		KUNIT_EXPECT_EQ(test, ret, 0);
 | 
						|
		if (ret)
 | 
						|
			break;
 | 
						|
	}
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
}
 | 
						|
 | 
						|
static void test_lock_unlock(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec_priv *priv = test->priv;
 | 
						|
	struct drm_gem_object gobj = { };
 | 
						|
	struct drm_exec exec;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
 | 
						|
	drm_exec_until_all_locked(&exec) {
 | 
						|
		ret = drm_exec_lock_obj(&exec, &gobj);
 | 
						|
		drm_exec_retry_on_contention(&exec);
 | 
						|
		KUNIT_EXPECT_EQ(test, ret, 0);
 | 
						|
		if (ret)
 | 
						|
			break;
 | 
						|
 | 
						|
		drm_exec_unlock_obj(&exec, &gobj);
 | 
						|
		ret = drm_exec_lock_obj(&exec, &gobj);
 | 
						|
		drm_exec_retry_on_contention(&exec);
 | 
						|
		KUNIT_EXPECT_EQ(test, ret, 0);
 | 
						|
		if (ret)
 | 
						|
			break;
 | 
						|
	}
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
}
 | 
						|
 | 
						|
static void test_duplicates(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec_priv *priv = test->priv;
 | 
						|
	struct drm_gem_object gobj = { };
 | 
						|
	struct drm_exec exec;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_IGNORE_DUPLICATES);
 | 
						|
	drm_exec_until_all_locked(&exec) {
 | 
						|
		ret = drm_exec_lock_obj(&exec, &gobj);
 | 
						|
		drm_exec_retry_on_contention(&exec);
 | 
						|
		KUNIT_EXPECT_EQ(test, ret, 0);
 | 
						|
		if (ret)
 | 
						|
			break;
 | 
						|
 | 
						|
		ret = drm_exec_lock_obj(&exec, &gobj);
 | 
						|
		drm_exec_retry_on_contention(&exec);
 | 
						|
		KUNIT_EXPECT_EQ(test, ret, 0);
 | 
						|
		if (ret)
 | 
						|
			break;
 | 
						|
	}
 | 
						|
	drm_exec_unlock_obj(&exec, &gobj);
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
}
 | 
						|
 | 
						|
static void test_prepare(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec_priv *priv = test->priv;
 | 
						|
	struct drm_gem_object gobj = { };
 | 
						|
	struct drm_exec exec;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
 | 
						|
	drm_exec_until_all_locked(&exec) {
 | 
						|
		ret = drm_exec_prepare_obj(&exec, &gobj, 1);
 | 
						|
		drm_exec_retry_on_contention(&exec);
 | 
						|
		KUNIT_EXPECT_EQ(test, ret, 0);
 | 
						|
		if (ret)
 | 
						|
			break;
 | 
						|
	}
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
 | 
						|
	drm_gem_private_object_fini(&gobj);
 | 
						|
}
 | 
						|
 | 
						|
static void test_prepare_array(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec_priv *priv = test->priv;
 | 
						|
	struct drm_gem_object gobj1 = { };
 | 
						|
	struct drm_gem_object gobj2 = { };
 | 
						|
	struct drm_gem_object *array[] = { &gobj1, &gobj2 };
 | 
						|
	struct drm_exec exec;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	drm_gem_private_object_init(priv->drm, &gobj1, PAGE_SIZE);
 | 
						|
	drm_gem_private_object_init(priv->drm, &gobj2, PAGE_SIZE);
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
 | 
						|
	drm_exec_until_all_locked(&exec)
 | 
						|
		ret = drm_exec_prepare_array(&exec, array, ARRAY_SIZE(array),
 | 
						|
					     1);
 | 
						|
	KUNIT_EXPECT_EQ(test, ret, 0);
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
 | 
						|
	drm_gem_private_object_fini(&gobj1);
 | 
						|
	drm_gem_private_object_fini(&gobj2);
 | 
						|
}
 | 
						|
 | 
						|
static void test_multiple_loops(struct kunit *test)
 | 
						|
{
 | 
						|
	struct drm_exec exec;
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
 | 
						|
	drm_exec_until_all_locked(&exec)
 | 
						|
	{
 | 
						|
		break;
 | 
						|
	}
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
 | 
						|
	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
 | 
						|
	drm_exec_until_all_locked(&exec)
 | 
						|
	{
 | 
						|
		break;
 | 
						|
	}
 | 
						|
	drm_exec_fini(&exec);
 | 
						|
	KUNIT_SUCCEED(test);
 | 
						|
}
 | 
						|
 | 
						|
static struct kunit_case drm_exec_tests[] = {
 | 
						|
	KUNIT_CASE(sanitycheck),
 | 
						|
	KUNIT_CASE(test_lock),
 | 
						|
	KUNIT_CASE(test_lock_unlock),
 | 
						|
	KUNIT_CASE(test_duplicates),
 | 
						|
	KUNIT_CASE(test_prepare),
 | 
						|
	KUNIT_CASE(test_prepare_array),
 | 
						|
	KUNIT_CASE(test_multiple_loops),
 | 
						|
	{}
 | 
						|
};
 | 
						|
 | 
						|
static struct kunit_suite drm_exec_test_suite = {
 | 
						|
	.name = "drm_exec",
 | 
						|
	.init = drm_exec_test_init,
 | 
						|
	.test_cases = drm_exec_tests,
 | 
						|
};
 | 
						|
 | 
						|
kunit_test_suite(drm_exec_test_suite);
 | 
						|
 | 
						|
MODULE_AUTHOR("AMD");
 | 
						|
MODULE_LICENSE("GPL and additional rights");
 |