mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 08:38:45 +02:00 
			
		
		
		
	 7e2368a217
			
		
	
	
		7e2368a217
		
	
	
	
	
		
			
			As discussed in [1], there is no need to enforce dma mapping check on
noncoherent allocations, a simple test on the returned CPU address is
good enough.
Add a new pair of debug helpers and use them for noncoherent alloc/free
to fix this issue.
Fixes: efa70f2fdc ("dma-mapping: add a new dma_alloc_pages API")
Link: https://lore.kernel.org/all/ff6c1fe6-820f-4e58-8395-df06aa91706c@oss.qualcomm.com # 1
Signed-off-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20250828-dma-debug-fix-noncoherent-dma-check-v1-1-76e9be0dd7fc@oss.qualcomm.com
		
	
			
		
			
				
	
	
		
			150 lines
		
	
	
	
		
			4.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			150 lines
		
	
	
	
		
			4.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /* SPDX-License-Identifier: GPL-2.0-only */
 | |
| /*
 | |
|  * Copyright (C) 2008 Advanced Micro Devices, Inc.
 | |
|  *
 | |
|  * Author: Joerg Roedel <joerg.roedel@amd.com>
 | |
|  */
 | |
| 
 | |
| #ifndef _KERNEL_DMA_DEBUG_H
 | |
| #define _KERNEL_DMA_DEBUG_H
 | |
| 
 | |
| #ifdef CONFIG_DMA_API_DEBUG
 | |
| extern void debug_dma_map_page(struct device *dev, struct page *page,
 | |
| 			       size_t offset, size_t size,
 | |
| 			       int direction, dma_addr_t dma_addr,
 | |
| 			       unsigned long attrs);
 | |
| 
 | |
| extern void debug_dma_unmap_page(struct device *dev, dma_addr_t addr,
 | |
| 				 size_t size, int direction);
 | |
| 
 | |
| extern void debug_dma_map_sg(struct device *dev, struct scatterlist *sg,
 | |
| 			     int nents, int mapped_ents, int direction,
 | |
| 			     unsigned long attrs);
 | |
| 
 | |
| extern void debug_dma_unmap_sg(struct device *dev, struct scatterlist *sglist,
 | |
| 			       int nelems, int dir);
 | |
| 
 | |
| extern void debug_dma_alloc_coherent(struct device *dev, size_t size,
 | |
| 				     dma_addr_t dma_addr, void *virt,
 | |
| 				     unsigned long attrs);
 | |
| 
 | |
| extern void debug_dma_free_coherent(struct device *dev, size_t size,
 | |
| 				    void *virt, dma_addr_t addr);
 | |
| 
 | |
| extern void debug_dma_map_resource(struct device *dev, phys_addr_t addr,
 | |
| 				   size_t size, int direction,
 | |
| 				   dma_addr_t dma_addr,
 | |
| 				   unsigned long attrs);
 | |
| 
 | |
| extern void debug_dma_unmap_resource(struct device *dev, dma_addr_t dma_addr,
 | |
| 				     size_t size, int direction);
 | |
| 
 | |
| extern void debug_dma_sync_single_for_cpu(struct device *dev,
 | |
| 					  dma_addr_t dma_handle, size_t size,
 | |
| 					  int direction);
 | |
| 
 | |
| extern void debug_dma_sync_single_for_device(struct device *dev,
 | |
| 					     dma_addr_t dma_handle,
 | |
| 					     size_t size, int direction);
 | |
| 
 | |
| extern void debug_dma_sync_sg_for_cpu(struct device *dev,
 | |
| 				      struct scatterlist *sg,
 | |
| 				      int nelems, int direction);
 | |
| 
 | |
| extern void debug_dma_sync_sg_for_device(struct device *dev,
 | |
| 					 struct scatterlist *sg,
 | |
| 					 int nelems, int direction);
 | |
| extern void debug_dma_alloc_pages(struct device *dev, struct page *page,
 | |
| 				  size_t size, int direction,
 | |
| 				  dma_addr_t dma_addr,
 | |
| 				  unsigned long attrs);
 | |
| extern void debug_dma_free_pages(struct device *dev, struct page *page,
 | |
| 				 size_t size, int direction,
 | |
| 				 dma_addr_t dma_addr);
 | |
| #else /* CONFIG_DMA_API_DEBUG */
 | |
| static inline void debug_dma_map_page(struct device *dev, struct page *page,
 | |
| 				      size_t offset, size_t size,
 | |
| 				      int direction, dma_addr_t dma_addr,
 | |
| 				      unsigned long attrs)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_unmap_page(struct device *dev, dma_addr_t addr,
 | |
| 					size_t size, int direction)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_map_sg(struct device *dev, struct scatterlist *sg,
 | |
| 				    int nents, int mapped_ents, int direction,
 | |
| 				    unsigned long attrs)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_unmap_sg(struct device *dev,
 | |
| 				      struct scatterlist *sglist,
 | |
| 				      int nelems, int dir)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_alloc_coherent(struct device *dev, size_t size,
 | |
| 					    dma_addr_t dma_addr, void *virt,
 | |
| 					    unsigned long attrs)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_free_coherent(struct device *dev, size_t size,
 | |
| 					   void *virt, dma_addr_t addr)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_map_resource(struct device *dev, phys_addr_t addr,
 | |
| 					  size_t size, int direction,
 | |
| 					  dma_addr_t dma_addr,
 | |
| 					  unsigned long attrs)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_unmap_resource(struct device *dev,
 | |
| 					    dma_addr_t dma_addr, size_t size,
 | |
| 					    int direction)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_sync_single_for_cpu(struct device *dev,
 | |
| 						 dma_addr_t dma_handle,
 | |
| 						 size_t size, int direction)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_sync_single_for_device(struct device *dev,
 | |
| 						    dma_addr_t dma_handle,
 | |
| 						    size_t size, int direction)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_sync_sg_for_cpu(struct device *dev,
 | |
| 					     struct scatterlist *sg,
 | |
| 					     int nelems, int direction)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_sync_sg_for_device(struct device *dev,
 | |
| 						struct scatterlist *sg,
 | |
| 						int nelems, int direction)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_alloc_pages(struct device *dev, struct page *page,
 | |
| 					 size_t size, int direction,
 | |
| 					 dma_addr_t dma_addr,
 | |
| 					 unsigned long attrs)
 | |
| {
 | |
| }
 | |
| 
 | |
| static inline void debug_dma_free_pages(struct device *dev, struct page *page,
 | |
| 					size_t size, int direction,
 | |
| 					dma_addr_t dma_addr)
 | |
| {
 | |
| }
 | |
| #endif /* CONFIG_DMA_API_DEBUG */
 | |
| #endif /* _KERNEL_DMA_DEBUG_H */
 |