nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Backed out changeset 762270e639cf (bug 1676078) for browser_datetime_datepicker.js failures CLOSED TREE

Browse source
This commit is contained in:
Bogdan Tara 2020-11-13 04:20:11 +02:00
parent 9f60eec335
commit 0038aea648
3 changed files with 8 additions and 17 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

17
toolkit/content/tests/browser/browser_datetime_datepicker.js
View file

@ -266,8 +266,6 @@ add_task(async function test_datepicker_keyboard_open() {
"waiting for open" "waiting for open"
); );
let valueSet = helper.promisePickerValueSet();
// NOTE: After the click, the first input field (the month one) is focused, // NOTE: After the click, the first input field (the month one) is focused,
// so down arrow will change the selected month. // so down arrow will change the selected month.
// //
@ -275,13 +273,14 @@ add_task(async function test_datepicker_keyboard_open() {
// DATE_FORMAT and other bits around do the same). // DATE_FORMAT and other bits around do the same).
BrowserTestUtils.synthesizeKey("VK_DOWN", {}, browser); BrowserTestUtils.synthesizeKey("VK_DOWN", {}, browser);
await valueSet; // It'd be good to use something else than waitForCondition for this but
// there's no exposed event atm when the value changes from the child.
is( await BrowserTestUtils.waitForCondition(() => {
helper.getElement(MONTH_YEAR).textContent, return (
DATE_FORMAT(new Date(prevMonth)), helper.getElement(MONTH_YEAR).textContent ==
"Should update date when updating months" DATE_FORMAT(new Date(prevMonth))
); );
}, "Should update date when updating months");
await helper.tearDown(); await helper.tearDown();
}); });

7
toolkit/content/tests/browser/head.js
View file

@ -214,13 +214,6 @@ class DateTimeTestHelper {
await readyPromise; await readyPromise;
} }
promisePickerValueSet() {
return BrowserTestUtils.waitForEvent(
this.frame.contentDocument,
"PickerValueWasSet"
);
}
/** /**
* Find an element on the picker. * Find an element on the picker.
* *

1
toolkit/content/widgets/datepicker.js
View file

@ -315,7 +315,6 @@ function DatePicker(context) {
day, day,
}); });
this._update({ noSmoothScroll: true }); this._update({ noSmoothScroll: true });
document.dispatchEvent(new CustomEvent("PickerValueWasSet"));
}, },
}; };