nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1894554 - Forcefully trigger TelemetryControllers delayed initialization when opening about:telemetry. r=chutten

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D209165
This commit is contained in:
Mike Hommey 2024-05-02 19:29:53 +00:00
parent 6c253822af
commit 0047f11a7f
2 changed files with 27 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

21
toolkit/components/telemetry/app/TelemetryControllerParent.sys.mjs
View file

@ -256,6 +256,15 @@ export var TelemetryController = Object.freeze({
promiseInitialized() { promiseInitialized() {
return Impl.promiseInitialized(); return Impl.promiseInitialized();
}, },
/**
* Allows to trigger TelemetryControllers delayed initialization now and waiting for its completion.
* The returned promise is guaranteed to resolve before TelemetryController is shutting down.
* @return {Promise} Resolved when delayed TelemetryController initialization completed.
*/
ensureInitialized() {
return Impl.ensureInitialized();
},
}); });
var Impl = { var Impl = {
@ -1158,6 +1167,18 @@ var Impl = {
return this._delayedInitTaskDeferred.promise; return this._delayedInitTaskDeferred.promise;
}, },
/**
* Allows to trigger TelemetryControllers delayed initialization now and waiting for its completion.
* This will complete before TelemetryController is shutting down.
* @return {Promise} Resolved when delayed TelemetryController initialization completed.
*/
ensureInitialized() {
if (this._delayedInitTask) {
return this._delayedInitTask.finalize();
}
return Promise.resolve();
},
getCurrentPingData(aSubsession) { getCurrentPingData(aSubsession) {
this._log.trace("getCurrentPingData - subsession: " + aSubsession); this._log.trace("getCurrentPingData - subsession: " + aSubsession);

6
toolkit/content/aboutTelemetry.js
View file

@ -352,6 +352,12 @@ var PingPicker = {
}, },
_updateCurrentPingData() { _updateCurrentPingData() {
TelemetryController.ensureInitialized().then(() =>
this._doUpdateCurrentPingData()
);
},
_doUpdateCurrentPingData() {
const subsession = document.getElementById("show-subsession-data").checked; const subsession = document.getElementById("show-subsession-data").checked;
let ping = TelemetryController.getCurrentPingData(subsession); let ping = TelemetryController.getCurrentPingData(subsession);
if (!ping) { if (!ping) {