nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1765024 - Low resolution icons in newtab. r=daleharvey

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D144434
This commit is contained in:
Marco Bonardo 2022-04-26 08:02:56 +00:00
parent b7da7c79ba
commit 0055ef2082
2 changed files with 7 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
browser/components/newtab/lib/FaviconFeed.jsm
View file

@ -38,15 +38,13 @@ const MIN_FAVICON_SIZE = 96;
* @returns A promise of an object (possibly null) containing the data * @returns A promise of an object (possibly null) containing the data
*/ */
function getFaviconInfo(uri) { function getFaviconInfo(uri) {
// Use 0 to get the biggest width available
const preferredWidth = 0;
return new Promise(resolve => return new Promise(resolve =>
PlacesUtils.favicons.getFaviconDataForPage( PlacesUtils.favicons.getFaviconDataForPage(
uri, uri,
// Package up the icon data in an object if we have it; otherwise null // Package up the icon data in an object if we have it; otherwise null
(iconUri, faviconLength, favicon, mimeType, faviconSize) => (iconUri, faviconLength, favicon, mimeType, faviconSize) =>
resolve(iconUri ? { iconUri, faviconSize } : null), resolve(iconUri ? { iconUri, faviconSize } : null),
preferredWidth NewTabUtils.activityStreamProvider.THUMB_FAVICON_SIZE
) )
); );
} }

7
toolkit/modules/NewTabUtils.jsm
View file

@ -739,6 +739,8 @@ var PlacesProvider = {
* history changes. * history changes.
*/ */
var ActivityStreamProvider = { var ActivityStreamProvider = {
THUMB_FAVICON_SIZE: 96,
/** /**
* Shared adjustment for selecting potentially blocked links. * Shared adjustment for selecting potentially blocked links.
*/ */
@ -877,7 +879,10 @@ var ActivityStreamProvider = {
// Fetch the largest icon available. // Fetch the largest icon available.
let faviconData; let faviconData;
try { try {
faviconData = await PlacesUtils.promiseFaviconData(aUri, 0); faviconData = await PlacesUtils.promiseFaviconData(
aUri,
this.THUMB_FAVICON_SIZE
);
Object.assign(iconData, { Object.assign(iconData, {
favicon: faviconData.data, favicon: faviconData.data,
faviconLength: faviconData.dataLen, faviconLength: faviconData.dataLen,