nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1896816: Fail gracefully if a naughty client tries to QueryInterface on an MsaaAccessible from the wrong thread. r=eeejay

Browse source 
JAWS apparently does this sometimes.
In particular, this was causing a crash when we tried to check the UIA pref because that pref can only be accessed from the main thread.

Differential Revision: https://phabricator.services.mozilla.com/D210417
This commit is contained in:
James Teh 2024-05-15 21:59:03 +00:00
parent 4ac50f3930
commit 0156e587e9
1 changed files with 7 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
accessible/windows/msaa/MsaaAccessible.cpp
View file

@ -508,6 +508,13 @@ MsaaAccessible::QueryInterface(REFIID iid, void** ppv) {
return E_NOINTERFACE; return E_NOINTERFACE;
} }
if (NS_WARN_IF(!NS_IsMainThread())) {
// Bug 1896816: JAWS sometimes traverses into Gecko UI from a file dialog
// thread. It shouldn't do that, but let's fail gracefully instead of
// crashing.
return RPC_E_WRONG_THREAD;
}
// These interfaces are always available. We can support querying to them // These interfaces are always available. We can support querying to them
// even if the Accessible is dead. // even if the Accessible is dead.
if (IID_IUnknown == iid) { if (IID_IUnknown == iid) {