nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1609998 - Enable ESLint for non-third party files in editor/libeditor/tests/browserscope/. r=m_kato

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D60305

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Mark Banner 2020-01-21 17:00:48 +00:00
parent e88d437de8
commit 07db0a7e2b
3 changed files with 19 additions and 18 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

3
.eslintignore
View file

@ -137,9 +137,6 @@ dom/workers/test/importScripts_worker_imported3.js
dom/workers/test/invalid.js dom/workers/test/invalid.js
dom/workers/test/threadErrors_worker1.js dom/workers/test/threadErrors_worker1.js
# Third-party
editor/libeditor/tests/browserscope/
# intl/ exclusions # intl/ exclusions
intl/locale/ intl/locale/
intl/strres/ intl/strres/

2
editor/libeditor/tests/browserscope/test_richtext.html
View file

@ -27,7 +27,7 @@ function sendScore(results, continueParams) {
ok(results.length > 1, "At least one test should have been run"); ok(results.length > 1, "At least one test should have been run");
for (var i = 1; i < results.length; ++i) { for (var i = 1; i < results.length; ++i) {
var result = results[i]; var result = results[i];
[type, command, param, success] = result.split(/[\-=]/); let [type, command, param, success] = result.split(/[\-=]/);
var comp = is; var comp = is;
if (isKnownFailure(type, command, param)) { if (isKnownFailure(type, command, param)) {
comp = todo_is; comp = todo_is;

28
editor/libeditor/tests/browserscope/test_richtext2.html
View file

@ -68,10 +68,13 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
); );
} }
/* eslint-disable-next-line complexity */
function runTest() { function runTest() {
initVariables(); initVariables();
initEditorDocs(); initEditorDocs();
// These are all globals in the js and py files above */
/* eslint-disable no-undef */
const tests = [ const tests = [
SELECTION_TESTS, SELECTION_TESTS,
APPLY_TESTS, APPLY_TESTS,
@ -89,8 +92,9 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
QUERYSTATE_TESTS, QUERYSTATE_TESTS,
QUERYVALUE_TESTS, QUERYVALUE_TESTS,
]; ];
/* eslint-enable no-undef */
for (var i = 0; i < tests.length; ++i) { for (let i = 0; i < tests.length; ++i) {
runTestSuite(tests[i]); runTestSuite(tests[i]);
} }
@ -132,10 +136,10 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
// 'body' (test within a <body contenteditable="true">) // 'body' (test within a <body contenteditable="true">)
if (UPDATE_TEST_RESULTS) { if (UPDATE_TEST_RESULTS) {
var newKnownFailures = {value: {}, select: {}}; let newKnownFailures = {value: {}, select: {}};
for (var i = 0; i < tests.length; ++i) { for (let i = 0; i < tests.length; ++i) {
var category = tests[i]; let category = tests[i];
for (var group in results[category.id]) { for (let group in results[category.id]) {
switch (group) { switch (group) {
// Skip the known properties // Skip the known properties
case "count": case "count":
@ -144,7 +148,7 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
case "time": case "time":
break; break;
default: default:
for (var test_id in results[category.id][group]) { for (let test_id in results[category.id][group]) {
switch (test_id) { switch (test_id) {
// Skip the known properties // Skip the known properties
case "count": case "count":
@ -152,7 +156,7 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
case "selscore": case "selscore":
break; break;
default: default:
for (var structure in results[category.id][group][test_id]) { for (let structure in results[category.id][group][test_id]) {
switch (structure) { switch (structure) {
// Only look at each test structure // Only look at each test structure
case "dM": case "dM":
@ -175,9 +179,9 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
resultContainer.style.display = ""; resultContainer.style.display = "";
resultContainer.textContent = JSON.stringify(newKnownFailures); resultContainer.textContent = JSON.stringify(newKnownFailures);
} else { } else {
for (var i = 0; i < tests.length; ++i) { for (let i = 0; i < tests.length; ++i) {
var category = tests[i]; let category = tests[i];
for (var group in results[category.id]) { for (let group in results[category.id]) {
switch (group) { switch (group) {
// Skip the known properties // Skip the known properties
case "count": case "count":
@ -186,7 +190,7 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
case "time": case "time":
break; break;
default: default:
for (var test_id in results[category.id][group]) { for (let test_id in results[category.id][group]) {
switch (test_id) { switch (test_id) {
// Skip the known properties // Skip the known properties
case "count": case "count":
@ -194,7 +198,7 @@ http://code.google.com/p/browserscope/source/browse/trunk/categories/richtext2/u
case "selscore": case "selscore":
break; break;
default: default:
for (var structure in results[category.id][group][test_id]) { for (let structure in results[category.id][group][test_id]) {
switch (structure) { switch (structure) {
// Only look at each test structure // Only look at each test structure
case "dM": case "dM":