From 090cb0c41b01470112bab399f4b81743d90b3fd8 Mon Sep 17 00:00:00 2001 From: Bobby Holley Date: Mon, 17 Oct 2022 17:20:28 +0000 Subject: [PATCH] Bug 1795025 - Remove early-beta gate from WebMIDI. r=gsvelto This reverts bug 1765894. Differential Revision: https://phabricator.services.mozilla.com/D159419 --- .../mochitest/general/test_interfaces.js | 20 ++--- modules/libpref/init/StaticPrefList.yaml | 6 +- .../reporting/midi-reporting.https.html.ini | 2 - .../webmidi/idlharness.https.window.js.ini | 85 ------------------- 4 files changed, 9 insertions(+), 104 deletions(-) diff --git a/dom/tests/mochitest/general/test_interfaces.js b/dom/tests/mochitest/general/test_interfaces.js index 7dc8537dea23..c9a9b9caf290 100644 --- a/dom/tests/mochitest/general/test_interfaces.js +++ b/dom/tests/mochitest/general/test_interfaces.js @@ -762,25 +762,21 @@ let interfaceNamesInGlobalScope = [ // IMPORTANT: Do not change this list without review from a DOM peer! { name: "MessagePort", insecureContext: true }, // IMPORTANT: Do not change this list without review from a DOM peer! - { name: "MIDIAccess", android: false, disabled: !isEarlyBetaOrEarlier }, + { name: "MIDIAccess", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! - { - name: "MIDIConnectionEvent", - android: false, - disabled: !isEarlyBetaOrEarlier, - }, + { name: "MIDIConnectionEvent", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! - { name: "MIDIInputMap", android: false, disabled: !isEarlyBetaOrEarlier }, + { name: "MIDIInputMap", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! - { name: "MIDIInput", android: false, disabled: !isEarlyBetaOrEarlier }, + { name: "MIDIInput", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! - { name: "MIDIMessageEvent", android: false, disabled: !isEarlyBetaOrEarlier }, + { name: "MIDIMessageEvent", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! - { name: "MIDIOutputMap", android: false, disabled: !isEarlyBetaOrEarlier }, + { name: "MIDIOutputMap", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! - { name: "MIDIOutput", android: false, disabled: !isEarlyBetaOrEarlier }, + { name: "MIDIOutput", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! - { name: "MIDIPort", android: false, disabled: !isEarlyBetaOrEarlier }, + { name: "MIDIPort", android: false }, // IMPORTANT: Do not change this list without review from a DOM peer! { name: "MimeType", insecureContext: true }, // IMPORTANT: Do not change this list without review from a DOM peer! diff --git a/modules/libpref/init/StaticPrefList.yaml b/modules/libpref/init/StaticPrefList.yaml index 818fa16a7254..d1abae9597ad 100644 --- a/modules/libpref/init/StaticPrefList.yaml +++ b/modules/libpref/init/StaticPrefList.yaml @@ -4419,11 +4419,7 @@ # Whether the WebMIDI API is enabled - name: dom.webmidi.enabled type: bool -#if !defined(MOZ_WIDGET_ANDROID) && defined(EARLY_BETA_OR_EARLIER) - value: true -#else - value: false -#endif + value: @IS_NOT_ANDROID@ mirror: always # midi permission is addon-gated diff --git a/testing/web-platform/meta/permissions-policy/reporting/midi-reporting.https.html.ini b/testing/web-platform/meta/permissions-policy/reporting/midi-reporting.https.html.ini index d17d673145ae..08cd80fca358 100644 --- a/testing/web-platform/meta/permissions-policy/reporting/midi-reporting.https.html.ini +++ b/testing/web-platform/meta/permissions-policy/reporting/midi-reporting.https.html.ini @@ -1,12 +1,10 @@ [midi-reporting.https.html] expected: if os == "android": OK - if not early_beta_or_earlier: OK TIMEOUT [MIDI Report Format] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL TIMEOUT diff --git a/testing/web-platform/meta/webmidi/idlharness.https.window.js.ini b/testing/web-platform/meta/webmidi/idlharness.https.window.js.ini index c8325d535ce5..156e8ae6756f 100644 --- a/testing/web-platform/meta/webmidi/idlharness.https.window.js.ini +++ b/testing/web-platform/meta/webmidi/idlharness.https.window.js.ini @@ -2,420 +2,335 @@ [MIDIAccess must be primary interface of access] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInput interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: attribute outputs] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap must be primary interface of inputs] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: access must inherit property "outputs" with the proper type] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIMessageEvent interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInput interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute version] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute onstatechange] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInput interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: operation open()] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: attribute inputs] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [Stringification of inputs] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: access must inherit property "inputs" with the proper type] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIMessageEvent interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: access must inherit property "onstatechange" with the proper type] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInput interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInput interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: access must inherit property "sysexEnabled" with the proper type] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIMessageEvent interface: attribute data] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [Stringification of outputs] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute connection] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIMessageEvent interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface: operation clear()] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: operation close()] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute manufacturer] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute type] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: attribute sysexEnabled] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInput interface: attribute onmidimessage] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: attribute onstatechange] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIMessageEvent interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface: attribute port] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [Stringification of new MIDIConnectionEvent("type")] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface: new MIDIConnectionEvent("type") must inherit property "port" with the proper type] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: existence and properties of interface prototype object's "constructor" property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [idl_test setup] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent interface: existence and properties of interface object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIConnectionEvent must be primary interface of new MIDIConnectionEvent("type")] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute state] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIMessageEvent interface object length] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [Stringification of access] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIMessageEvent interface: existence and properties of interface prototype object] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap must be primary interface of outputs] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIAccess interface: existence and properties of interface prototype object's @@unscopables property] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIPort interface: attribute id] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInput interface object name] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [Navigator interface: operation requestMIDIAccess(optional MIDIOptions)] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutput interface: operation send(sequence, optional DOMHighResTimeStamp)] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIInputMap interface: maplike] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL [MIDIOutputMap interface: maplike] expected: if os == "android": FAIL - if not early_beta_or_earlier: FAIL -