nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1676551 - part2 : create promise before calling cubeb start. r=padenot

Browse source 
As cubeb might call audio stream's state callback very soon after we start cubeb, we have to create the promise beforehand in order to handle the case where we immediately get `drained`.

Differential Revision: https://phabricator.services.mozilla.com/D96770
This commit is contained in:
alwu 2020-11-13 12:21:13 +00:00
parent f798106d65
commit 0951f9218a
1 changed files with 11 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

15
dom/media/AudioStream.cpp
View file

@ -368,17 +368,24 @@ AudioStream::Start() {
MonitorAutoLock mon(mMonitor);
MOZ_ASSERT(mState == INITIALIZED);
mState = STARTED;
// As cubeb might call audio stream's state callback very soon after we start
// cubeb, we have to create the promise beforehand in order to handle the
// case where we immediately get `drained`.
RefPtr<MediaSink::EndedPromise> promise = mEndedPromise.Ensure(__func__);
mPlaybackComplete = false;
if (InvokeCubeb(cubeb_stream_start) != CUBEB_OK) {
mState = ERRORED;
}
LOG("started, state %s", mState == STARTED
? "STARTED"
: mState == DRAINED ? "DRAINED" : "ERRORED");
if (mState != STARTED && mState != DRAINED) {
return Err(NS_ERROR_FAILURE);
if (mState == STARTED || mState == DRAINED) {
return promise.forget();
}
mPlaybackComplete = false;
return mEndedPromise.Ensure(__func__);
return Err(NS_ERROR_FAILURE);
}
void AudioStream::Pause() {