From 10c3e367f43e006626ab510ac9a445c3bd2a903e Mon Sep 17 00:00:00 2001 From: Geoff Brown Date: Mon, 12 Feb 2024 11:59:54 +0100 Subject: [PATCH] Bug 1825116 - Add lint exclusions for some troublesome firefox-android files. r=Standard8,bhearsum,geckoview-reviewers,releng-reviewers Differential Revision: https://phabricator.services.mozilla.com/D201455 --- .eslintignore | 28 +++++++++++++++ .prettierignore | 8 +++++ .stylelintignore | 6 ++++ tools/lint/codespell.yml | 5 +++ tools/lint/file-whitespace.yml | 62 ++++++++++++++++++++++++++++++++++ tools/lint/license.yml | 45 ++++++++++++++++++++++++ tools/lint/rejected-words.yml | 10 ++++++ 7 files changed, 164 insertions(+) diff --git a/.eslintignore b/.eslintignore index ab309a7cb9de..b99c7e20a6f3 100644 --- a/.eslintignore +++ b/.eslintignore @@ -189,6 +189,34 @@ mobile/android/app/geckoview-prefs.js mobile/android/installer/ mobile/android/locales/ +# TODO - Bug 1881094: temporarily ignored for firefox-android migration +mobile/android/android-components/components/browser/engine-system/src/main/res/raw/domain_blocklist.json +mobile/android/android-components/components/browser/engine-system/src/main/res/raw/domain_safelist.json +mobile/android/android-components/components/browser/errorpages/src/main/assets/errorPageScripts.js +mobile/android/android-components/components/browser/errorpages/src/main/assets/error_page_js.html +mobile/android/android-components/components/browser/icons/src/main/assets/extensions/browser-icons/icons.js +mobile/android/android-components/components/browser/session-storage/src/androidTest/assets/index.html +mobile/android/android-components/components/concept/engine/src/test/resources/manifests/example_mdn.json +mobile/android/android-components/components/concept/engine/src/test/resources/manifests/invalid_json.json +mobile/android/android-components/components/concept/engine/src/test/resources/manifests/spec_typical.json +mobile/android/android-components/components/concept/engine/src/test/resources/manifests/twitter_mobile.json +mobile/android/android-components/components/feature/accounts/src/main/assets/extensions/fxawebchannel/background.js +mobile/android/android-components/components/feature/accounts/src/main/assets/extensions/fxawebchannel/fxawebchannel.js +mobile/android/android-components/components/feature/addons/src/test/resources/collection.json +mobile/android/android-components/components/feature/addons/src/test/resources/collection_with_empty_values.json +mobile/android/android-components/components/feature/addons/src/test/resources/localized_collection.json +mobile/android/android-components/components/feature/readerview/src/main/assets/extensions/readerview/ +mobile/android/android-components/components/feature/search/src/main/assets/extensions/ads/adsTelemetry.js +mobile/android/android-components/components/feature/search/src/main/assets/extensions/search/searchTelemetry.js +mobile/android/android-components/components/feature/webcompat-reporter/src/main/assets/ +mobile/android/android-components/components/feature/webcompat/src/main/assets/extensions/webcompat/ +mobile/android/android-components/samples/browser/src/main/assets/extensions/test/background.js +mobile/android/fenix/app/src/androidTest/assets/ +mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/syncintegration/ +mobile/android/fenix/app/src/main/assets/ +mobile/android/focus-android/app/src/androidTest/assets/ +mobile/android/docs/assets/js/icon-js.js + # Pre-processed/pref files modules/libpref/greprefs.js modules/libpref/init/all.js diff --git a/.prettierignore b/.prettierignore index 85a1f534746c..1186e3308ce4 100644 --- a/.prettierignore +++ b/.prettierignore @@ -1150,6 +1150,14 @@ mobile/android/docs/geckoview/assets/js/search-data.json # Uses `#filter substitution` mobile/android/app/geckoview-prefs.js +# TODO - Bug 1881094: temporarily ignored for firefox-android migration +mobile/android/android-components/ +mobile/android/fenix/ +mobile/android/focus-android/ +mobile/android/docs/_includes/ +mobile/android/docs/_layouts/ +mobile/android/docs/assets/js/icon-js.js + # Not much JS to lint and non-standard at that mobile/android/installer/ mobile/android/locales/ diff --git a/.stylelintignore b/.stylelintignore index 500f560cfb78..d260d799e43e 100644 --- a/.stylelintignore +++ b/.stylelintignore @@ -76,6 +76,12 @@ layout/style/test/gtest/example.css layout/style/test/mapped2.css layout/style/test/unstyled-frame.css +# TODO - Bug 1881094: temporarily ignored for firefox-android migration +mobile/android/android-components/components/feature/readerview/src/main/assets/extensions/readerview/readerview.css +mobile/android/android-components/components/feature/webcompat/src/main/assets/extensions/webcompat/about-compat/aboutCompat.css +mobile/android/docs/assets/main.scss +mobile/android/fenix/app/src/main/assets/shared_error_style.css + # Empty test files: netwerk/test/mochitests/test1.css netwerk/test/mochitests/test2.css diff --git a/tools/lint/codespell.yml b/tools/lint/codespell.yml index 9f821f629614..7539e780b3a4 100644 --- a/tools/lint/codespell.yml +++ b/tools/lint/codespell.yml @@ -66,6 +66,11 @@ codespell: - xpcom/docs/ exclude: - devtools/docs/contributor/tools/storage/ + # TODO - Bug 1881094: temporarily ignored for firefox-android migration + - mobile/android/docs/Gemfile.lock + - mobile/android/docs/_config.yml + - mobile/android/docs/changelog_archive.md + - mobile/android/docs/shared/uplift_guide.md - tools/lint/cpp/mingw-headers.txt - tools/lint/test/test_codespell.py - "**/package-lock.json" diff --git a/tools/lint/file-whitespace.yml b/tools/lint/file-whitespace.yml index 91a8ed2103cd..dd33fd6942bb 100644 --- a/tools/lint/file-whitespace.yml +++ b/tools/lint/file-whitespace.yml @@ -146,6 +146,68 @@ file-whitespace: - python/mozperftest/perfdocs/running.rst - python/mozperftest/perfdocs/vision.rst - python/mozperftest/perfdocs/writing.rst + # TODO - Bug 1881094: temporarily ignored for firefox-android migration + - mobile/android/android-components/automation/taskcluster/androidTest/flank-x86.yml + - mobile/android/android-components/components/browser/errorpages/README.md + - mobile/android/android-components/components/browser/engine-gecko/geckoview.fml.yaml + - mobile/android/android-components/components/browser/engine-system/src/main/res/raw/domain_blocklist.json + - mobile/android/android-components/components/browser/engine-system/src/main/res/raw/domain_safelist.json + - mobile/android/android-components/components/concept/engine/src/test/resources/manifests/invalid_json.json + - mobile/android/android-components/components/concept/engine/src/test/resources/manifests/twitter_mobile.json + - mobile/android/android-components/components/feature/addons/schemas/mozilla.components.feature.addons.update.db.UpdateAttemptsDatabase/1.json + - mobile/android/android-components/components/feature/addons/src/test/resources/localized_collection.json + - mobile/android/android-components/components/feature/containers/schemas/mozilla.components.feature.containers.db.ContainerDatabase/1.json + - mobile/android/android-components/components/feature/downloads/README.md + - mobile/android/android-components/components/feature/downloads/schemas/mozilla.components.feature.downloads.db.DownloadsDatabase/1.json + - mobile/android/android-components/components/feature/downloads/schemas/mozilla.components.feature.downloads.db.DownloadsDatabase/2.json + - mobile/android/android-components/components/feature/downloads/schemas/mozilla.components.feature.downloads.db.DownloadsDatabase/3.json + - mobile/android/android-components/components/feature/downloads/schemas/mozilla.components.feature.downloads.db.DownloadsDatabase/4.json + - mobile/android/android-components/components/feature/logins/schemas/mozilla.components.feature.logins.exceptions.db.LoginExceptionDatabase/1.json + - mobile/android/android-components/components/feature/pwa/schemas/mozilla.components.feature.pwa.db.ManifestDatabase/0.json + - mobile/android/android-components/components/feature/pwa/schemas/mozilla.components.feature.pwa.db.ManifestDatabase/1.json + - mobile/android/android-components/components/feature/pwa/schemas/mozilla.components.feature.pwa.db.ManifestDatabase/2.json + - mobile/android/android-components/components/feature/pwa/schemas/mozilla.components.feature.pwa.db.ManifestDatabase/3.json + - mobile/android/android-components/components/feature/recentlyclosed/schemas/mozilla.components.feature.recentlyclosed.db.RecentlyClosedTabsDatabase/1.json + - mobile/android/android-components/components/feature/search/src/main/assets/search/search_telemetry_v2.json + - mobile/android/android-components/components/feature/share/schemas/mozilla.components.feature.share.db.RecentAppsDatabase/1.json + - mobile/android/android-components/components/feature/share/schemas/mozilla.components.feature.share.db.RecentAppsDatabase/2.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/1.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/2.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/3.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/4.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/5.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/6.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/7.json + - mobile/android/android-components/components/feature/sitepermissions/schemas/mozilla.components.feature.sitepermissions.db.SitePermissionsDatabase/8.json + - mobile/android/android-components/components/feature/tab-collections/schemas/mozilla.components.feature.tab.collections.db.TabCollectionDatabase/1.json + - mobile/android/android-components/components/feature/top-sites/schemas/mozilla.components.feature.top.sites.db.TopSiteDatabase/1.json + - mobile/android/android-components/components/feature/top-sites/schemas/mozilla.components.feature.top.sites.db.TopSiteDatabase/3.json + - mobile/android/android-components/components/lib/crash/schemas/mozilla.components.lib.crash.db.CrashDatabase/1.json + - mobile/android/android-components/components/service/nimbus/messaging.fml.yaml + - mobile/android/android-components/components/service/pocket/schemas/mozilla.components.service.pocket.stories.db.PocketRecommendationsDatabase/1.json + - mobile/android/android-components/components/service/pocket/schemas/mozilla.components.service.pocket.stories.db.PocketRecommendationsDatabase/2.json + - mobile/android/android-components/components/service/pocket/schemas/mozilla.components.service.pocket.stories.db.PocketRecommendationsDatabase/3.json + - mobile/android/android-components/components/service/pocket/schemas/mozilla.components.service.pocket.stories.db.PocketRecommendationsDatabase/4.json + - mobile/android/android-components/components/support/license/src/test/resources/robolectric.properties + - mobile/android/android-components/components/support/remotesettings/src/test/java/mozilla/components/support/remotesettings/RemoteSettingsClientTest.kt + - mobile/android/android-components/samples/browser/src/androidTest/assets/index.html + - mobile/android/docs/contribute/merge_day.md + - mobile/android/docs/rfcs/0004-top-sites-feature.md + - mobile/android/docs/rfcs/0011-decouple-home-activity-and-external-app-browser-activity.md + - mobile/android/fenix/app/src/androidTest/assets/pages/passwordsubmit.html + - mobile/android/fenix/docs/Acronym-dictionary.md + - mobile/android/fenix/docs/Guide-to-merging-contributor-PRs.md + - mobile/android/fenix/docs/Test-telemetry-pings.md + - mobile/android/fenix/docs/release-checklist.md + - mobile/android/fenix/docs/substituting-local-gv.md + - mobile/android/fenix/app/metrics.yaml + - mobile/android/fenix/app/nimbus.fml.yaml + - mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/experimentintegration/variables.yaml + - mobile/android/fenix/automation/taskcluster/androidTest/flank-arm-beta.yml + - mobile/android/fenix/docs/Firebase-Cloud-Messaging-for-WebPush.md + - mobile/android/fenix/mozilla-detekt-rules/src/main/resources/config.yml + - mobile/android/focus-android/automation/taskcluster/androidTest/flank-arm-beta.yml + extensions: - .c - .cc diff --git a/tools/lint/license.yml b/tools/lint/license.yml index c1cf7e628e36..4e5a8782e5d0 100644 --- a/tools/lint/license.yml +++ b/tools/lint/license.yml @@ -30,6 +30,9 @@ license: - gradle.properties # might not work with license - gradle/wrapper/gradle-wrapper.properties + - mobile/android/android-components/gradle/wrapper/gradle-wrapper.properties + - mobile/android/fenix/gradle/wrapper/gradle-wrapper.properties + - mobile/android/focus-android/gradle/wrapper/gradle-wrapper.properties # ICU4X data - intl/icu_segmenter_data # Imported code that is dual Apache2 / MIT licensed @@ -41,6 +44,48 @@ license: - mobile/android/geckoview_example/src/main - testing/webcompat/interventions/ - testing/webcompat/shims/ + # TODO - Bug 1881094: temporarily ignored for firefox-android migration + - mobile/android/android-components/components/browser/engine-system/src/main/res/ + - mobile/android/android-components/components/browser/errorpages/src/main/res/ + - mobile/android/android-components/components/browser/menu/src/main/res/ + - mobile/android/android-components/components/browser/menu2/src/main/res/ + - mobile/android/android-components/components/browser/toolbar/src/main/res/ + - mobile/android/android-components/components/compose/awesomebar/src/main/res/ + - mobile/android/android-components/components/compose/browser-toolbar/src/main/res/ + - mobile/android/android-components/components/compose/cfr/src/main/res/ + - mobile/android/android-components/components/compose/tabstray/src/main/res/ + - mobile/android/android-components/components/feature/addons/src/main/res/ + - mobile/android/android-components/components/feature/app-links/src/main/res/ + - mobile/android/android-components/components/feature/autofill/src/main/res/ + - mobile/android/android-components/components/feature/awesomebar/src/main/res/ + - mobile/android/android-components/components/feature/contextmenu/src/main/res/ + - mobile/android/android-components/components/feature/customtabs/src/main/res/ + - mobile/android/android-components/components/feature/downloads/src/main/res/ + - mobile/android/android-components/components/feature/findinpage/src/main/res/ + - mobile/android/android-components/components/feature/fxsuggest/src/main/res/ + - mobile/android/android-components/components/feature/media/src/main/res/ + - mobile/android/android-components/components/feature/privatemode/src/main/res/ + - mobile/android/android-components/components/feature/prompts/src/main/res/ + - mobile/android/android-components/components/feature/pwa/src/main/res/ + - mobile/android/android-components/components/feature/qr/src/main/res/ + - mobile/android/android-components/components/feature/readerview/src/main/res/ + - mobile/android/android-components/components/feature/search/src/main/res/ + - mobile/android/android-components/components/feature/sitepermissions/ + - mobile/android/android-components/components/feature/tabs/src/main/res/ + - mobile/android/android-components/components/feature/webcompat/src/main/assets/extensions/webcompat/injections/ + - mobile/android/android-components/components/feature/webnotifications/src/main/res/ + - mobile/android/android-components/components/lib/crash/src/main/res/ + - mobile/android/android-components/components/service/nimbus/src/main/res/ + - mobile/android/android-components/components/support/base/src/main/res/ + - mobile/android/android-components/components/support/ktx/src/main/res/ + - mobile/android/android-components/components/support/utils/src/main/res/ + - mobile/android/android-components/components/ui/tabcounter/src/main/res/ + - mobile/android/android-components/components/ui/widgets/src/main/res/ + - mobile/android/docs/ + - mobile/android/fenix/app/src/main/res/ + - mobile/android/fenix/benchmark/src/main/AndroidManifest.xml + - mobile/android/focus-android/app/lint-baseline.xml + - mobile/android/focus-android/app/src/main/res/ # might not work with license - mobile/android/gradle/dotgradle-offline/gradle.properties # might not work with license diff --git a/tools/lint/rejected-words.yml b/tools/lint/rejected-words.yml index d45bcf5d089e..a0b25d802749 100644 --- a/tools/lint/rejected-words.yml +++ b/tools/lint/rejected-words.yml @@ -303,6 +303,16 @@ avoid-blacklist-and-whitelist: - widget/windows/WinUtils.h - xpcom/io/FilePreferences.cpp - xpcom/tests/gtest/TestFilePreferencesUnix.cpp + # TODO - Bug 1881094: temporarily ignored for firefox-android migration + - mobile/android/android-components/components/feature/webcompat/src/main/assets/extensions/webcompat/shims/nielsen.js + - mobile/android/docs/changelog.md + - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/ext/Bitmap.kt + - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StrictModeManager.kt + - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/translations/preferences/downloadlanguages/DownloadLanguagesFeature.kt + - mobile/android/fenix/app/src/test/java/org/mozilla/fenix/translations/preferences/downloadlanguages/DownloadLanguagesFeatureTest.kt + - mobile/android/focus-android/app/src/main/res/values-ar/strings.xml + - mobile/android/focus-android/app/src/main/res/values-et/strings.xml + - mobile/android/focus-android/app/src/main/res/values-lt/strings.xml # --- # Disable for now. Needs some dev to handle this