nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1829630 - [bidi] Throw explicit error for missing stacks in script module r=webdriver-reviewers,Sasha

Browse source 
Depends on D176353

Differential Revision: https://phabricator.services.mozilla.com/D176354
This commit is contained in:
Julian Descottes 2023-04-27 16:53:29 +00:00
parent 93f5685ca6
commit 111dd3a198
1 changed files with 11 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

12
remote/webdriver-bidi/modules/windowglobal/script.sys.mjs
View file

@ -66,8 +66,18 @@ class ScriptModule extends WindowGlobalBiDiModule {
#buildExceptionDetails(exception, stack, realm, resultOwnership, options) { #buildExceptionDetails(exception, stack, realm, resultOwnership, options) {
exception = this.#toRawObject(exception); exception = this.#toRawObject(exception);
const frames = lazy.getFramesFromStack(stack) || [];
// A stacktrace is mandatory to build exception details and a missing stack
// means we encountered an unexpected issue. Throw with an explicit error.
if (!stack) {
throw new Error(
`Missing stack, unable to build exceptionDetails for exception: ${lazy.stringify(
exception
)}`
);
}
const frames = lazy.getFramesFromStack(stack) || [];
const callFrames = frames const callFrames = frames
// Remove chrome/internal frames // Remove chrome/internal frames
.filter(frame => !lazy.isChromeFrame(frame)) .filter(frame => !lazy.isChromeFrame(frame))