From 1123bc066695e6e0f8d258d89bb583f832b04061 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Fri, 24 Aug 2018 12:03:23 +0000 Subject: [PATCH] Bug 1485937 - Avoid a useless allocation in wr_dp_define_clipchain. r=nical Differential Revision: https://phabricator.services.mozilla.com/D4196 --HG-- extra : moz-landing-system : lando --- gfx/webrender_bindings/src/bindings.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gfx/webrender_bindings/src/bindings.rs b/gfx/webrender_bindings/src/bindings.rs index b724adfae9a4..f58a86f64fbf 100644 --- a/gfx/webrender_bindings/src/bindings.rs +++ b/gfx/webrender_bindings/src/bindings.rs @@ -1770,12 +1770,12 @@ pub extern "C" fn wr_dp_define_clipchain(state: &mut WrState, -> u64 { debug_assert!(unsafe { is_in_main_thread() }); let parent = unsafe { parent_clipchain_id.as_ref() }.map(|id| ClipChainId(*id, state.pipeline_id)); - let clips_slice : Vec = make_slice(clips, clips_count) + let pipeline_id = state.pipeline_id; + let clips = make_slice(clips, clips_count) .iter() - .map(|id| unpack_clip_id(*id, state.pipeline_id)) - .collect(); + .map(|id| unpack_clip_id(*id, pipeline_id)); - let clipchain_id = state.frame_builder.dl_builder.define_clip_chain(parent, clips_slice); + let clipchain_id = state.frame_builder.dl_builder.define_clip_chain(parent, clips); assert!(clipchain_id.1 == state.pipeline_id); clipchain_id.0 }