nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1442967 - Boo, MSVC warns when a cast will truncate a numeric constant. Arguably a desirable warning generally, but here we specifically intend the cast to narrow, so disable the warning. r=me in a CLOSED TREE

Browse source
This commit is contained in:
Jeff Walden 2018-03-12 19:20:42 -07:00
parent 5bbc8d23df
commit 15bf6fd876
1 changed files with 11 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

11
mfbt/tests/TestEndian.cpp
View file

@ -368,12 +368,23 @@ main()
BigEndian::readUint64(&unsigned_bytes[0]) == 0x0102030405060708ULL);
if (sizeof(uintptr_t) == 8) {
// MSVC warning C4309 is "'static_cast': truncation of constant value" and
// will hit for the literal casts below in 32-bit builds -- in dead code,
// because only the other arm of this |if| runs. Turn off the warning for
// these two uses in dead code.
#ifdef _MSC_VER
# pragma warning(push)
# pragma warning(disable: 4309)
#endif
MOZ_RELEASE_ASSERT(
LittleEndian::readUintptr(&unsigned_bytes[0]) ==
static_cast<uintptr_t>(0x0807060504030201ULL));
MOZ_RELEASE_ASSERT(
BigEndian::readUintptr(&unsigned_bytes[0]) ==
static_cast<uintptr_t>(0x0102030405060708ULL));
#ifdef _MSC_VER
# pragma warning(pop)
#endif
} else {
MOZ_RELEASE_ASSERT(
LittleEndian::readUintptr(&unsigned_bytes[0]) == 0x04030201U);