nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1819211 - Export Baseline.h under mozilla. r=emilio

Browse source 
It is because `Baseline` is a utility class under `namespace mozilla`.

Also change the include guard to match the coding style.
https://firefox-source-docs.mozilla.org/code-quality/coding-style/coding_style_cpp.html#header-files

Differential Revision: https://phabricator.services.mozilla.com/D171162
This commit is contained in:
Ting-Yu Lin 2023-03-01 03:50:03 +00:00
parent 051c921a72
commit 19a0c5fb59
10 changed files with 13 additions and 12 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
layout/base/Baseline.h
View file

@ -2,8 +2,8 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef BaselineUtils_h___
#define BaselineUtils_h___
#ifndef LAYOUT_BASE_BASELINE_H_
#define LAYOUT_BASE_BASELINE_H_
#include "nsCoord.h"
#include "mozilla/WritingModes.h"
@ -41,4 +41,5 @@ class Baseline {
};
} // namespace mozilla
#endif // BaselineUtils_h___
#endif // LAYOUT_BASE_BASELINE_H_

2
layout/base/moz.build
View file

@ -33,7 +33,6 @@ if CONFIG["MOZ_DEBUG"]:
XPIDL_MODULE = "layout_base"
EXPORTS += [
"Baseline.h",
"CaretAssociationHint.h",
"FrameProperties.h",
"LayoutConstants.h",
@ -73,6 +72,7 @@ EXPORTS += [
EXPORTS.mozilla += [
"AccessibleCaretEventHub.h",
"ArenaObjectID.h",
"Baseline.h",
"ContainStyleScopeManager.h",
"DepthOrderedFrameList.h",
"DisplayPortUtils.h",

2
layout/base/nsLayoutUtils.cpp
View file

@ -29,6 +29,7 @@
#include "MobileViewportManager.h"
#include "mozilla/AccessibleCaretEventHub.h"
#include "mozilla/ArrayUtils.h"
#include "mozilla/Baseline.h"
#include "mozilla/BasicEvents.h"
#include "mozilla/ClearOnShutdown.h"
#include "mozilla/DisplayPortUtils.h"
@ -152,7 +153,6 @@
#include "nsTransitionManager.h"
#include "nsView.h"
#include "nsViewManager.h"
#include "Baseline.h"
#include "prenv.h"
#include "RegionBuilder.h"
#include "RetainedDisplayListBuilder.h"

2
layout/forms/nsFieldSetFrame.cpp
View file

@ -9,6 +9,7 @@
#include <algorithm>
#include "gfxContext.h"
#include "mozilla/Baseline.h"
#include "mozilla/gfx/2D.h"
#include "mozilla/Likely.h"
#include "mozilla/PresShell.h"
@ -24,7 +25,6 @@
#include "nsIScrollableFrame.h"
#include "nsLayoutUtils.h"
#include "nsStyleConsts.h"
#include "Baseline.h"
using namespace mozilla;
using namespace mozilla::gfx;

2
layout/forms/nsHTMLButtonControlFrame.cpp
View file

@ -6,6 +6,7 @@
#include "nsHTMLButtonControlFrame.h"
#include "mozilla/Baseline.h"
#include "mozilla/PresShell.h"
#include "nsContainerFrame.h"
#include "nsIFormControlFrame.h"
@ -16,7 +17,6 @@
#include "nsCSSAnonBoxes.h"
#include "nsNameSpaceManager.h"
#include "nsDisplayList.h"
#include "Baseline.h"
#include <algorithm>
using namespace mozilla;

2
layout/generic/nsBlockFrame.cpp
View file

@ -14,6 +14,7 @@
#include "gfxContext.h"
#include "mozilla/AppUnits.h"
#include "mozilla/Baseline.h"
#include "mozilla/ComputedStyle.h"
#include "mozilla/DebugOnly.h"
#include "mozilla/Maybe.h"
@ -63,7 +64,6 @@
#include "mozilla/ServoStyleSet.h"
#include "mozilla/Telemetry.h"
#include "nsFlexContainerFrame.h"
#include "Baseline.h"
#include "nsBidiPresUtils.h"

2
layout/generic/nsFlexContainerFrame.cpp
View file

@ -11,6 +11,7 @@
#include <algorithm>
#include "gfxContext.h"
#include "mozilla/Baseline.h"
#include "mozilla/ComputedStyle.h"
#include "mozilla/CSSOrderAwareFrameIterator.h"
#include "mozilla/FloatingPoint.h"
@ -27,7 +28,6 @@
#include "nsLayoutUtils.h"
#include "nsPlaceholderFrame.h"
#include "nsPresContext.h"
#include "Baseline.h"
using namespace mozilla;
using namespace mozilla::layout;

2
layout/generic/nsGridContainerFrame.cpp
View file

@ -14,6 +14,7 @@
#include <type_traits>
#include "gfxContext.h"
#include "mozilla/AutoRestore.h"
#include "mozilla/Baseline.h"
#include "mozilla/ComputedStyle.h"
#include "mozilla/CSSAlignUtils.h"
#include "mozilla/StaticPrefs_layout.h"
@ -38,7 +39,6 @@
#include "nsPresContext.h"
#include "nsReadableUtils.h"
#include "nsTableWrapperFrame.h"
#include "Baseline.h"
using namespace mozilla;

2
layout/generic/nsIFrame.h
View file

@ -54,6 +54,7 @@
#include "LayoutConstants.h"
#include "mozilla/AspectRatio.h"
#include "mozilla/Attributes.h"
#include "mozilla/Baseline.h"
#include "mozilla/EventForwards.h"
#include "mozilla/Maybe.h"
#include "mozilla/RelativeTo.h"
@ -81,7 +82,6 @@
#include "nsDisplayItemTypes.h"
#include "nsPresContext.h"
#include "nsTHashSet.h"
#include "Baseline.h"
#ifdef ACCESSIBILITY
# include "mozilla/a11y/AccTypes.h"

2
layout/tables/nsTableRowFrame.cpp
View file

@ -5,6 +5,7 @@
#include "nsTableRowFrame.h"
#include "mozilla/Baseline.h"
#include "mozilla/Maybe.h"
#include "mozilla/PresShell.h"
#include "nsTableRowGroupFrame.h"
@ -25,7 +26,6 @@
#include "nsCOMPtr.h"
#include "nsDisplayList.h"
#include "nsIFrameInlines.h"
#include "Baseline.h"
#include <algorithm>
#ifdef ACCESSIBILITY