nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1533424 - Don't allow InspectorUtils to mess up with our UA sheets. r=heycam

Browse source 
You can mess up stuff pretty badly if that happens, and we want to do this
anyway for the shared UA sheet stuff, so...

Differential Revision: https://phabricator.services.mozilla.com/D22554

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Emilio Cobos Álvarez 2019-03-12 15:17:54 +00:00
parent 1ea7130261
commit 1daca69d91
2 changed files with 13 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
dom/tests/mochitest/chrome/test_parsingMode.html
View file

@ -42,7 +42,12 @@
// Check that re-parsing preserves the mode. // Check that re-parsing preserves the mode.
let mode = sheet.parsingMode; let mode = sheet.parsingMode;
InspectorUtils.parseStyleSheet(sheet, "body { color: chartreuse; }"); try {
InspectorUtils.parseStyleSheet(sheet, "body { color: chartreuse; }");
isnot(sheet.parsingMode, "agent", "Agent sheets cannot be reparsed");
} catch (ex) {
is(sheet.parsingMode, "agent", "Agent sheets cannot be reparsed");
}
is(sheet.parsingMode, mode, is(sheet.parsingMode, mode,
"check that re-parsing preserved mode " + mode); "check that re-parsing preserved mode " + mode);
} }

7
layout/style/StyleSheet.cpp
View file

@ -967,6 +967,13 @@ nsresult StyleSheet::ReparseSheet(const nsAString& aInput) {
return NS_ERROR_DOM_INVALID_ACCESS_ERR; return NS_ERROR_DOM_INVALID_ACCESS_ERR;
} }
// Allowing to modify UA sheets is dangerous (in the sense that C++ code
// relies on rules in those sheets), plus they're probably going to be shared
// across processes in which case this is directly a no-go.
if (GetOrigin() == OriginFlags::UserAgent) {
return NS_ERROR_DOM_NO_MODIFICATION_ALLOWED_ERR;
}
// Hold strong ref to the CSSLoader in case the document update // Hold strong ref to the CSSLoader in case the document update
// kills the document // kills the document
RefPtr<css::Loader> loader; RefPtr<css::Loader> loader;