nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1469769 - Part 1: a11y: Replace failing NS_NOTREACHED with NS_ERROR. r=surkov

Browse source 
This SelectionManager assertion fails when running the testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py TestBackForwardNavigation.test_non_remote_about_pages marionette test. This assertion failure is bug 1126649.

This patch DOES NOT fix the cause of the assertion failure (a missing HyperTextAccessible). It just replaces this failing NS_NOTREACHED with NS_ERROR because I am removing the NS_NOTREACHED macro.

MozReview-Commit-ID: EVfyZlMwN4p

--HG--
extra : source : 676e9eb651d710bae1c76c3dae86a5cb1bded4d7
extra : intermediate-source : 6bce8da694e6803b04e7492094fc65b2b0e49bbf
extra : histedit_source : 57073997ac23879767937eaa3b42f78f60d1c942
This commit is contained in:
Chris Peterson 2018-06-04 01:44:18 -07:00
parent 05d177e56a
commit 224e62cb6f
1 changed files with 2 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

3
accessible/base/SelectionManager.cpp
View file

@ -209,7 +209,8 @@ SelectionManager::ProcessSelectionChanged(SelData* aSelData)
HyperTextAccessible* text = nsAccUtils::GetTextContainer(cntrNode);
if (!text) {
NS_NOTREACHED("We must reach document accessible implementing text interface!");
// FIXME bug 1126649
NS_ERROR("We must reach document accessible implementing text interface!");
return;
}