nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1888227 - Fix cookie clearing in private browsing test on Android Fission r=valentin,timhuang,necko-reviewers

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D207063
This commit is contained in:
edgul 2024-05-02 15:04:38 +00:00
parent 126216a59b
commit 22e98eebc6
2 changed files with 12 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
netwerk/test/unit/test_cookies_privatebrowsing.js
View file

@ -96,10 +96,21 @@ add_task(async () => {
Services.cookies.setCookieStringFromHttp(uri2, "oh=hai; max-age=1000", chan2); Services.cookies.setCookieStringFromHttp(uri2, "oh=hai; max-age=1000", chan2);
Assert.equal(await getCookieStringFromPrivateDocument(uri2.spec), "oh=hai"); Assert.equal(await getCookieStringFromPrivateDocument(uri2.spec), "oh=hai");
// on android fission the privateBrowsingHolder prevents
// the cookies on the content process from being updated
// Let's release the last PB window.
await privateBrowsingHolder.close();
// Fake a profile change. // Fake a profile change.
await promise_close_profile(); await promise_close_profile();
do_load_profile(); do_load_profile();
// keep the private browsing window open again
const privateBrowsingHolder2 = await CookieXPCShellUtils.loadContentPage(
"http://bar.com/",
{ privateBrowsing: true }
);
// We're still in private browsing mode, but should have a new session. // We're still in private browsing mode, but should have a new session.
// Check counts. // Check counts.
Assert.equal(await getCookieStringFromPrivateDocument(uri1.spec), ""); Assert.equal(await getCookieStringFromPrivateDocument(uri1.spec), "");
@ -127,6 +138,6 @@ add_task(async () => {
Assert.equal(Services.cookies.countCookiesFromHost(uri2.host), 0); Assert.equal(Services.cookies.countCookiesFromHost(uri2.host), 0);
// Let's release the last PB window. // Let's release the last PB window.
privateBrowsingHolder.close(); await privateBrowsingHolder2.close();
Services.prefs.clearUserPref("dom.security.https_first"); Services.prefs.clearUserPref("dom.security.https_first");
}); });

1
netwerk/test/unit/xpcshell.toml
View file

@ -484,7 +484,6 @@ skip-if = ["os == 'linux' && bits == 64 && !debug"] #Bug 1553353
["test_cookies_partition_counting.js"] ["test_cookies_partition_counting.js"]
["test_cookies_privatebrowsing.js"] ["test_cookies_privatebrowsing.js"]
skip-if = ["os == 'android' && fission"] # Bug 1888227
["test_cookies_profile_close.js"] ["test_cookies_profile_close.js"]
skip-if = ["os == 'android'"] # Bug 1700483 skip-if = ["os == 'android'"] # Bug 1700483