Bug 1816725 - Remove indicator attribute on the downloads button. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D169839
This commit is contained in:
William Durand 2023-02-15 09:33:11 +00:00
parent 0f9ca3ebda
commit 31f8b85393
3 changed files with 7 additions and 13 deletions

View file

@ -1071,15 +1071,15 @@ browser[tabmodalPromptShowing], browser[tabDialogShowing] {
/*** Visibility of downloads indicator controls ***/ /*** Visibility of downloads indicator controls ***/
/* Hide the default icon, show the anchor instead. */ /* Hide the default icon, show the anchor instead. */
#downloads-button[indicator] > .toolbarbutton-badge-stack > image.toolbarbutton-icon { #downloads-button > .toolbarbutton-badge-stack > image.toolbarbutton-icon {
display: none; display: none;
} }
toolbarpaletteitem[place="palette"] > #downloads-button[indicator] > .toolbarbutton-badge-stack > image.toolbarbutton-icon { toolbarpaletteitem[place="palette"] > #downloads-button > .toolbarbutton-badge-stack > image.toolbarbutton-icon {
display: -moz-box; display: -moz-box;
} }
toolbarpaletteitem[place="palette"] > #downloads-button[indicator] > .toolbarbutton-badge-stack > #downloads-indicator-anchor { toolbarpaletteitem[place="palette"] > #downloads-button > .toolbarbutton-badge-stack > #downloads-indicator-anchor {
display: none; display: none;
} }

View file

@ -412,8 +412,7 @@
overflows="false" overflows="false"
cui-areatype="toolbar" cui-areatype="toolbar"
hidden="true" hidden="true"
tooltip="dynamic-shortcut-tooltip" tooltip="dynamic-shortcut-tooltip">
indicator="true">
<box id="downloads-indicator-anchor" <box id="downloads-indicator-anchor"
consumeanchor="downloads-button"> consumeanchor="downloads-button">
<image id="downloads-indicator-icon"/> <image id="downloads-indicator-icon"/>

View file

@ -620,16 +620,11 @@ const DownloadsIndicatorView = {
* is not present in the browser window yet. * is not present in the browser window yet.
*/ */
get indicator() { get indicator() {
if (this._indicator) { if (!this._indicator) {
return this._indicator; this._indicator = document.getElementById("downloads-button");
} }
let indicator = document.getElementById("downloads-button"); return this._indicator;
if (!indicator || indicator.getAttribute("indicator") != "true") {
return null;
}
return (this._indicator = indicator);
}, },
get indicatorAnchor() { get indicatorAnchor() {