nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1895551 - Remove aria attribute from ElementInternals when set to null. r=Jamie,dom-core,edgar

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D209721
This commit is contained in:
Eitan Isaacson 2024-05-24 22:37:12 +00:00
parent d795febb58
commit 3357f914c8
2 changed files with 17 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
accessible/tests/mochitest/test_custom_element_accessibility_defaults.html
View file

@ -213,6 +213,13 @@ async function runTest() {
await attributeChanged; await attributeChanged;
testAttrs("default-sort", {"sort": "descending"}, true); testAttrs("default-sort", {"sort": "descending"}, true);
info("Changing ElementInternals ariaValueText");
let valueTextChanged = waitForEvent(EVENT_TEXT_VALUE_CHANGE, "default-value");
let valueElement = document.getElementById("default-value");
valueElement.internals.ariaValueText = null;
await valueTextChanged;
testValue("default-value", "5", 5, 1, 10, 0);
SimpleTest.finish(); SimpleTest.finish();
} }

12
dom/html/ElementInternals.cpp
View file

@ -451,9 +451,17 @@ nsresult ElementInternals::SetAttr(nsAtom* aName, const nsAString& aValue) {
MutationObservers::NotifyARIAAttributeDefaultWillChange(mTarget, aName, MutationObservers::NotifyARIAAttributeDefaultWillChange(mTarget, aName,
modType); modType);
bool attrHadValue;
nsAttrValue attrValue(aValue); nsAttrValue attrValue(aValue);
nsresult rs = mAttrs.SetAndSwapAttr(aName, attrValue, &attrHadValue); nsresult rs = NS_OK;
if (DOMStringIsNull(aValue)) {
auto attrPos = mAttrs.IndexOfAttr(aName);
if (attrPos >= 0) {
rs = mAttrs.RemoveAttrAt(attrPos, attrValue);
}
} else {
bool attrHadValue = false;
rs = mAttrs.SetAndSwapAttr(aName, attrValue, &attrHadValue);
}
nsMutationGuard::DidMutate(); nsMutationGuard::DidMutate();
MutationObservers::NotifyARIAAttributeDefaultChanged(mTarget, aName, modType); MutationObservers::NotifyARIAAttributeDefaultChanged(mTarget, aName, modType);