nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1561435 - Fix test failures for toolkit/, r=standard8

Browse source 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36202

--HG--
extra : source : eb2b3c812f85f8fee94192e3d36bb80eda6c5036
extra : intermediate-source : 70f0351b50cc06a446123e29de496ed4d25e4cd0
This commit is contained in:
Victor Porof 2019-06-27 15:53:42 +02:00
parent 815b9d372b
commit 336c4fb8a4
3 changed files with 8 additions and 8 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
toolkit/components/extensions/test/xpcshell/test_proxy_scripts.js
View file

@ -78,7 +78,7 @@ async function testProxyScript(script, expected = {}) {
ok(error.fileName.includes("proxy.js"), "Error should include file name");
equal(error.lineNumber, 3, "Error should include line number");
ok(
error.stack.includes("proxy.js:3:7"),
error.stack.includes("proxy.js:3:9"),
"Error should include stack trace"
);
}

2
toolkit/modules/tests/xpcshell/test_Log.js
View file

@ -274,7 +274,7 @@ add_task(async function log_message_with_params() {
};
Assert.equal(
formatMessage("Broken valueOf ${}", vOf),
'Broken valueOf ({a:1, valueOf:(function() {throw new Error("oh noes valueOf");})})'
'Broken valueOf ({a:1, valueOf:(function() {\n throw new Error("oh noes valueOf");\n })})'
);
/* eslint-enable object-shorthand */

12
toolkit/modules/tests/xpcshell/test_Log_stackTrace.js
View file

@ -1,13 +1,13 @@
print("Define some functions in well defined line positions for the test");
function foo(v) {
return bar(v + 1);
} // line 2
} // line 3
function bar(v) {
return baz(v + 1);
} // line 3
} // line 6
function baz(v) {
throw new Error(v + 1);
} // line 4
} // line 9
print("Make sure lazy constructor calling/assignment works");
const { Log } = ChromeUtils.import("resource://gre/modules/Log.jsm");
@ -25,9 +25,9 @@ function run_test() {
print(`Got trace: ${trace}`);
Assert.notEqual(trace, "");
let bazPos = trace.indexOf("baz@test_Log_stackTrace.js:4");
let barPos = trace.indexOf("bar@test_Log_stackTrace.js:3");
let fooPos = trace.indexOf("foo@test_Log_stackTrace.js:2");
let bazPos = trace.indexOf("baz@test_Log_stackTrace.js:9");
let barPos = trace.indexOf("bar@test_Log_stackTrace.js:6");
let fooPos = trace.indexOf("foo@test_Log_stackTrace.js:3");
print(`String positions: ${bazPos} ${barPos} ${fooPos}`);
print("Make sure the desired messages show up");