nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1870280 - Open NamedTemporaryFile with delete=False on mozrunner r=firefox-build-system-reviewers,ahochheiden

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D196578
This commit is contained in:
Kagami Sascha Rosylight 2023-12-15 21:14:58 +00:00
parent 158a2bcb39
commit 351d96caf7
1 changed files with 8 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
testing/mozbase/mozrunner/mozrunner/devices/base.py
View file

@ -114,11 +114,14 @@ class Device(object):
config.set(section, "IsRelative", 0)
config.set(section, "Path", self.app_ctx.remote_profile)
new_profiles_ini = tempfile.NamedTemporaryFile()
config.write(open(new_profiles_ini.name, "w"))
self.backup_file(self.app_ctx.remote_profiles_ini)
self.device.push(new_profiles_ini.name, self.app_ctx.remote_profiles_ini)
# delete=False to allow opening the same file from ADB on Windows.
# The file will still be deleted at the end of the `with` block.
# See the "Opening the temporary file again" paragraph in:
# https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile
with tempfile.NamedTemporaryFile(delete=False) as new_profiles_ini:
config.write(new_profiles_ini)
self.backup_file(self.app_ctx.remote_profiles_ini)
self.device.push(new_profiles_ini.name, self.app_ctx.remote_profiles_ini)
# Ideally all applications would read the profile the same way, but in practice
# this isn't true. Perform application specific profile-related setup if necessary.