From 3d366d4c4a49611023439c96229a42c513b791b1 Mon Sep 17 00:00:00 2001
From: "Mellina Y." <yonashiro.mellina@gmail.com>
Date: Wed, 16 Oct 2019 13:50:08 +0000
Subject: [PATCH] Bug 1582658 - Enable ESLint for all of
 devtools/client/storage/test/. r=miker

Differential Revision: https://phabricator.services.mozilla.com/D47679

--HG--
extra : moz-landing-system : lando
---
 .eslintignore                                 |  6 ---
 .../storage/test/storage-cache-error.html     |  2 +-
 .../storage/test/storage-complex-values.html  | 32 ++++++++--------
 .../test/storage-cookies-samesite.html        |  2 +-
 .../test/storage-empty-objectstores.html      | 28 +++++++-------
 .../client/storage/test/storage-file-url.html | 16 ++++----
 .../test/storage-idb-delete-blocked.html      | 13 ++-----
 .../storage-indexeddb-duplicate-names.html    |  5 ++-
 .../test/storage-listings-usercontextid.html  | 38 +++++++++----------
 .../test/storage-listings-with-fragment.html  | 38 +++++++++----------
 .../client/storage/test/storage-listings.html | 38 +++++++++----------
 .../storage/test/storage-localstorage.html    |  2 +-
 .../storage-secured-iframe-usercontextid.html | 24 ++++++------
 .../storage/test/storage-secured-iframe.html  | 26 ++++++-------
 .../storage/test/storage-sessionstorage.html  |  2 +-
 .../test/storage-sidebar-parsetree.html       |  2 +-
 .../client/storage/test/storage-updates.html  |  4 +-
 17 files changed, 134 insertions(+), 144 deletions(-)
diff --git a/.eslintignore b/.eslintignore
index 33f466ff0a1c..c42d5279fc18 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -63,12 +63,6 @@ devtools/client/performance/components/test/test_jit_optimizations_01.html
 devtools/client/shared/test/*.html
 devtools/client/shared/components/test/mochitest/*.html
 !devtools/client/shared/components/test/mochitest/test_stack-trace.html
-devtools/client/storage/test/*.html
-!devtools/client/storage/test/storage-cookies.html
-!devtools/client/storage/test/storage-overflow.html
-!devtools/client/storage/test/storage-search.html
-!devtools/client/storage/test/storage-unsecured-iframe.html
-!devtools/client/storage/test/storage-unsecured-iframe-usercontextid.html
 devtools/server/tests/browser/storage-*.html
 !devtools/server/tests/browser/storage-unsecured-iframe.html
 devtools/server/tests/browser/stylesheets-nested-iframes.html
diff --git a/devtools/client/storage/test/storage-cache-error.html b/devtools/client/storage/test/storage-cache-error.html
index cf6bb3eed168..1ae9dfc6de57 100644
--- a/devtools/client/storage/test/storage-cache-error.html
+++ b/devtools/client/storage/test/storage-cache-error.html
@@ -10,7 +10,7 @@
 
 // Create an iframe with a javascript: source URL. Such iframes are
 // considered untrusted by the CacheStorage.
-let frameEl = document.createElement("iframe");
+const frameEl = document.createElement("iframe");
 document.body.appendChild(frameEl);
 
 window.frameContent = 'Hello World';
diff --git a/devtools/client/storage/test/storage-complex-values.html b/devtools/client/storage/test/storage-complex-values.html
index 82faab8e09bb..69ade2424d8d 100644
--- a/devtools/client/storage/test/storage-complex-values.html
+++ b/devtools/client/storage/test/storage-complex-values.html
@@ -10,8 +10,8 @@ Bug 970517 - Storage inspector front end - tests
 <body>
 <script type="application/javascript">
 "use strict";
-let partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
-let cookieExpiresTime = 2000000000000;
+const partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
+const cookieExpiresTime = 2000000000000;
 // Setting up some cookies to eat.
 document.cookie = "c1=" + JSON.stringify([
   "foo", "Bar", {
@@ -38,24 +38,24 @@ sessionStorage.setItem("ss3", "this#is~an#object~foo#bar");
 sessionStorage.setItem("ss4", "#array##with#empty#items");
 // long string that is almost an object and might trigger exponential
 // regexp backtracking
-let s = "a".repeat(1000);
+const s = "a".repeat(1000);
 sessionStorage.setItem("ss5", `${s}=${s}=${s}=${s}&${s}=${s}&${s}`);
 console.log("added cookies and stuff from main page");
 
-let idbGenerator = async function () {
+const idbGenerator = async function () {
   let request = indexedDB.open("idb1", 1);
   request.onerror = function() {
     throw new Error("error opening db connection");
   };
-  let db = await new Promise(done => {
+  const db = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db = event.target.result;
-      let store1 = db.createObjectStore("obj1", { keyPath: "id" });
+      const _db = event.target.result;
+      const store1 = _db.createObjectStore("obj1", { keyPath: "id" });
       store1.createIndex("name", "name", { unique: false });
       store1.createIndex("email", "email", { unique: true });
-      db.createObjectStore("obj2", { keyPath: "id2" });
+      _db.createObjectStore("obj2", { keyPath: "id2" });
       store1.transaction.oncomplete = () => {
-        done(db);
+        done(_db);
       };
     };
   });
@@ -65,9 +65,9 @@ let idbGenerator = async function () {
     request.onsuccess = done;
   });
 
-  let transaction = db.transaction(["obj1", "obj2"], "readwrite");
-  let store1 = transaction.objectStore("obj1");
-  let store2 = transaction.objectStore("obj2");
+  const transaction = db.transaction(["obj1", "obj2"], "readwrite");
+  const store1 = transaction.objectStore("obj1");
+  const store2 = transaction.objectStore("obj2");
 
   store1.add({id: 1, name: "foo", email: "foo@bar.com"});
   store1.add({id: 2, name: "foo2", email: "foo2@bar.com"});
@@ -81,13 +81,13 @@ let idbGenerator = async function () {
   db.close();
 
   request = indexedDB.open("idb2", 1);
-  let db2 = await new Promise(done => {
+  const db2 = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db2 = event.target.result;
-      let store3 = db2.createObjectStore("obj3", { keyPath: "id3" });
+      const _db2 = event.target.result;
+      const store3 = _db2.createObjectStore("obj3", { keyPath: "id3" });
       store3.createIndex("name2", "name2", { unique: true });
       store3.transaction.oncomplete = () => {
-        done(db2);
+        done(_db2);
       };
     };
   });
diff --git a/devtools/client/storage/test/storage-cookies-samesite.html b/devtools/client/storage/test/storage-cookies-samesite.html
index c14e2c67a839..90eb75d95e0f 100644
--- a/devtools/client/storage/test/storage-cookies-samesite.html
+++ b/devtools/client/storage/test/storage-cookies-samesite.html
@@ -7,7 +7,7 @@
   <body>
     <script type="application/javascript">
     "use strict";
-    let expiresIn24Hours = new Date(Date.now() + 60 * 60 * 24 * 1000).toUTCString();
+    const expiresIn24Hours = new Date(Date.now() + 60 * 60 * 24 * 1000).toUTCString();
 
     document.cookie = "test1=value1;expires=" + expiresIn24Hours + ";";
     document.cookie = "test2=value2;expires=" + expiresIn24Hours + ";SameSite=lax";
diff --git a/devtools/client/storage/test/storage-empty-objectstores.html b/devtools/client/storage/test/storage-empty-objectstores.html
index 7e84cea4728f..4479fc097269 100644
--- a/devtools/client/storage/test/storage-empty-objectstores.html
+++ b/devtools/client/storage/test/storage-empty-objectstores.html
@@ -6,50 +6,50 @@
 </head>
 <body>
 <script type="application/javascript">
-
+"use strict";
 window.setup = async function () {
   let request = indexedDB.open("idb1", 1);
-  let db = await new Promise((resolve, reject) => {
+  const db = await new Promise((resolve, reject) => {
     request.onerror = e => reject(Error("error opening db connection"));
     request.onupgradeneeded = event => {
-      let db = event.target.result;
-      let store1 = db.createObjectStore("obj1", { keyPath: "id" });
+      const _db = event.target.result;
+      const store1 = _db.createObjectStore("obj1", { keyPath: "id" });
       store1.createIndex("name", "name", { unique: false });
       store1.createIndex("email", "email", { unique: true });
-      let store2 = db.createObjectStore("obj2", { keyPath: "id2" });
-      store1.transaction.oncomplete = () => resolve(db);
+      _db.createObjectStore("obj2", { keyPath: "id2" });
+      store1.transaction.oncomplete = () => resolve(_db);
     };
   });
 
-  await new Promise(resolve => request.onsuccess = resolve);
+  await new Promise(resolve => (request.onsuccess = resolve));
 
-  let transaction = db.transaction(["obj1", "obj2"], "readwrite");
-  let store1 = transaction.objectStore("obj1");
-  let store2 = transaction.objectStore("obj2");
+  const transaction = db.transaction(["obj1", "obj2"], "readwrite");
+  const store1 = transaction.objectStore("obj1");
+  const store2 = transaction.objectStore("obj2");
 
   store1.add({id: 1, name: "foo", email: "foo@bar.com"});
   store1.add({id: 2, name: "foo2", email: "foo2@bar.com"});
   store1.add({id: 3, name: "foo2", email: "foo3@bar.com"});
   store2.add({id2: 1, name: "foo", email: "foo@bar.com", extra: "baz"});
 
-  await new Promise(resolve => transaction.oncomplete = resolve);
+  await new Promise(resolve => (transaction.oncomplete = resolve));
 
   db.close();
 
   request = indexedDB.open("idb2", 1);
-  let db2 = await new Promise((resolve, reject) => {
+  const db2 = await new Promise((resolve, reject) => {
     request.onerror = e => reject(Error("error opening db2 connection"));
     request.onupgradeneeded = event => resolve(event.target.result);
   });
 
-  await new Promise(resolve => request.onsuccess = resolve);
+  await new Promise(resolve => (request.onsuccess = resolve));
 
   db2.close();
   dump("added indexedDB items from main page\n");
 };
 
 window.clear = async function () {
-  for (let dbName of ["idb1", "idb2"]) {
+  for (const dbName of ["idb1", "idb2"]) {
     await new Promise(resolve => {
       indexedDB.deleteDatabase(dbName).onsuccess = resolve;
     });
diff --git a/devtools/client/storage/test/storage-file-url.html b/devtools/client/storage/test/storage-file-url.html
index 85e697cbe369..d7bb105e889d 100644
--- a/devtools/client/storage/test/storage-file-url.html
+++ b/devtools/client/storage/test/storage-file-url.html
@@ -4,6 +4,8 @@
   <meta charset="utf-8" />
   <title>Storage Test</title>
   <script>
+    "use strict";
+    /* exported init */
     function init() {
       createIndexedDB();
       createCookies();
@@ -12,19 +14,17 @@
     }
 
     function createIndexedDB() {
-      var open = indexedDB.open("MyDatabase", 1);
+      const open = indexedDB.open("MyDatabase", 1);
 
       open.onupgradeneeded = function () {
-        var db = open.result;
-        var store = db.createObjectStore("MyObjectStore", {keyPath: "id"});
-        var index = store.createIndex("NameIndex", ["name.last", "name.first"]);
+        const db = open.result;
+        db.createObjectStore("MyObjectStore", {keyPath: "id"});
       };
 
       open.onsuccess = function () {
-        var db = open.result;
-        var tx = db.transaction("MyObjectStore", "readwrite");
-        var store = tx.objectStore("MyObjectStore");
-        var index = store.index("NameIndex");
+        const db = open.result;
+        const tx = db.transaction("MyObjectStore", "readwrite");
+        const store = tx.objectStore("MyObjectStore");
 
         store.put({id: 12345, name: {first: "John", last: "Doe"}, age: 42});
         store.put({id: 54321, name: {first: "Ralph", last: "Wood"}, age: 38});
diff --git a/devtools/client/storage/test/storage-idb-delete-blocked.html b/devtools/client/storage/test/storage-idb-delete-blocked.html
index d688ac2c736f..7c7b5974219f 100644
--- a/devtools/client/storage/test/storage-idb-delete-blocked.html
+++ b/devtools/client/storage/test/storage-idb-delete-blocked.html
@@ -6,20 +6,15 @@
 </head>
 <body>
 <script type="application/javascript">
-
+"use strict";
 let db;
 
 window.setup = async function () {
   db = await new Promise((resolve, reject) => {
-    let request = indexedDB.open("idb", 1);
+    const request = indexedDB.open("idb", 1);
 
     request.onsuccess = e => resolve(e.target.result);
     request.onerror = e => reject(new Error("error opening db connection"));
-
-    request.onupgradeneeded = e => {
-      let db = e.target.result;
-      let store = db.createObjectStore("obj", { keyPath: "id" });
-    };
   });
 
   dump("opened indexedDB\n");
@@ -31,7 +26,7 @@ window.closeDb = function() {
 
 window.deleteDb = async function () {
   await new Promise((resolve, reject) => {
-    let request = indexedDB.deleteDatabase("idb");
+    const request = indexedDB.deleteDatabase("idb");
 
     request.onsuccess = resolve;
     request.onerror = e => reject(new Error("error deleting db"));
@@ -39,7 +34,7 @@ window.deleteDb = async function () {
 };
 
 window.clear = async function () {
-  for (let dbName of ["idb1", "idb2"]) {
+  for (const dbName of ["idb1", "idb2"]) {
     await new Promise(resolve => {
       indexedDB.deleteDatabase(dbName).onsuccess = resolve;
     });
diff --git a/devtools/client/storage/test/storage-indexeddb-duplicate-names.html b/devtools/client/storage/test/storage-indexeddb-duplicate-names.html
index 52c9db4b48e5..f549d4cbc5d8 100644
--- a/devtools/client/storage/test/storage-indexeddb-duplicate-names.html
+++ b/devtools/client/storage/test/storage-indexeddb-duplicate-names.html
@@ -7,6 +7,7 @@
   <script type="application/javascript">
     "use strict";
 
+    /* exported createIndexedDBs */
     function createIndexedDBs() {
       createIndexedDB("idb1", "temporary");
       createIndexedDB("idb1", "default");
@@ -17,10 +18,10 @@
     }
 
     function createIndexedDB(name, storage) {
-      let open = indexedDB.open(name, {storage: storage});
+      const open = indexedDB.open(name, {storage: storage});
 
       open.onsuccess = function () {
-        let db = open.result;
+        const db = open.result;
         db.close();
       };
     }
diff --git a/devtools/client/storage/test/storage-listings-usercontextid.html b/devtools/client/storage/test/storage-listings-usercontextid.html
index b1e30c48a956..d6eb6baf3cff 100644
--- a/devtools/client/storage/test/storage-listings-usercontextid.html
+++ b/devtools/client/storage/test/storage-listings-usercontextid.html
@@ -12,9 +12,9 @@ Storage inspector front end for userContextId - tests
 <iframe src="https://sectest1.example.org:443/browser/devtools/client/storage/test/storage-secured-iframe-usercontextid.html"></iframe>
 <script type="application/javascript">
 "use strict";
-let partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
-let cookieExpiresTime1 = 2000000000000;
-let cookieExpiresTime2 = 2000000001000;
+const partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
+const cookieExpiresTime1 = 2000000000000;
+const cookieExpiresTime2 = 2000000001000;
 // Setting up some cookies to eat.
 document.cookie = "c1uc1=foobar; expires=" +
   new Date(cookieExpiresTime1).toGMTString() + "; path=/browser";
@@ -28,20 +28,20 @@ localStorage.setItem("ls2uc1", "foobar-2");
 sessionStorage.setItem("ss1uc1", "foobar-3");
 dump("added cookies and storage from main page\n");
 
-let idbGenerator = async function () {
+const idbGenerator = async function () {
   let request = indexedDB.open("idb1uc1", 1);
   request.onerror = function() {
     throw new Error("error opening db connection");
   };
-  let db = await new Promise(done => {
+  const db = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db = event.target.result;
-      let store1 = db.createObjectStore("obj1uc1", { keyPath: "id" });
+      const _db = event.target.result;
+      const store1 = _db.createObjectStore("obj1uc1", { keyPath: "id" });
       store1.createIndex("name", "name", { unique: false });
       store1.createIndex("email", "email", { unique: true });
-      let store2 = db.createObjectStore("obj2uc1", { keyPath: "id2" });
+      _db.createObjectStore("obj2uc1", { keyPath: "id2" });
       store1.transaction.oncomplete = () => {
-        done(db);
+        done(_db);
       };
     };
   });
@@ -51,9 +51,9 @@ let idbGenerator = async function () {
     request.onsuccess = done;
   });
 
-  let transaction = db.transaction(["obj1uc1", "obj2uc1"], "readwrite");
-  let store1 = transaction.objectStore("obj1uc1");
-  let store2 = transaction.objectStore("obj2uc1");
+  const transaction = db.transaction(["obj1uc1", "obj2uc1"], "readwrite");
+  const store1 = transaction.objectStore("obj1uc1");
+  const store2 = transaction.objectStore("obj2uc1");
   store1.add({id: 1, name: "foo", email: "foo@bar.com"});
   store1.add({id: 2, name: "foo2", email: "foo2@bar.com"});
   store1.add({id: 3, name: "foo2", email: "foo3@bar.com"});
@@ -71,13 +71,13 @@ let idbGenerator = async function () {
   db.close();
 
   request = indexedDB.open("idb2uc1", 1);
-  let db2 = await new Promise(done => {
+  const db2 = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db2 = event.target.result;
-      let store3 = db2.createObjectStore("obj3uc1", { keyPath: "id3" });
+      const _db2 = event.target.result;
+      const store3 = _db2.createObjectStore("obj3uc1", { keyPath: "id3" });
       store3.createIndex("name2", "name2", { unique: true });
       store3.transaction.oncomplete = () => {
-        done(db2);
+        done(_db2);
       }
     };
   });
@@ -98,12 +98,12 @@ function deleteDB(dbName) {
 }
 
 async function fetchPut(cache, url) {
-  let response = await fetch(url);
+  const response = await fetch(url);
   await cache.put(url, response);
 }
 
-let cacheGenerator = async function () {
-  let cache = await caches.open("plopuc1");
+const cacheGenerator = async function () {
+  const cache = await caches.open("plopuc1");
   await fetchPut(cache, "404_cached_file.js");
   await fetchPut(cache, "browser_storage_basic.js");
 };
diff --git a/devtools/client/storage/test/storage-listings-with-fragment.html b/devtools/client/storage/test/storage-listings-with-fragment.html
index 5c0206a963ef..2698f6ebacb2 100644
--- a/devtools/client/storage/test/storage-listings-with-fragment.html
+++ b/devtools/client/storage/test/storage-listings-with-fragment.html
@@ -15,9 +15,9 @@ include fragments e.g. http://example.com/test.js#abcdefg
 <iframe src="https://sectest1.example.org:443/browser/devtools/client/storage/test/storage-secured-iframe.html#ghi"></iframe>
 <script type="application/javascript">
 "use strict";
-let partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
-let cookieExpiresTime1 = 2000000000000;
-let cookieExpiresTime2 = 2000000001000;
+const partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
+const cookieExpiresTime1 = 2000000000000;
+const cookieExpiresTime2 = 2000000001000;
 // Setting up some cookies to eat.
 document.cookie = "c1=foobar; expires=" +
   new Date(cookieExpiresTime1).toGMTString() + "; path=/browser";
@@ -31,20 +31,20 @@ localStorage.setItem("ls2", "foobar-2");
 sessionStorage.setItem("ss1", "foobar-3");
 dump("added cookies and storage from main page\n");
 
-let idbGenerator = async function () {
+const idbGenerator = async function () {
   let request = indexedDB.open("idb1", 1);
   request.onerror = function() {
     throw new Error("error opening db connection");
   };
-  let db = await new Promise(done => {
+  const db = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db = event.target.result;
-      let store1 = db.createObjectStore("obj1", { keyPath: "id" });
+      const _db = event.target.result;
+      const store1 = _db.createObjectStore("obj1", { keyPath: "id" });
       store1.createIndex("name", "name", { unique: false });
       store1.createIndex("email", "email", { unique: true });
-      let store2 = db.createObjectStore("obj2", { keyPath: "id2" });
+      _db.createObjectStore("obj2", { keyPath: "id2" }); // eslint-disable-line no-unused-vars
       store1.transaction.oncomplete = () => {
-        done(db);
+        done(_db);
       };
     };
   });
@@ -54,9 +54,9 @@ let idbGenerator = async function () {
     request.onsuccess = done;
   });
 
-  let transaction = db.transaction(["obj1", "obj2"], "readwrite");
-  let store1 = transaction.objectStore("obj1");
-  let store2 = transaction.objectStore("obj2");
+  const transaction = db.transaction(["obj1", "obj2"], "readwrite");
+  const store1 = transaction.objectStore("obj1");
+  const store2 = transaction.objectStore("obj2");
   store1.add({id: 1, name: "foo", email: "foo@bar.com"});
   store1.add({id: 2, name: "foo2", email: "foo2@bar.com"});
   store1.add({id: 3, name: "foo2", email: "foo3@bar.com"});
@@ -74,13 +74,13 @@ let idbGenerator = async function () {
   db.close();
 
   request = indexedDB.open("idb2", 1);
-  let db2 = await new Promise(done => {
+  const db2 = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db2 = event.target.result;
-      let store3 = db2.createObjectStore("obj3", { keyPath: "id3" });
+      const _db2 = event.target.result;
+      const store3 = _db2.createObjectStore("obj3", { keyPath: "id3" });
       store3.createIndex("name2", "name2", { unique: true });
       store3.transaction.oncomplete = () => {
-        done(db2);
+        done(_db2);
       }
     };
   });
@@ -101,12 +101,12 @@ function deleteDB(dbName) {
 }
 
 async function fetchPut(cache, url) {
-  let response = await fetch(url);
+  const response = await fetch(url);
   await cache.put(url, response);
 }
 
-let cacheGenerator = async function () {
-  let cache = await caches.open("plop");
+const cacheGenerator = async function () {
+  const cache = await caches.open("plop");
   await fetchPut(cache, "404_cached_file.js");
   await fetchPut(cache, "browser_storage_basic.js");
 };
diff --git a/devtools/client/storage/test/storage-listings.html b/devtools/client/storage/test/storage-listings.html
index 239fbc02ff24..d612ea8ad96b 100644
--- a/devtools/client/storage/test/storage-listings.html
+++ b/devtools/client/storage/test/storage-listings.html
@@ -12,9 +12,9 @@ Storage inspector front end - tests
 <iframe src="https://sectest1.example.org:443/browser/devtools/client/storage/test/storage-secured-iframe.html"></iframe>
 <script type="application/javascript">
 "use strict";
-let partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
-let cookieExpiresTime1 = 2000000000000;
-let cookieExpiresTime2 = 2000000001000;
+const partialHostname = location.hostname.match(/^[^.]+(\..*)$/)[1];
+const cookieExpiresTime1 = 2000000000000;
+const cookieExpiresTime2 = 2000000001000;
 // Setting up some cookies to eat.
 document.cookie = "c1=foobar; expires=" +
   new Date(cookieExpiresTime1).toGMTString() + "; path=/browser";
@@ -43,20 +43,20 @@ sessionStorage.setItem("key", "value2");
 
 dump("added cookies and storage from main page\n");
 
-let idbGenerator = async function () {
+const idbGenerator = async function () {
   let request = indexedDB.open("idb1", 1);
   request.onerror = function() {
     throw new Error("error opening db connection");
   };
-  let db = await new Promise(done => {
+  const db = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db = event.target.result;
-      let store1 = db.createObjectStore("obj1", { keyPath: "id" });
+      const _db = event.target.result;
+      const store1 = _db.createObjectStore("obj1", { keyPath: "id" });
       store1.createIndex("name", "name", { unique: false });
       store1.createIndex("email", "email", { unique: true });
-      let store2 = db.createObjectStore("obj2", { keyPath: "id2" });
+      _db.createObjectStore("obj2", { keyPath: "id2" }); // eslint-disable-line no-unused-vars
       store1.transaction.oncomplete = () => {
-        done(db);
+        done(_db);
       };
     };
   });
@@ -66,9 +66,9 @@ let idbGenerator = async function () {
     request.onsuccess = done;
   });
 
-  let transaction = db.transaction(["obj1", "obj2"], "readwrite");
-  let store1 = transaction.objectStore("obj1");
-  let store2 = transaction.objectStore("obj2");
+  const transaction = db.transaction(["obj1", "obj2"], "readwrite");
+  const store1 = transaction.objectStore("obj1");
+  const store2 = transaction.objectStore("obj2");
   store1.add({id: 1, name: "foo", email: "foo@bar.com"});
   store1.add({id: 2, name: "foo2", email: "foo2@bar.com"});
   store1.add({id: 3, name: "foo2", email: "foo3@bar.com"});
@@ -86,13 +86,13 @@ let idbGenerator = async function () {
   db.close();
 
   request = indexedDB.open("idb2", 1);
-  let db2 = await new Promise(done => {
+  const db2 = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db2 = event.target.result;
-      let store3 = db2.createObjectStore("obj3", { keyPath: "id3" });
+      const _db2 = event.target.result;
+      const store3 = _db2.createObjectStore("obj3", { keyPath: "id3" });
       store3.createIndex("name2", "name2", { unique: true });
       store3.transaction.oncomplete = () => {
-        done(db2);
+        done(_db2);
       }
     };
   });
@@ -113,12 +113,12 @@ function deleteDB(dbName) {
 }
 
 async function fetchPut(cache, url) {
-  let response = await fetch(url);
+  const response = await fetch(url);
   await cache.put(url, response);
 }
 
-let cacheGenerator = async function () {
-  let cache = await caches.open("plop");
+const cacheGenerator = async function () {
+  const cache = await caches.open("plop");
   await fetchPut(cache, "404_cached_file.js");
   await fetchPut(cache, "browser_storage_basic.js");
 };
diff --git a/devtools/client/storage/test/storage-localstorage.html b/devtools/client/storage/test/storage-localstorage.html
index d2ce4417b52f..cacdc0d56945 100644
--- a/devtools/client/storage/test/storage-localstorage.html
+++ b/devtools/client/storage/test/storage-localstorage.html
@@ -8,7 +8,7 @@
     <title>Storage inspector localStorage test</title>
     <script type="application/javascript">
       "use strict";
-
+      /* exported setup */
       function setup() {
         localStorage.setItem("TestLS1", "ValueLS1");
         localStorage.setItem("TestLS2", "ValueLS2");
diff --git a/devtools/client/storage/test/storage-secured-iframe-usercontextid.html b/devtools/client/storage/test/storage-secured-iframe-usercontextid.html
index f30b97402b2a..c3958661d417 100644
--- a/devtools/client/storage/test/storage-secured-iframe-usercontextid.html
+++ b/devtools/client/storage/test/storage-secured-iframe-usercontextid.html
@@ -14,17 +14,17 @@ localStorage.setItem("iframe-s-ls1uc1", "foobar");
 sessionStorage.setItem("iframe-s-ss1uc1", "foobar-2");
 dump("added cookies and storage from secured iframe\n");
 
-let idbGenerator = async function () {
+const idbGenerator = async function () {
   let request = indexedDB.open("idb-s1uc1", 1);
   request.onerror = function() {
     throw new Error("error opening db connection");
   };
-  let db = await new Promise(done => {
+  const db = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db = event.target.result;
-      let store1 = db.createObjectStore("obj-s1uc1", { keyPath: "id" });
+      const _db = event.target.result;
+      const store1 = _db.createObjectStore("obj-s1uc1", { keyPath: "id" });
       store1.transaction.oncomplete = () => {
-        done(db);
+        done(_db);
       };
     };
   });
@@ -33,7 +33,7 @@ let idbGenerator = async function () {
   });
 
   let transaction = db.transaction(["obj-s1uc1"], "readwrite");
-  let store1 = transaction.objectStore("obj-s1uc1");
+  const store1 = transaction.objectStore("obj-s1uc1");
   store1.add({id: 6, name: "foo", email: "foo@bar.com"});
   store1.add({id: 7, name: "foo2", email: "foo2@bar.com"});
   await new Promise(success => {
@@ -43,14 +43,14 @@ let idbGenerator = async function () {
   db.close();
 
   request = indexedDB.open("idb-s2uc1", 1);
-  let db2 = await new Promise(done => {
+  const db2 = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db2 = event.target.result;
-      let store3 =
-        db2.createObjectStore("obj-s2uc1", { keyPath: "id3", autoIncrement: true });
+      const _db2 = event.target.result;
+      const store3 =
+        _db2.createObjectStore("obj-s2uc1", { keyPath: "id3", autoIncrement: true });
       store3.createIndex("name2", "name2", { unique: true });
       store3.transaction.oncomplete = () => {
-        done(db2);
+        done(_db2);
       };
     };
   });
@@ -59,7 +59,7 @@ let idbGenerator = async function () {
   });
 
   transaction = db2.transaction(["obj-s2uc1"], "readwrite");
-  let store3 = transaction.objectStore("obj-s2uc1");
+  const store3 = transaction.objectStore("obj-s2uc1");
   store3.add({id3: 16, name2: "foo", email: "foo@bar.com"});
   await new Promise(success => {
     transaction.oncomplete = success;
diff --git a/devtools/client/storage/test/storage-secured-iframe.html b/devtools/client/storage/test/storage-secured-iframe.html
index a4766b8dc8a1..e0b7cc3716e1 100644
--- a/devtools/client/storage/test/storage-secured-iframe.html
+++ b/devtools/client/storage/test/storage-secured-iframe.html
@@ -9,7 +9,7 @@ Iframe for testing multiple host detetion in storage actor
 <body>
 <script type="application/javascript">
 "use strict";
-let cookieExpiresTime = 2000000000000;
+const cookieExpiresTime = 2000000000000;
 document.cookie = "sc1=foobar;";
 document.cookie = "sc2=foobar-2; expires=" +
   new Date(cookieExpiresTime).toGMTString() + ";";
@@ -17,17 +17,17 @@ localStorage.setItem("iframe-s-ls1", "foobar");
 sessionStorage.setItem("iframe-s-ss1", "foobar-2");
 dump("added cookies and storage from secured iframe\n");
 
-let idbGenerator = async function () {
+const idbGenerator = async function () {
   let request = indexedDB.open("idb-s1", 1);
   request.onerror = function() {
     throw new Error("error opening db connection");
   };
-  let db = await new Promise(done => {
+  const db = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db = event.target.result;
-      let store1 = db.createObjectStore("obj-s1", { keyPath: "id" });
+      const _db = event.target.result;
+      const store1 = _db.createObjectStore("obj-s1", { keyPath: "id" });
       store1.transaction.oncomplete = () => {
-        done(db);
+        done(_db);
       };
     };
   });
@@ -36,7 +36,7 @@ let idbGenerator = async function () {
   });
 
   let transaction = db.transaction(["obj-s1"], "readwrite");
-  let store1 = transaction.objectStore("obj-s1");
+  const store1 = transaction.objectStore("obj-s1");
   store1.add({id: 6, name: "foo", email: "foo@bar.com"});
   store1.add({id: 7, name: "foo2", email: "foo2@bar.com"});
   await new Promise(success => {
@@ -46,14 +46,14 @@ let idbGenerator = async function () {
   db.close();
 
   request = indexedDB.open("idb-s2", 1);
-  let db2 = await new Promise(done => {
+  const db2 = await new Promise(done => {
     request.onupgradeneeded = event => {
-      let db2 = event.target.result;
-      let store3 =
-        db2.createObjectStore("obj-s2", { keyPath: "id3", autoIncrement: true });
+      const _db2 = event.target.result;
+      const store3 =
+        _db2.createObjectStore("obj-s2", { keyPath: "id3", autoIncrement: true });
       store3.createIndex("name2", "name2", { unique: true });
       store3.transaction.oncomplete = () => {
-        done(db2);
+        done(_db2);
       };
     };
   });
@@ -62,7 +62,7 @@ let idbGenerator = async function () {
   });
 
   transaction = db2.transaction(["obj-s2"], "readwrite");
-  let store3 = transaction.objectStore("obj-s2");
+  const store3 = transaction.objectStore("obj-s2");
   store3.add({id3: 16, name2: "foo", email: "foo@bar.com"});
   await new Promise(success => {
     transaction.oncomplete = success;
diff --git a/devtools/client/storage/test/storage-sessionstorage.html b/devtools/client/storage/test/storage-sessionstorage.html
index 6de12859f2f1..4143d3ba0232 100644
--- a/devtools/client/storage/test/storage-sessionstorage.html
+++ b/devtools/client/storage/test/storage-sessionstorage.html
@@ -8,7 +8,7 @@
     <title>Storage inspector sessionStorage test</title>
     <script type="application/javascript">
       "use strict";
-
+      /* exported setup */
       function setup() {
         sessionStorage.setItem("TestSS1", "ValueSS1");
         sessionStorage.setItem("TestSS2", "ValueSS2");
diff --git a/devtools/client/storage/test/storage-sidebar-parsetree.html b/devtools/client/storage/test/storage-sidebar-parsetree.html
index 388e42b65700..619a456aaa25 100644
--- a/devtools/client/storage/test/storage-sidebar-parsetree.html
+++ b/devtools/client/storage/test/storage-sidebar-parsetree.html
@@ -5,7 +5,7 @@
     <title>Storage inspector sidebar parsetree test</title>
     <script type="application/javascript">
       "use strict";
-
+      /* exported setup */
       function setup() {
         // These values should not be parsed into a tree.
         localStorage.setItem("base64", "aGVsbG93b3JsZA==");
diff --git a/devtools/client/storage/test/storage-updates.html b/devtools/client/storage/test/storage-updates.html
index c14b64623fdd..5fcbd10c4c96 100644
--- a/devtools/client/storage/test/storage-updates.html
+++ b/devtools/client/storage/test/storage-updates.html
@@ -46,8 +46,8 @@ window.clear = function() {
 };
 
 window.onload = function() {
-  addCookie("c1", "1.2.3.4.5.6.7", "/browser");
-  addCookie("c2", "foobar", "/browser");
+  window.addCookie("c1", "1.2.3.4.5.6.7", "/browser");
+  window.addCookie("c2", "foobar", "/browser");
 
   // Some keys have to be set to strings that JSON.parse can parse successfully
   // instead of throwings (to verify the issue fixed by Bug 1578447 doesn't regress).
