nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1660405 - Transform mozilla::IsNegative to use std implementation. r=glandium

Browse source 
Since we cannot move away from mozilla::IsNegative to std::signbit because the
first one doesn't accept a NaN we should transform our function to use std implementation.

Differential Revision: https://phabricator.services.mozilla.com/D173111
This commit is contained in:
Andi-Bogdan Postelnicu 2023-03-22 11:35:36 +00:00
parent e6c033fea4
commit 3fd4d5f938
1 changed files with 1 additions and 6 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
mfbt/FloatingPoint.h
View file

@ -162,12 +162,7 @@ struct FloatingPoint final : private detail::FloatingPointTrait<T> {
template <typename T> template <typename T>
static MOZ_ALWAYS_INLINE bool IsNegative(T aValue) { static MOZ_ALWAYS_INLINE bool IsNegative(T aValue) {
MOZ_ASSERT(!std::isnan(aValue), "NaN does not have a sign"); MOZ_ASSERT(!std::isnan(aValue), "NaN does not have a sign");
return std::signbit(aValue);
/* The sign bit is set if the double is negative. */
typedef FloatingPoint<T> Traits;
typedef typename Traits::Bits Bits;
Bits bits = BitwiseCast<Bits>(aValue);
return (bits & Traits::kSignBit) != 0;
} }
/** Determines whether a float/double represents -0. */ /** Determines whether a float/double represents -0. */