nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1472876 - Make empty URL in CSS compute to empty (rather than about:invalid), as required by the spec. r=firefox-style-system-reviewers,emilio

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D192809
This commit is contained in:
Jonathan Kew 2023-11-06 10:15:27 +00:00
parent 329dd14d50
commit 41ce345193
2 changed files with 6 additions and 21 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
layout/style/GeckoBindings.cpp
View file

@ -1192,7 +1192,12 @@ void Gecko_GetComputedImageURLSpec(const StyleComputedUrl* aURL,
} }
} }
aOut->AssignLiteral("about:invalid"); // Empty URL computes to empty, per spec:
if (aURL->SpecifiedSerialization().IsEmpty()) {
aOut->Truncate();
} else {
aOut->AssignLiteral("about:invalid");
}
} }
bool Gecko_IsSupportedImageMimeType(const uint8_t* aMimeType, bool Gecko_IsSupportedImageMimeType(const uint8_t* aMimeType,

20
testing/web-platform/meta/css/css-values/urls/empty.html.ini
View file

@ -1,20 +0,0 @@
[empty.html]
[empty URL: inline-unquoted]
expected:
if (os == "mac") and not debug: [FAIL, PASS]
FAIL
[empty URL: inline-quoted]
expected:
if (os == "mac") and not debug: [FAIL, PASS]
FAIL
[empty URL: external-unquoted]
expected:
if (os == "mac") and not debug: [FAIL, PASS]
FAIL
[empty URL: external-quoted]
expected:
if (os == "mac") and not debug: [FAIL, PASS]
FAIL