nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1919750 - Don't send SETTINGS_TYPE_MAX_CONCURRENT when push is disabled a=dmeehan

Browse source 
Original Revision: https://phabricator.services.mozilla.com/D222778

Differential Revision: https://phabricator.services.mozilla.com/D230530
This commit is contained in:
Valentin Gosu 2024-11-28 14:40:53 +00:00
parent 0bbde3efdd
commit 43ec029640
2 changed files with 15 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

8
modules/libpref/init/StaticPrefList.yaml
View file

@ -13262,6 +13262,14 @@
value: false value: false
mirror: always mirror: always
# When true, Firefox will send a SETTINGS_MAX_CONCURRENT_STREAMS
# parameter when push is disabled. Chrome doesn't send this,
# so some servers misbehave when we do. See Bug 1919750.
- name: network.http.http2.send-push-max-concurrent-frame
type: RelaxedAtomicBool
value: false
mirror: always
- name: network.http.http2.push-allowance - name: network.http.http2.push-allowance
type: RelaxedAtomicInt32 type: RelaxedAtomicInt32
value: 131072 # 128KB value: 131072 # 128KB

12
netwerk/protocol/http/Http2Session.cpp
View file

@ -1035,11 +1035,13 @@ void Http2Session::SendHello() {
// The value portion of the setting pair is already initialized to 0 // The value portion of the setting pair is already initialized to 0
numberOfEntries++; numberOfEntries++;
NetworkEndian::writeUint16( if (StaticPrefs::network_http_http2_send_push_max_concurrent_frame()) {
packet + kFrameHeaderBytes + (6 * numberOfEntries), NetworkEndian::writeUint16(
SETTINGS_TYPE_MAX_CONCURRENT); packet + kFrameHeaderBytes + (6 * numberOfEntries),
// The value portion of the setting pair is already initialized to 0 SETTINGS_TYPE_MAX_CONCURRENT);
numberOfEntries++; // The value portion of the setting pair is already initialized to 0
numberOfEntries++;
}
mWaitingForSettingsAck = true; mWaitingForSettingsAck = true;
} }