nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1481005 - Explicitly delete dtor of AlignmentFinder::Alinger to avoid MSVC warning breaking debug builds. r=froydnj

Browse source 
Bug 1480624 added new code that results in a warning on MSVC debug builds. This
warning is treated as an error and makes such builds unhappy. The warning is
due to implicit deletion of a dtor, this changeset makes that deletion
explicit to avoid the fatal warning.

Differential Revision: https://phabricator.services.mozilla.com/D2865

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Bryce Van Dyk 2018-08-07 17:58:39 +00:00
parent bb9689b710
commit 460c97cad4
1 changed files with 6 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

6
mfbt/Alignment.h
View file

@ -26,6 +26,12 @@ class AlignmentFinder
{
char mChar;
T mT;
// Aligner may be used to check alignment of types with deleted dtors. This
// results in such specializations having implicitly deleted dtors, which
// causes fatal warnings on MSVC (see bug 1481005). As we don't create
// Aligners, we can avoid this warning by explicitly deleting the dtor.
~Aligner() = delete;
};
public: