nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1588710 - Do not fail on stack protector on some asm chromium & breakpad sandboxing code r=mhentges

Browse source 
caused:
[task 2020-11-05T10:14:26.012Z] 10:14:26     INFO -  In file included from Unified_cpp_sandbox_linux2.cpp:137:
[task 2020-11-05T10:14:26.012Z] 10:14:26    ERROR -  /builds/worker/checkouts/gecko/security/sandbox/chromium/sandbox/linux/seccomp-bpf/syscall.cc:369:3: error: Unable to protect inline asm that clobbers stack pointer against stack clash [-Werror,-Wstack-protector]
[task 2020-11-05T10:14:26.012Z] 10:14:26     INFO -    asm volatile(
[task 2020-11-05T10:14:26.013Z] 10:14:26     INFO -    ^
[task 2020-11-05T10:14:26.013Z] 10:14:26     INFO -  1 error generated.

Differential Revision: https://phabricator.services.mozilla.com/D97567
This commit is contained in:
Sylvestre Ledru 2020-11-27 10:14:01 +00:00
parent 290d475767
commit 5079cc5b3f
6 changed files with 8 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
security/sandbox/linux/moz.build
View file

@ -106,7 +106,7 @@ if CONFIG["CC_TYPE"] in ("clang", "gcc"):
]
if CONFIG["CC_TYPE"] in ("clang", "gcc"):
CXXFLAGS += ["-Wno-shadow"]
CXXFLAGS += ["-Wno-shadow", "-Wno-error=stack-protector"]
SOURCES["../chromium/sandbox/linux/services/syscall_wrappers.cc"].flags += [
"-Wno-empty-body",
]

3
toolkit/crashreporter/breakpad-client/linux/moz.build
View file

@ -36,3 +36,6 @@ include('/toolkit/crashreporter/crashreporter.mozbuild')
if CONFIG['MOZ_PHC']:
DEFINES['MOZ_PHC'] = True
if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
CXXFLAGS += ['-Wno-error=stack-protector']

2
toolkit/crashreporter/breakpad-client/moz.build
View file

@ -30,4 +30,4 @@ LOCAL_INCLUDES += [
]
if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
CXXFLAGS += ['-Wno-shadow']
CXXFLAGS += ['-Wno-shadow', '-Wno-error=stack-protector']

2
toolkit/crashreporter/google-breakpad/src/common/linux/moz.build
View file

@ -59,4 +59,4 @@ HOST_DEFINES['NO_STABS_SUPPORT'] = True
include('/toolkit/crashreporter/crashreporter.mozbuild')
if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
CXXFLAGS += ['-Wno-shadow']
CXXFLAGS += ['-Wno-shadow', '-Wno-error=stack-protector']

2
toolkit/crashreporter/moz.build
View file

@ -125,7 +125,7 @@ if CONFIG["MOZ_CRASHREPORTER"]:
include("/toolkit/crashreporter/crashreporter.mozbuild")
if CONFIG["CC_TYPE"] in ("clang", "gcc"):
CXXFLAGS += ["-Wno-shadow"]
CXXFLAGS += ["-Wno-shadow", "-Wno-error=stack-protector"]
else:
UNIFIED_SOURCES += [
"nsDummyExceptionHandler.cpp",

1
tools/profiler/moz.build
View file

@ -171,6 +171,7 @@ BROWSER_CHROME_MANIFESTS += ["tests/browser/browser.ini"]
if CONFIG["CC_TYPE"] in ("clang", "gcc"):
CXXFLAGS += [
"-Wno-error=shadow",
"-Wno-error=stack-protector",
"-Wno-ignored-qualifiers", # due to use of breakpad headers
]