Bug 1506559 - Enable ESLint for memory/replace/dmd/test/. r=njn

Differential Revision: https://phabricator.services.mozilla.com/D11619

--HG--
extra : moz-landing-system : lando

.eslintignore

@@ -26,7 +26,6 @@ gfx/tests/chrome/**
 gfx/tests/mochitest/**
 image/**
 layout/**
-memory/replace/dmd/test/**
 modules/**
 netwerk/cookie/test/browser/**
 netwerk/test/browser/**

memory/replace/dmd/test/.eslintrc.js

@@ -0,0 +1,7 @@
+"use strict";
+
+module.exports = {
+  "extends": [
+    "plugin:mozilla/xpcshell-test"
+  ]
+};

memory/replace/dmd/test/test_dmd.js

@@ -6,9 +6,8 @@
 
 "use strict";
 
-var {classes: Cc, interfaces: Ci, utils: Cu} = Components
-
 ChromeUtils.import("resource://gre/modules/FileUtils.jsm");
+ChromeUtils.import("resource://gre/modules/Services.jsm");
 
 // The xpcshell test harness sets PYTHON so we can read it here.
 var gEnv = Cc["@mozilla.org/process/environment;1"]
@@ -30,8 +29,7 @@ function getExecutable(aFilename) {
   return file;
 }
 
-var gIsWindows = Cc["@mozilla.org/xre/app-info;1"]
-                 .getService(Ci.nsIXULRuntime).OS === "WINNT";
+var gIsWindows = Services.appinfo.OS === "WINNT";
 var gDmdTestFile = getExecutable("SmokeDMD" + (gIsWindows ? ".exe" : ""));
 
 var gDmdScriptFile = getExecutable("dmd.py");
@@ -55,7 +53,7 @@ function readFile(aFile) {
     data += str.value;
   } while (read != 0);
 
-  cstream.close();                // this closes fstream
+  cstream.close(); // this closes fstream
   return data.replace(/\r/g, ""); // normalize line endings
 }
 
@@ -78,7 +76,7 @@ function test(aPrefix, aArgs) {
   let args = [
     gDmdScriptFile.path,
     "--filter-stacks-for-testing",
-    "-o", actualFile.path
+    "-o", actualFile.path,
   ].concat(aArgs);
 
   runProcess(new FileUtils.File(gPythonName), args);
@@ -136,7 +134,7 @@ function run_test() {
   // in-place (to fix stacks) when it runs dmd.py, and that's not safe to do
   // asynchronously.
 
-  gEnv.set('DMD', '1');
+  gEnv.set("DMD", "1");
 
   runProcess(gDmdTestFile, []);
 
@@ -165,8 +163,7 @@ function run_test() {
   jsonFile = FileUtils.getFile("CurWorkD", ["basic-scan.json"]);
   ok(scanTest(jsonFile.path), "Basic scan test");
 
-  let is64Bit = Cc["@mozilla.org/xre/app-info;1"]
-                  .getService(Ci.nsIXULRuntime).is64Bit;
+  let is64Bit = Services.appinfo.is64Bit;
   let basicScanFileName = "basic-scan-" + (is64Bit ? "64" : "32");
   test(basicScanFileName, ["--clamp-contents", jsonFile.path]);
   ok(scanTest(jsonFile.path, ["--clamp-contents"]), "Scan with address clamping");
@@ -187,7 +184,7 @@ function run_test() {
   // of the tested values.
   jsonFile = FileUtils.getFile("CurWorkD", ["script-max-frames.json"]);
   test("script-max-frames-8",
-       [jsonFile.path]);  // --max-frames=8 is the default
+       [jsonFile.path]); // --max-frames=8 is the default
   test("script-max-frames-3",
        ["--max-frames=3", "--no-fix-stacks", jsonFile.path]);
   test("script-max-frames-1",