nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1904059 - Using DOM::Function::Call instead JS_CallFunctionValue in DebuggerImmediateRunnable::WorkerRun. r=asuth, a=RyanVM

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D222436
This commit is contained in:
Eden Chuang 2024-09-26 09:30:13 +00:00
parent 20af5eb59d
commit 524cb8f30a
2 changed files with 11 additions and 7 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

14
dom/workers/WorkerPrivate.cpp
View file

@ -626,16 +626,18 @@ class DebuggerImmediateRunnable final : public WorkerThreadRunnable {
// Silence bad assertions. // Silence bad assertions.
} }
// Make as MOZ_CAN_RUN_SCRIPT_BOUNDARY for calling mHandler->Call();
// Since WorkerRunnable::WorkerRun has not to be MOZ_CAN_RUN_SCRIPT, but
// DebuggerImmediateRunnable is a special case that must to call the function
// defined in the debugger script.
MOZ_CAN_RUN_SCRIPT_BOUNDARY
virtual bool WorkerRun(JSContext* aCx, virtual bool WorkerRun(JSContext* aCx,
WorkerPrivate* aWorkerPrivate) override { WorkerPrivate* aWorkerPrivate) override {
JS::Rooted<JSObject*> global(aCx, JS::CurrentGlobalOrNull(aCx));
JS::Rooted<JS::Value> callable(
aCx, JS::ObjectOrNullValue(mHandler->CallableOrNull()));
JS::HandleValueArray args = JS::HandleValueArray::empty();
JS::Rooted<JS::Value> rval(aCx); JS::Rooted<JS::Value> rval(aCx);
IgnoredErrorResult rv;
MOZ_KnownLive(mHandler)->Call({}, &rval, rv);
// WorkerRunnable::Run will report the exception if it happens. return !rv.Failed();
return JS_CallFunctionValue(aCx, global, callable, args, &rval);
} }
}; };

4
dom/workers/test/WorkerDebugger.initialize_waiting_debugger.js
View file

@ -2,4 +2,6 @@
dump(" Evaluated debugger script\n"); dump(" Evaluated debugger script\n");
postMessage("debugger script ran"); setImmediate(function () {
postMessage("debugger script ran");
});