nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1787382 - Remove resolutionchange events firing r=win-reviewers,cmartin

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D209883
This commit is contained in:
Brian Tsoi 2024-05-09 14:37:04 +00:00
parent 1c04c8098f
commit 52529f589f
7 changed files with 0 additions and 33 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
widget/cocoa/nsCocoaWindow.mm
View file

@ -1971,7 +1971,6 @@ void nsCocoaWindow::BackingScaleFactorChanged() {
if (PresShell* presShell = mWidgetListener->GetPresShell()) { if (PresShell* presShell = mWidgetListener->GetPresShell()) {
presShell->BackingScaleFactorChanged(); presShell->BackingScaleFactorChanged();
} }
mWidgetListener->UIResolutionChanged();
} }
int32_t nsCocoaWindow::RoundsWidgetCoordinatesTo() { int32_t nsCocoaWindow::RoundsWidgetCoordinatesTo() {

1
widget/gtk/nsWindow.cpp
View file

@ -5383,7 +5383,6 @@ void nsWindow::OnDPIChanged() {
if (PresShell* presShell = mWidgetListener->GetPresShell()) { if (PresShell* presShell = mWidgetListener->GetPresShell()) {
presShell->BackingScaleFactorChanged(); presShell->BackingScaleFactorChanged();
} }
mWidgetListener->UIResolutionChanged();
} }
NotifyAPZOfDPIChange(); NotifyAPZOfDPIChange();
} }

2
widget/nsIWidgetListener.cpp
View file

@ -36,8 +36,6 @@ void nsIWidgetListener::SizeModeChanged(nsSizeMode aSizeMode) {}
void nsIWidgetListener::SafeAreaInsetsChanged(const mozilla::ScreenIntMargin&) { void nsIWidgetListener::SafeAreaInsetsChanged(const mozilla::ScreenIntMargin&) {
} }
void nsIWidgetListener::UIResolutionChanged() {}
#if defined(MOZ_WIDGET_ANDROID) #if defined(MOZ_WIDGET_ANDROID)
void nsIWidgetListener::DynamicToolbarMaxHeightChanged(ScreenIntCoord aHeight) { void nsIWidgetListener::DynamicToolbarMaxHeightChanged(ScreenIntCoord aHeight) {
} }

6
widget/nsIWidgetListener.h
View file

@ -81,12 +81,6 @@ class nsIWidgetListener {
*/ */
virtual void SizeModeChanged(nsSizeMode aSizeMode); virtual void SizeModeChanged(nsSizeMode aSizeMode);
/**
* Called when the DPI (device resolution scaling factor) is changed,
* such that UI elements may need to be rescaled.
*/
virtual void UIResolutionChanged();
#if defined(MOZ_WIDGET_ANDROID) #if defined(MOZ_WIDGET_ANDROID)
virtual void DynamicToolbarMaxHeightChanged(mozilla::ScreenIntCoord aHeight); virtual void DynamicToolbarMaxHeightChanged(mozilla::ScreenIntCoord aHeight);
virtual void DynamicToolbarOffsetChanged(mozilla::ScreenIntCoord aOffset); virtual void DynamicToolbarOffsetChanged(mozilla::ScreenIntCoord aOffset);

6
widget/windows/nsWindow.cpp
View file

@ -5630,9 +5630,6 @@ bool nsWindow::ProcessMessageInternal(UINT msg, WPARAM& wParam, LPARAM& lParam,
if (WinUtils::LogToPhysFactor(mWnd) != mDefaultScale) { if (WinUtils::LogToPhysFactor(mWnd) != mDefaultScale) {
ChangedDPI(); ChangedDPI();
ResetLayout(); ResetLayout();
if (mWidgetListener) {
mWidgetListener->UIResolutionChanged();
}
} }
} }
break; break;
@ -5670,9 +5667,6 @@ bool nsWindow::ProcessMessageInternal(UINT msg, WPARAM& wParam, LPARAM& lParam,
case WM_DISPLAYCHANGE: { case WM_DISPLAYCHANGE: {
ScreenHelperWin::RefreshScreens(); ScreenHelperWin::RefreshScreens();
if (mWidgetListener) {
mWidgetListener->UIResolutionChanged();
}
break; break;
} }

14
xpfe/appshell/AppWindow.cpp
View file

@ -2957,15 +2957,6 @@ void AppWindow::SizeModeChanged(nsSizeMode aSizeMode) {
// then need to be different. // then need to be different.
} }
void AppWindow::UIResolutionChanged() {
nsCOMPtr<nsPIDOMWindowOuter> ourWindow =
mDocShell ? mDocShell->GetWindow() : nullptr;
if (ourWindow) {
ourWindow->DispatchCustomEvent(u"resolutionchange"_ns,
ChromeOnlyDispatch::eYes);
}
}
void AppWindow::FullscreenWillChange(bool aInFullscreen) { void AppWindow::FullscreenWillChange(bool aInFullscreen) {
if (mDocShell) { if (mDocShell) {
if (nsCOMPtr<nsPIDOMWindowOuter> ourWindow = mDocShell->GetWindow()) { if (nsCOMPtr<nsPIDOMWindowOuter> ourWindow = mDocShell->GetWindow()) {
@ -3456,11 +3447,6 @@ void AppWindow::WidgetListenerDelegate::SizeModeChanged(nsSizeMode aSizeMode) {
holder->SizeModeChanged(aSizeMode); holder->SizeModeChanged(aSizeMode);
} }
void AppWindow::WidgetListenerDelegate::UIResolutionChanged() {
RefPtr<AppWindow> holder = mAppWindow;
holder->UIResolutionChanged();
}
void AppWindow::WidgetListenerDelegate::MacFullscreenMenubarOverlapChanged( void AppWindow::WidgetListenerDelegate::MacFullscreenMenubarOverlapChanged(
DesktopCoord aOverlapAmount) { DesktopCoord aOverlapAmount) {
RefPtr<AppWindow> holder = mAppWindow; RefPtr<AppWindow> holder = mAppWindow;

3
xpfe/appshell/AppWindow.h
View file

@ -98,8 +98,6 @@ class AppWindow final : public nsIBaseWindow,
MOZ_CAN_RUN_SCRIPT_BOUNDARY MOZ_CAN_RUN_SCRIPT_BOUNDARY
virtual void SizeModeChanged(nsSizeMode sizeMode) override; virtual void SizeModeChanged(nsSizeMode sizeMode) override;
MOZ_CAN_RUN_SCRIPT_BOUNDARY MOZ_CAN_RUN_SCRIPT_BOUNDARY
virtual void UIResolutionChanged() override;
MOZ_CAN_RUN_SCRIPT_BOUNDARY
virtual void MacFullscreenMenubarOverlapChanged( virtual void MacFullscreenMenubarOverlapChanged(
mozilla::DesktopCoord aOverlapAmount) override; mozilla::DesktopCoord aOverlapAmount) override;
MOZ_CAN_RUN_SCRIPT_BOUNDARY MOZ_CAN_RUN_SCRIPT_BOUNDARY
@ -158,7 +156,6 @@ class AppWindow final : public nsIBaseWindow,
bool WindowResized(nsIWidget* aWidget, int32_t aWidth, int32_t aHeight); bool WindowResized(nsIWidget* aWidget, int32_t aWidth, int32_t aHeight);
MOZ_CAN_RUN_SCRIPT bool RequestWindowClose(nsIWidget* aWidget); MOZ_CAN_RUN_SCRIPT bool RequestWindowClose(nsIWidget* aWidget);
MOZ_CAN_RUN_SCRIPT void SizeModeChanged(nsSizeMode aSizeMode); MOZ_CAN_RUN_SCRIPT void SizeModeChanged(nsSizeMode aSizeMode);
MOZ_CAN_RUN_SCRIPT void UIResolutionChanged();
MOZ_CAN_RUN_SCRIPT void FullscreenWillChange(bool aInFullscreen); MOZ_CAN_RUN_SCRIPT void FullscreenWillChange(bool aInFullscreen);
MOZ_CAN_RUN_SCRIPT void FullscreenChanged(bool aInFullscreen); MOZ_CAN_RUN_SCRIPT void FullscreenChanged(bool aInFullscreen);
MOZ_CAN_RUN_SCRIPT void MacFullscreenMenubarOverlapChanged( MOZ_CAN_RUN_SCRIPT void MacFullscreenMenubarOverlapChanged(