Bug 1465046 - Remove ProcessHandler.waitForFinish(). r=whimboo

--HG--
extra : rebase_source : 9df8444de596c5868efd18c62054f321513b99d6

config/tests/unit-nsinstall.py

@@ -168,7 +168,7 @@ class TestNsinstall(unittest.TestCase):
                                                     NSINSTALL_PATH,
                                                     testfile, testdir])
             p.run()
-            rv = p.waitForFinish()
+            rv = p.wait()
 
             self.assertEqual(rv, 0)
             destfile = os.path.join(testdir, filename)

testing/mozbase/mozprocess/mozprocess/processhandler.py

@@ -863,12 +863,6 @@ falling back to not using job objects for managing child processes""", file=sys.
         self.returncode = self.proc.wait()
         return self.returncode
 
-    # TODO Remove this method when consumers have been fixed
-    def waitForFinish(self, timeout=None):
-        print("MOZPROCESS WARNING: ProcessHandler.waitForFinish() is deprecated, "
-              "use ProcessHandler.wait() instead", file=sys.stderr)
-        return self.wait(timeout=timeout)
-
     @property
     def pid(self):
         return self.proc.pid