From 5e26dbfdc7626ce4398ed5adfbf7fe58e9e4f7ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Tue, 1 Oct 2024 20:31:41 +0000 Subject: [PATCH] Bug 1921797 - Check for degenerate ratio in nsCocoaUtis. r=mac-reviewers,mstange,bradwerth a=RyanVM This is the straight-forward, uncontroversial fix, that can be uplifted. Differential Revision: https://phabricator.services.mozilla.com/D224211 --- widget/cocoa/nsCocoaUtils.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/widget/cocoa/nsCocoaUtils.mm b/widget/cocoa/nsCocoaUtils.mm index 769eb05a85fd..5bb487f7f725 100644 --- a/widget/cocoa/nsCocoaUtils.mm +++ b/widget/cocoa/nsCocoaUtils.mm @@ -523,7 +523,7 @@ nsresult nsCocoaUtils::CreateNSImageFromImageContainer( { const bool gotWidth = NS_SUCCEEDED(aImage->GetWidth(&width)); const bool gotHeight = NS_SUCCEEDED(aImage->GetHeight(&height)); - if (auto ratio = aImage->GetIntrinsicRatio()) { + if (auto ratio = aImage->GetIntrinsicRatio(); ratio && *ratio) { if (gotWidth != gotHeight) { if (gotWidth) { height = ratio->Inverted().ApplyTo(width);