nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1890155: If we can't get an HWND when clients call IAccessible2::windowHandle, fall back to the first top level Gecko HWND we can find. a=RyanVM

Browse source 
This hack is needed to avoid a crash in the Microsoft IA2 -> UIA proxy.
See the code comments for details.

Original Revision: https://phabricator.services.mozilla.com/D230189

Differential Revision: https://phabricator.services.mozilla.com/D232307
This commit is contained in:
James Teh 2024-12-17 02:32:39 +00:00
parent ce5667d627
commit 60f804b7c5
1 changed files with 18 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

18
accessible/windows/ia2/ia2Accessible.cpp
View file

@ -12,12 +12,14 @@
#include "AccessibleStates.h"
#include "AccAttributes.h"
#include "ApplicationAccessible.h"
#include "Compatibility.h"
#include "ia2AccessibleRelation.h"
#include "IUnknownImpl.h"
#include "nsCoreUtils.h"
#include "nsIAccessibleTypes.h"
#include "mozilla/a11y/PDocAccessible.h"
#include "mozilla/StaticPrefs_accessibility.h"
#include "Relation.h"
#include "TextRange-inl.h"
#include "nsAccessibilityService.h"
@ -352,6 +354,22 @@ ia2Accessible::get_windowHandle(HWND* aWindowHandle) {
if (!acc) return CO_E_OBJNOTCONNECTED;
*aWindowHandle = MsaaAccessible::GetHWNDFor(acc);
if (!*aWindowHandle && !StaticPrefs::accessibility_uia_enable()) {
// Bug 1890155: This can happen if a document is detached from its embedder.
// The document might be about to die or it might be moving to a different
// embedder; e.g. a tab in a different window. The IA2 -> UIA proxy may
// crash if we return a null HWND. For now, pick an arbitrary top level
// Gecko HWND. This might be wrong, but only briefly, since the document
// will either die or move very soon, at which point this method will
// return the correct answer.
// TODO This hack should be removed once we only use our native UIA
// implementation.
if (ApplicationAccessible* app = ApplicationAcc()) {
if (LocalAccessible* firstRoot = app->LocalFirstChild()) {
*aWindowHandle = MsaaAccessible::GetHWNDFor(firstRoot);
}
}
}
return S_OK;
}