From 677d8613eba494a98f2ef2549ed08b86116ddf3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Mon, 16 Sep 2024 20:53:26 +0000 Subject: [PATCH] Bug 1917017 - Add a null-check in FirePageHideEventForFrameLoaderSwap. r=smaug, a=dsmith Not sure what guarantees this in presence of random script running? Differential Revision: https://phabricator.services.mozilla.com/D222335 --- dom/base/nsContentUtils.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dom/base/nsContentUtils.cpp b/dom/base/nsContentUtils.cpp index 46f2faad6648..337578cd6fab 100644 --- a/dom/base/nsContentUtils.cpp +++ b/dom/base/nsContentUtils.cpp @@ -8909,9 +8909,9 @@ void nsContentUtils::FirePageHideEventForFrameLoaderSwap( MOZ_DIAGNOSTIC_ASSERT(aItem); MOZ_DIAGNOSTIC_ASSERT(aChromeEventHandler); - RefPtr doc = aItem->GetDocument(); - NS_ASSERTION(doc, "What happened here?"); - doc->OnPageHide(true, aChromeEventHandler, aOnlySystemGroup); + if (RefPtr doc = aItem->GetDocument()) { + doc->OnPageHide(true, aChromeEventHandler, aOnlySystemGroup); + } int32_t childCount = 0; aItem->GetInProcessChildCount(&childCount);