Bug 1790912 - Use globalThis instead of this with jsdebugger.jsm. r=jandem,ochameau

Use 'globalThis' instead of 'this' when trying to attach a debugger to the
current global to avoid subtle footguns with the varied definitions of 'this'.
The debugger interface needs a true GlobalObject so this is much clearer. In
particular, this is a problem in test_nativewrappers.js when the test runs in
strict mode since the 'this' in the test function is no long implicitly the
global.

Differential Revision: https://phabricator.services.mozilla.com/D157544

devtools/docs/user/debugger-api/tutorial-breakpoint/index.rst

@@ -49,7 +49,7 @@ This tutorial was tested against Firefox 58 Beta and Nightly. It does not work i
 
     // This defines 'Debugger' in this Scratchpad;
     // it doesn't actually start debugging anything.
-    addDebuggerToGlobal(this);
+    addDebuggerToGlobal(globalThis);
 
     // Create a 'Debugger' instance.
     var dbg = new Debugger;

devtools/server/tests/chrome/test_Debugger.Script.prototype.global.html

@@ -17,7 +17,7 @@ Debugger.Script.prototype.global should return innerize globals, not WindowProxi
 "use strict";
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 window.onload = function() {
   SimpleTest.waitForExplicitFinish();

devtools/server/tests/chrome/test_Debugger.Source.prototype.elementAttribute.html

@@ -18,7 +18,7 @@ element to which code is attached (if any), and how.
 "use strict";
 
 const {addSandboxedDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addSandboxedDebuggerToGlobal(this);
+addSandboxedDebuggerToGlobal(globalThis);
 
 window.onload = function() {
   SimpleTest.waitForExplicitFinish();

devtools/server/tests/chrome/test_Debugger.Source.prototype.introductionScript.html

@@ -18,7 +18,7 @@ behave when 'eval' is called with no scripted frames active at all.
 "use strict";
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 window.onload = function() {
   SimpleTest.waitForExplicitFinish();

devtools/server/tests/chrome/test_Debugger.Source.prototype.introductionType.html

@@ -19,7 +19,7 @@ JavaScrip appearing in an inline event handler attribute.
 "use strict";
 
 const {addSandboxedDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addSandboxedDebuggerToGlobal(this);
+addSandboxedDebuggerToGlobal(globalThis);
 
 let dbg;
 let iframeDO, doc;

devtools/server/tests/chrome/test_executeInGlobal-outerized_this.html

@@ -19,7 +19,7 @@ object.
 "use strict";
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 window.onload = function() {
   SimpleTest.waitForExplicitFinish();

devtools/server/tests/chrome/test_makeGlobalObjectReference.html

@@ -18,7 +18,7 @@ Debugger.prototype.makeGlobalObjectReference should dereference WindowProxy
 "use strict";
 
 const {addSandboxedDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addSandboxedDebuggerToGlobal(this);
+addSandboxedDebuggerToGlobal(globalThis);
 
 window.onload = function() {
   SimpleTest.waitForExplicitFinish();

devtools/server/tests/chrome/test_unsafeDereference.html

@@ -19,7 +19,7 @@ xray wrapper.
 "use strict";
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 window.onload = function() {
   SimpleTest.waitForExplicitFinish();

devtools/server/tests/xpcshell/test_getyoungestframe.js

@@ -7,7 +7,7 @@ function run_test() {
   const { addDebuggerToGlobal } = ChromeUtils.import(
     "resource://gre/modules/jsdebugger.jsm"
   );
-  addDebuggerToGlobal(this);
+  addDebuggerToGlobal(globalThis);
   const xpcInspector = Cc["@mozilla.org/jsinspector;1"].getService(
     Ci.nsIJSInspector
   );

devtools/server/tests/xpcshell/test_nativewrappers.js

@@ -7,7 +7,7 @@ function run_test() {
   const { addDebuggerToGlobal } = ChromeUtils.import(
     "resource://gre/modules/jsdebugger.jsm"
   );
-  addDebuggerToGlobal(this);
+  addDebuggerToGlobal(globalThis);
   const g = createTestGlobal("test1");
 
   const dbg = makeDebugger();

devtools/server/tests/xpcshell/test_safe-getter.js

@@ -7,7 +7,7 @@ function run_test() {
   const { addDebuggerToGlobal } = ChromeUtils.import(
     "resource://gre/modules/jsdebugger.jsm"
   );
-  addDebuggerToGlobal(this);
+  addDebuggerToGlobal(globalThis);
   const g = createTestGlobal("test", {
     wantGlobalProperties: ["ChromeUtils"],
   });

devtools/server/tests/xpcshell/test_unsafeDereference.js

@@ -11,7 +11,7 @@
 // cross-compartment wrappers with interesting properties, and this is the
 // xpcshell test directory most closely related to the JS Debugger API.
 
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 // Add a method to Debugger.Object for fetching value properties
 // conveniently.

devtools/shared/heapsnapshot/tests/xpcshell/test_ReadHeapSnapshot.js

@@ -7,7 +7,7 @@ if (typeof Debugger != "function") {
   const { addDebuggerToGlobal } = ChromeUtils.import(
     "resource://gre/modules/jsdebugger.jsm"
   );
-  addDebuggerToGlobal(this);
+  addDebuggerToGlobal(globalThis);
 }
 
 function run_test() {

devtools/shared/heapsnapshot/tests/xpcshell/test_ReadHeapSnapshot_with_allocations.js

@@ -9,7 +9,7 @@ if (typeof Debugger != "function") {
   const { addDebuggerToGlobal } = ChromeUtils.import(
     "resource://gre/modules/jsdebugger.jsm"
   );
-  addDebuggerToGlobal(this);
+  addDebuggerToGlobal(globalThis);
 }
 
 function run_test() {

devtools/shared/heapsnapshot/tests/xpcshell/test_SaveHeapSnapshot.js

@@ -7,7 +7,7 @@ if (typeof Debugger != "function") {
   const { addDebuggerToGlobal } = ChromeUtils.import(
     "resource://gre/modules/jsdebugger.jsm"
   );
-  addDebuggerToGlobal(this);
+  addDebuggerToGlobal(globalThis);
 }
 
 function run_test() {

devtools/shared/loader/worker-loader.js

@@ -397,7 +397,7 @@ var {
 const { addDebuggerToGlobal } = ChromeUtils.import(
   'resource://gre/modules/jsdebugger.jsm'
 );
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 `,
       sandbox
     );

devtools/shared/tests/xpcshell/test_invisible_loader.js

@@ -6,7 +6,7 @@
 const { addDebuggerToGlobal } = ChromeUtils.import(
   "resource://gre/modules/jsdebugger.jsm"
 );
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 /**
  * Ensure that sandboxes created via the Dev Tools loader respect the

devtools/shared/webconsole/test/xpcshell/test_js_property_provider.js

@@ -9,7 +9,7 @@ const {
 const { addDebuggerToGlobal } = ChromeUtils.import(
   "resource://gre/modules/jsdebugger.jsm"
 );
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 function run_test() {
   Services.prefs.setBoolPref(

dom/base/test/chrome/test_bug1346936.html

@@ -26,7 +26,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1346936
 /** Test for Bug 1346936 **/
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 window.onload = function() {
     SimpleTest.waitForExplicitFinish();

dom/base/test/chrome/test_bug765993.html

@@ -26,7 +26,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=765993
 /** Test for Bug 765993 **/
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 window.onload = function() {
     SimpleTest.waitForExplicitFinish();

dom/base/test/jsmodules/iframe_extractIntroType.html

@@ -5,7 +5,7 @@
   // Hook up the debugger statement to extract the calling script's
   // introductionType and set it in a property on the parent global.
   const {addSandboxedDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-  addSandboxedDebuggerToGlobal(this);
+  addSandboxedDebuggerToGlobal(globalThis);
   var dbg = new Debugger;
   dbg.addDebuggee(parent);
   dbg.onDebuggerStatement = function (frame) {

js/ductwork/debugger/jsdebugger.jsm

@@ -10,7 +10,7 @@ var EXPORTED_SYMBOLS = [ "addDebuggerToGlobal", "addSandboxedDebuggerToGlobal" ]
  *   const { addDebuggerToGlobal } = ChromeUtils.import(
  *     "resource://gre/modules/jsdebugger.jsm"
  *   );
- *   addDebuggerToGlobal(this);
+ *   addDebuggerToGlobal(globalThis);
  *
  * This will create a 'Debugger' object, which provides an interface to debug
  * JavaScript code running in other compartments in the same process, on the

js/ductwork/debugger/tests/test_nativewrappers.js

@@ -7,7 +7,7 @@ function run_test()
     Services.prefs.clearUserPref("security.allow_eval_with_system_principal");
   });
 
-  addDebuggerToGlobal(this);
+  addDebuggerToGlobal(globalThis);
   var g = testGlobal("test1");
 
   var dbg = new Debugger();

js/src/doc/Debugger/Tutorial-Breakpoint.md

@@ -53,7 +53,7 @@ This tutorial was tested against Firefox 58 Beta and Nightly. It does not work i
 
     // This simply defines 'Debugger' in this Scratchpad;
     // it doesn't actually start debugging anything.
-    addDebuggerToGlobal(this);
+    addDebuggerToGlobal(globalThis);
 
     // Create a 'Debugger' instance.
     var dbg = new Debugger;

js/xpconnect/tests/chrome/test_evalInSandbox.xhtml

@@ -178,7 +178,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=533596
       Cu.evalInSandbox('checkExplicitVersions();', outerSB);
 
       const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-      addDebuggerToGlobal(this);
+      addDebuggerToGlobal(globalThis);
 
       try {
         let dbg = new Debugger();

js/xpconnect/tests/chrome/test_onGarbageCollection.html

@@ -27,7 +27,7 @@
 const { addDebuggerToGlobal } = ChromeUtils.import(
   'resource://gre/modules/jsdebugger.jsm'
 );
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 `, sandbox
     );
 

js/xpconnect/tests/unit/test_xray_SavedFrame-02.js

@@ -2,7 +2,7 @@
 // un-privileged globals.
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 const lowP = Services.scriptSecurityManager.createNullPrincipal({});
 const highP = Cc["@mozilla.org/systemprincipal;1"].createInstance(Ci.nsIPrincipal);

js/xpconnect/tests/unit/test_xray_SavedFrame.js

@@ -2,7 +2,7 @@
 // that frame's principals.
 
 const {addDebuggerToGlobal} = ChromeUtils.import("resource://gre/modules/jsdebugger.jsm");
-addDebuggerToGlobal(this);
+addDebuggerToGlobal(globalThis);
 
 const lowP = Services.scriptSecurityManager.createNullPrincipal({});
 const midP = [lowP, "http://other.com"];