From 6b484b48f8f79d53467cdafaaef834413ca7d9c2 Mon Sep 17 00:00:00 2001 From: Dave Townsend Date: Tue, 19 Mar 2024 14:59:21 +0000 Subject: [PATCH] Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer Differential Revision: https://phabricator.services.mozilla.com/D203002 --- toolkit/actors/AutoplayChild.sys.mjs | 2 +- toolkit/actors/AutoplayParent.sys.mjs | 2 +- toolkit/actors/ControllersParent.sys.mjs | 2 +- toolkit/actors/NetErrorParent.sys.mjs | 4 +- toolkit/actors/PictureInPictureChild.sys.mjs | 18 ++-- toolkit/actors/PrintingChild.sys.mjs | 2 +- toolkit/actors/SelectChild.sys.mjs | 2 +- toolkit/actors/ViewSourcePageChild.sys.mjs | 2 +- .../aboutconfig/content/aboutconfig.js | 2 +- .../aboutmemory/content/aboutMemory.js | 4 +- .../aboutmemory/tests/test_aboutmemory.xhtml | 10 +- .../aboutmemory/tests/test_aboutmemory2.xhtml | 2 +- .../aboutmemory/tests/test_aboutmemory3.xhtml | 2 +- .../aboutmemory/tests/test_aboutmemory4.xhtml | 2 +- .../aboutmemory/tests/test_aboutmemory7.xhtml | 2 +- .../tests/test_memoryReporters.xhtml | 10 +- .../tests/test_memoryReporters2.xhtml | 2 +- .../tests/xpcshell/test_gpuprocess.js | 9 +- .../aboutprocesses/content/aboutProcesses.js | 4 +- .../tests/browser/browser_aboutthirdparty.js | 2 +- .../aboutwebauthn/content/aboutWebauthn.js | 4 +- .../browser_aboutwebauthn_credentials.js | 2 +- .../browser/browser_aboutwindowsmessages.js | 2 +- .../test/test_alerts_requireinteraction.html | 4 +- .../alerts/test/test_invalid_utf16.html | 2 +- .../alerts/test/test_multiple_alerts.html | 2 +- .../alerts/test/test_principal.html | 2 +- .../tests/unit/head_autocomplete.js | 8 +- .../autocomplete/tests/unit/test_378079.js | 8 +- .../autocomplete/tests/unit/test_393191.js | 8 +- .../autocomplete/tests/unit/test_440866.js | 8 +- .../tests/unit/test_autocomplete_multiple.js | 8 +- .../unit/test_autocomplete_userContextId.js | 7 +- .../tests/unit/test_previousResult.js | 8 +- .../tests/unit/test_stopSearch.js | 2 +- .../BHRTelemetryService.sys.mjs | 2 +- .../BackgroundTask_message.sys.mjs | 5 +- .../BackgroundTasksManager.sys.mjs | 2 +- .../BackgroundTasksUtils.sys.mjs | 2 +- .../tests/BackgroundTask_jsdebugger.sys.mjs | 2 +- ...ackgroundTask_shouldprocessupdates.sys.mjs | 2 +- .../tests/BackgroundTask_targeting.sys.mjs | 2 +- .../captivedetect/CaptiveDetect.sys.mjs | 9 +- .../captivedetect/test/unit/test_abort.js | 4 +- .../test/unit/test_abort_during_user_login.js | 2 +- .../test/unit/test_abort_ongoing_request.js | 4 +- .../test/unit/test_abort_pending_request.js | 4 +- .../test/unit/test_captive_portal_found.js | 4 +- .../unit/test_captive_portal_found_303.js | 4 +- .../unit/test_captive_portal_not_found.js | 2 +- .../unit/test_captive_portal_not_found_404.js | 2 +- .../test/unit/test_multiple_requests.js | 4 +- .../certviewer/content/certviewer.mjs | 4 +- .../browser/browser_openTabAndSendCertInfo.js | 2 +- .../certviewer/tests/browser/head.js | 2 +- .../cleardata/ClearDataService.sys.mjs | 42 ++++---- .../cleardata/SiteDataTestUtils.sys.mjs | 8 +- .../cleardata/tests/unit/test_permissions.js | 4 +- .../tests/unit/test_storage_permission.js | 8 +- .../contentprefs/ContentPrefService2.sys.mjs | 7 +- .../ContentPrefServiceParent.sys.mjs | 2 +- .../browser/browser_remoteContentPrefs.js | 4 +- .../contentprefs/tests/unit_cps2/head.js | 4 +- .../unit_cps2/test_migrationToSchema4.js | 2 +- .../ContextualIdentityService.sys.mjs | 2 +- .../components/crashes/CrashService.sys.mjs | 4 +- .../tests/xpcshell/test_crash_manager.js | 2 +- .../tests/xpcshell/test_crash_service.js | 2 +- .../tests/xpcshell/test_crash_store.js | 2 +- .../crashmonitor/CrashMonitor.sys.mjs | 2 +- .../crashmonitor/nsCrashMonitor.sys.mjs | 2 +- .../chrome/xpcshellTestHarnessAdaptor.js | 2 +- .../ctypes/tests/unit/test_jsctypes.js | 2 +- .../EnterprisePoliciesParent.sys.mjs | 2 +- .../browser_policies_enterprise_only.js | 4 +- .../test/unit/head_forgetaboutsite.js | 2 +- toolkit/components/gfx/SanityTest.sys.mjs | 2 +- .../components/gfx/content/gfxFrameScript.js | 2 +- .../tests/browser/browser_exception.js | 2 +- .../test/unit/test_mediasniffer.js | 4 +- .../test/unit/test_mediasniffer_ext.js | 4 +- .../lib/SpecialMessageActions.sys.mjs | 2 +- .../browser_sma_open_protection_panel.js | 2 +- .../browser/browser_sma_pin_current_tab.js | 2 +- .../ml/actors/MLEngineParent.sys.mjs | 2 +- .../components/pdfjs/content/PdfJs.sys.mjs | 2 +- .../pdfjs/content/PdfJsNetwork.sys.mjs | 4 +- .../pdfjs/content/PdfStreamConverter.sys.mjs | 8 +- .../pdfjs/content/PdfjsParent.sys.mjs | 2 +- .../pdfjs/test/browser_pdfjs_find.js | 2 +- .../test/browser_pdfjs_force_opening_files.js | 4 +- .../pdfjs/test/browser_pdfjs_fullscreen.js | 2 +- .../pdfjs/test/browser_pdfjs_navigation.js | 2 +- .../pdfjs/test/browser_pdfjs_octet_stream.js | 2 +- .../pdfjs/test/browser_pdfjs_savedialog.js | 2 +- toolkit/components/printing/content/print.js | 18 ++-- .../tests/browser_preview_navigation.js | 2 +- .../tests/file_window_print_reentrant.html | 2 +- toolkit/components/printing/tests/head.js | 6 +- .../MainProcessSingleton.sys.mjs | 2 +- .../browser/browser_test_powerMetrics.js | 14 +-- .../tests/browser/browser_test_procinfo.js | 2 +- .../tests/xpcshell/data/worker.js | 2 +- .../tests/xpcshell/data/worker.mjs | 2 +- .../prompts/src/CommonDialog.sys.mjs | 2 +- .../components/prompts/src/Prompter.sys.mjs | 22 +--- .../components/prompts/test/prompt_common.js | 4 +- .../prompts/test/test_bug619644.html | 2 +- toolkit/components/reader/AboutReader.sys.mjs | 2 +- toolkit/components/reader/ReaderMode.sys.mjs | 2 +- .../reader/test/browser_readerMode.js | 2 +- .../test/browser_readerMode_hidden_nodes.js | 2 +- .../tests/browser/browser_documentChannel.js | 4 +- .../browser_httpCrossOriginOpenerPolicy.js | 2 +- .../ReportBrokenSiteChild.sys.mjs | 2 +- .../test/unit/test_app_rep.js | 2 +- .../test/unit/test_app_rep_maclinux.js | 2 +- .../test/unit/test_app_rep_windows.js | 2 +- .../resistfingerprinting/RFPHelper.sys.mjs | 2 +- ...rowser_fpiServiceWorkers_fingerprinting.js | 2 +- ..._serviceWorker_fingerprinting_webcompat.js | 4 +- .../tests/browser/head.js | 2 +- .../shopping/content/ShoppingProduct.mjs | 2 +- .../test/browser/browser_shopping_ads_test.js | 2 +- .../browser_shopping_sidebar_messages.js | 8 +- .../components/shopping/test/browser/head.js | 4 +- .../tests/browser/browser_bug511456.js | 2 +- .../tests/browser/browser_bug537449.js | 2 +- .../TaskSchedulerMacOSImpl.sys.mjs | 4 +- .../terminator/TerminatorTelemetry.sys.mjs | 2 +- .../thumbnails/BackgroundPageThumbs.sys.mjs | 4 +- .../components/thumbnails/PageThumbs.sys.mjs | 4 +- .../browser_thumbnails_bg_captureIfMissing.js | 2 +- .../test/browser_thumbnails_bug727765.js | 2 +- .../test/browser_thumbnails_bug818225.js | 2 +- .../test/browser_thumbnails_redirect.js | 4 +- .../test/browser_thumbnails_storage.js | 2 +- .../test/browser_thumbnails_update.js | 8 +- .../timermanager/UpdateTimerManager.sys.mjs | 2 +- .../tests/unit/consumerNotifications.js | 20 ++-- .../tooltiptext/tests/browser_bug581947.js | 2 +- .../browser_about_translations_dropdowns.js | 2 +- .../translations/tests/browser/shared-head.js | 2 +- .../utils/ClientEnvironment.sys.mjs | 2 +- .../components/utils/SimpleServices.sys.mjs | 2 +- .../test/browser/browser_contextmenu.js | 2 +- .../browser/browser_viewsource_newwindow.js | 4 +- .../windowcreator/test/test_bug449141.html | 2 +- .../browser_new_content_window_chromeflags.js | 8 +- .../test/browser_new_remote_window_flags.js | 2 +- .../test/browser_new_sized_window.js | 2 +- .../test/browser_non_popup_from_popup.js | 2 +- toolkit/components/windowwatcher/test/head.js | 4 +- .../workerloader/tests/worker_test_loading.js | 2 +- toolkit/components/xulstore/XULStore.sys.mjs | 2 +- toolkit/content/aboutLogging.js | 4 +- toolkit/content/aboutNetError.mjs | 8 +- toolkit/content/aboutProfiles.js | 2 +- toolkit/content/aboutSupport.js | 32 +++--- toolkit/content/aboutTelemetry.js | 6 +- toolkit/content/aboutUrlClassifier.js | 2 +- toolkit/content/aboutwebrtc/aboutWebrtc.mjs | 8 +- toolkit/content/aboutwebrtc/graph.mjs | 8 +- toolkit/content/contentAreaUtils.js | 10 +- .../tests/browser/browser_about_logging.js | 4 +- .../tests/browser/browser_bug982298.js | 2 +- .../browser/browser_f7_caret_browsing.js | 2 +- .../tests/browser/browser_isSynthetic.js | 2 +- .../browser_media_wakelock_webaudio.js | 1 - .../browser_save_folder_standalone_image.js | 2 +- .../browser/browser_save_resend_postdata.js | 2 +- .../tests/browser/common/mockTransfer.js | 3 +- .../content/tests/browser/datetime/head.js | 2 +- toolkit/content/tests/browser/head.js | 2 +- .../tests/chrome/bug263683_window.xhtml | 2 +- .../tests/chrome/bug366992_window.xhtml | 2 +- .../chrome/file_editor_with_autocomplete.js | 60 +++++------ toolkit/content/tests/chrome/popup_trigger.js | 100 +++++++++--------- .../tests/chrome/test_arrowpanel.xhtml | 2 +- .../tests/chrome/test_menuitem_blink.xhtml | 2 +- .../tests/chrome/test_menulist_in_popup.xhtml | 2 +- .../tests/chrome/test_notificationbox.xhtml | 18 ++-- .../tests/chrome/test_popup_keys.xhtml | 2 +- .../chrome/test_popup_moveToAnchor.xhtml | 2 +- .../content/tests/chrome/test_tree_view.xhtml | 26 ++--- .../chrome/window_cursorsnap_dialog.xhtml | 2 +- .../chrome/window_maximized_persist.xhtml | 2 +- ...w_maximized_persist_with_no_titlebar.xhtml | 2 +- .../chrome/window_popup_anchoratrect.xhtml | 2 +- toolkit/content/tests/widgets/head.js | 2 +- .../content/tests/widgets/test_moz_card.html | 2 +- .../tests/widgets/test_popupreflows.xhtml | 4 +- .../tests/widgets/test_videocontrols.html | 2 +- .../widgets/test_videocontrols_audio.html | 2 +- .../test_videocontrols_jsdisabled.html | 2 +- .../test_videocontrols_onclickplay.html | 2 +- toolkit/content/tests/widgets/tree_shared.js | 14 +-- .../widgets/videocontrols_direction_test.js | 2 +- .../tests/widgets/window_menubar.xhtml | 8 +- toolkit/crashreporter/CrashSubmit.sys.mjs | 2 +- .../test/unit/test_crash_stack_overflow.js | 2 +- .../test/unit/test_crashreporter_appmem.js | 2 +- .../test/unit/test_event_files.js | 2 +- .../unit/test_override_exception_handler.js | 2 +- .../test/unit_ipc/test_content_memory_list.js | 2 +- toolkit/modules/AppMenuNotifications.sys.mjs | 2 +- toolkit/modules/AsanReporter.sys.mjs | 2 +- toolkit/modules/AsyncPrefs.sys.mjs | 2 +- toolkit/modules/FindBarContent.sys.mjs | 4 +- toolkit/modules/Finder.sys.mjs | 2 +- toolkit/modules/FinderHighlighter.sys.mjs | 10 +- toolkit/modules/FinderParent.sys.mjs | 2 +- toolkit/modules/GMPInstallManager.sys.mjs | 2 +- toolkit/modules/HiddenFrame.sys.mjs | 2 +- .../modules/LightweightThemeConsumer.sys.mjs | 8 +- toolkit/modules/NewTabUtils.sys.mjs | 8 +- toolkit/modules/PopupNotifications.sys.mjs | 4 +- toolkit/modules/Region.sys.mjs | 2 +- toolkit/modules/UpdateUtils.sys.mjs | 2 +- .../modules/tests/browser/browser_Finder.js | 4 +- .../browser/browser_FinderHighlighter.js | 2 +- .../tests/browser/browser_Troubleshoot.js | 6 +- .../tests/browser/browser_web_channel.js | 42 ++++---- toolkit/modules/tests/browser/head.js | 2 +- .../tests/modules/MockDocument.sys.mjs | 2 +- .../tests/xpcshell/test_DeferredTask.js | 2 +- .../tests/xpcshell/test_FinderIterator.js | 28 ++--- .../tests/xpcshell/test_GMPInstallManager.js | 13 ++- .../tests/xpcshell/test_Integration.js | 2 +- toolkit/modules/tests/xpcshell/test_sqlite.js | 37 +++---- .../tests/xpcshell/test_web_channel.js | 4 +- .../tests/xpcshell/test_web_channel_broker.js | 2 +- .../test/browser_checkdllblockliststate.js | 2 +- toolkit/xre/test/test_launch_without_hang.js | 6 +- .../win/mochitest/browser_env_path_long.js | 2 +- 235 files changed, 570 insertions(+), 631 deletions(-) diff --git a/toolkit/actors/AutoplayChild.sys.mjs b/toolkit/actors/AutoplayChild.sys.mjs index 87fa966cb1e3..42bff87ea141 100644 --- a/toolkit/actors/AutoplayChild.sys.mjs +++ b/toolkit/actors/AutoplayChild.sys.mjs @@ -4,7 +4,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ export class AutoplayChild extends JSWindowActorChild { - handleEvent(event) { + handleEvent() { this.sendAsyncMessage("GloballyAutoplayBlocked", {}); } } diff --git a/toolkit/actors/AutoplayParent.sys.mjs b/toolkit/actors/AutoplayParent.sys.mjs index 3e9f807b3a47..7b33c49c7fb2 100644 --- a/toolkit/actors/AutoplayParent.sys.mjs +++ b/toolkit/actors/AutoplayParent.sys.mjs @@ -4,7 +4,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ export class AutoplayParent extends JSWindowActorParent { - receiveMessage(aMessage) { + receiveMessage() { let topBrowsingContext = this.manager.browsingContext.top; let browser = topBrowsingContext.embedderElement; let document = browser.ownerDocument; diff --git a/toolkit/actors/ControllersParent.sys.mjs b/toolkit/actors/ControllersParent.sys.mjs index 05ea16611259..8461d76ba27c 100644 --- a/toolkit/actors/ControllersParent.sys.mjs +++ b/toolkit/actors/ControllersParent.sys.mjs @@ -47,7 +47,7 @@ export class ControllersParent extends JSWindowActorParent { this.sendAsyncMessage("ControllerCommands:Do", aCommand); } - getCommandStateWithParams(aCommand, aCommandParams) { + getCommandStateWithParams() { throw Components.Exception("Not implemented", Cr.NS_ERROR_NOT_IMPLEMENTED); } diff --git a/toolkit/actors/NetErrorParent.sys.mjs b/toolkit/actors/NetErrorParent.sys.mjs index ac0dbf49a07c..071529976a54 100644 --- a/toolkit/actors/NetErrorParent.sys.mjs +++ b/toolkit/actors/NetErrorParent.sys.mjs @@ -33,7 +33,7 @@ class CaptivePortalObserver { Services.obs.removeObserver(this, "captive-portal-login-success"); } - observe(aSubject, aTopic, aData) { + observe(aSubject, aTopic) { switch (aTopic) { case "captive-portal-login-abort": case "captive-portal-login-success": @@ -172,7 +172,7 @@ export class NetErrorParent extends JSWindowActorParent { request.channel.loadFlags |= Ci.nsIRequest.LOAD_BYPASS_CACHE; request.channel.loadFlags |= Ci.nsIRequest.INHIBIT_CACHING; - request.addEventListener("error", event => { + request.addEventListener("error", () => { // Make sure the user is still on the cert error page. if (!browser.documentURI.spec.startsWith("about:certerror")) { return; diff --git a/toolkit/actors/PictureInPictureChild.sys.mjs b/toolkit/actors/PictureInPictureChild.sys.mjs index 2a415df32db6..bffcb55e6d67 100644 --- a/toolkit/actors/PictureInPictureChild.sys.mjs +++ b/toolkit/actors/PictureInPictureChild.sys.mjs @@ -947,11 +947,8 @@ export class PictureInPictureToggleChild extends JSWindowActorChild { * tear out or in. If we happened to be tracking videos before the tear * occurred, we re-add the mouse event listeners so that they're attached to * the right WindowRoot. - * - * @param {Event} event The pageshow event fired when completing a tab tear - * out or in. */ - onPageShow(event) { + onPageShow() { let state = this.docState; if (state.isTrackingVideos) { this.addMouseButtonListeners(); @@ -963,11 +960,8 @@ export class PictureInPictureToggleChild extends JSWindowActorChild { * tear out or in. If we happened to be tracking videos before the tear * occurred, we remove the mouse event listeners. We'll re-add them when the * pageshow event fires. - * - * @param {Event} event The pagehide event fired when starting a tab tear - * out or in. */ - onPageHide(event) { + onPageHide() { let state = this.docState; if (state.isTrackingVideos) { this.removeMouseButtonListeners(); @@ -1049,7 +1043,7 @@ export class PictureInPictureToggleChild extends JSWindowActorChild { } } - startPictureInPicture(event, video, toggle) { + startPictureInPicture(event, video) { Services.telemetry.keyedScalarAdd( "pictureinpicture.opened_method", "toggle", @@ -2445,7 +2439,7 @@ export class PictureInPictureChild extends JSWindowActorChild { } } - onCueChange(e) { + onCueChange() { if (!lazy.DISPLAY_TEXT_TRACKS_PREF) { this.updateWebVTTTextTracksDisplay(null); } else { @@ -3110,10 +3104,10 @@ class PictureInPictureChildVideoWrapper { * a cue change is triggered {@see updatePiPTextTracks()}. * @param {HTMLVideoElement} video * The originating video source element - * @param {Function} callback + * @param {Function} _callback * The callback function to be executed when cue changes are detected */ - setCaptionContainerObserver(video, callback) { + setCaptionContainerObserver(video, _callback) { return this.#callWrapperMethod({ name: "setCaptionContainerObserver", args: [ diff --git a/toolkit/actors/PrintingChild.sys.mjs b/toolkit/actors/PrintingChild.sys.mjs index 4fca3ab4038b..182784cfe74b 100644 --- a/toolkit/actors/PrintingChild.sys.mjs +++ b/toolkit/actors/PrintingChild.sys.mjs @@ -94,7 +94,7 @@ export class PrintingChild extends JSWindowActorChild { // will wait for MozAfterPaint event to be fired. let actor = thisWindow.windowGlobalChild.getActor("Printing"); let webProgressListener = { - onStateChange(webProgress, req, flags, status) { + onStateChange(webProgress, req, flags) { if (flags & Ci.nsIWebProgressListener.STATE_STOP) { webProgress.removeProgressListener(webProgressListener); let domUtils = contentWindow.windowUtils; diff --git a/toolkit/actors/SelectChild.sys.mjs b/toolkit/actors/SelectChild.sys.mjs index 1bc80001ae13..9901f7264840 100644 --- a/toolkit/actors/SelectChild.sys.mjs +++ b/toolkit/actors/SelectChild.sys.mjs @@ -70,7 +70,7 @@ SelectContentHelper.prototype = { mozSystemGroup: true, }); let MutationObserver = this.element.ownerGlobal.MutationObserver; - this.mut = new MutationObserver(mutations => { + this.mut = new MutationObserver(() => { // Something changed the