nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 555124 - Intermittent "ASSERTION: AsyncStatementSpinner not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file .../mozilla/storage/test/test_true_async.cpp, line 162". null out references on the main thread to avoid destruction on the async thread. r=sdwilsh.

Browse source
This commit is contained in:
Andrew Sutherland 2010-03-29 10:54:41 -07:00
parent c5e94efd8d
commit 759e351de7
1 changed files with 12 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

12
storage/src/mozStorageConnection.cpp
View file

@ -283,6 +283,18 @@ public:
if (mCallbackEvent) if (mCallbackEvent)
(void)mCallingThread->Dispatch(mCallbackEvent, NS_DISPATCH_NORMAL); (void)mCallingThread->Dispatch(mCallbackEvent, NS_DISPATCH_NORMAL);
// Because we have no guarantee that the invocation of this method on the
// asynchronous thread has fully completed (including the Release of the
// reference to this object held by that event loop), we need to explicitly
// null out our pointers here. It is possible this object will be destroyed
// on the asynchronous thread and if the references are still alive we will
// release them on that thread. We definitely do not want that for
// mConnection and it's nice to avoid for mCallbackEvent too. We do not
// null out mCallingThread because it is conceivable the async thread might
// still be 'in' the object.
mConnection = nsnull;
mCallbackEvent = nsnull;
return NS_OK; return NS_OK;
} }
private: private: