From 77bda756d8370722ed1d14f5b76df3af6dc4101b Mon Sep 17 00:00:00 2001 From: David Shin Date: Tue, 21 Nov 2023 21:14:11 +0000 Subject: [PATCH] Bug 1865668: Don't generate text node for pseudo-elements with empty string content. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D194094 --- layout/base/nsCSSFrameConstructor.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/layout/base/nsCSSFrameConstructor.cpp b/layout/base/nsCSSFrameConstructor.cpp index 045304bf1bb3..4bd4e976cd62 100644 --- a/layout/base/nsCSSFrameConstructor.cpp +++ b/layout/base/nsCSSFrameConstructor.cpp @@ -1551,8 +1551,12 @@ void nsCSSFrameConstructor::CreateGeneratedContent( } case Type::String: { - RefPtr text = CreateGenConTextNode( - aState, NS_ConvertUTF8toUTF16(item.AsString().AsString()), nullptr); + const auto string = item.AsString().AsString(); + if (string.IsEmpty()) { + return; + } + RefPtr text = + CreateGenConTextNode(aState, NS_ConvertUTF8toUTF16(string), nullptr); aAddChild(text); return; }