nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1879011 - Fix sponsored suggest related UI tests r=ohorvath

Browse source 
Both **openFirefoxSuggestSponsoredSearchResultsTest** and **verifyFirefoxSuggestSponsoredSearchResultsWithEditedKeywordTest** were flaky or even failed because no suggestion was displayed in the search wrapper.

This problems most likely was caused by [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1813587 | 1813587 ]].

To overcome the problems, I've added 2 extra steps to all existing sponsored suggestions related UI tests, in which we use DuckDuckGo which proved to work properly to assert and interact with the suggestions.

✅ All 4 UI tests successfully passed 150x on Firebase:

  - **verifyFirefoxSuggestSponsoredSearchResultsTest**
  - **verifyFirefoxSuggestSponsoredSearchResultsWithPartialKeywordTest**
  - **openFirefoxSuggestSponsoredSearchResultsTest**
  - **verifyFirefoxSuggestSponsoredSearchResultsWithEditedKeywordTest**

Differential Revision: https://phabricator.services.mozilla.com/D211346
This commit is contained in:
AndiAJ 2024-05-23 12:12:20 +00:00
parent 3415d29455
commit 7c8af9bff9
1 changed files with 16 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

16
mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/FirefoxSuggestTest.kt
View file

@ -108,6 +108,10 @@ class FirefoxSuggestTest : TestSetup() {
runWithCondition(TestHelper.appContext.settings().enableFxSuggest) { runWithCondition(TestHelper.appContext.settings().enableFxSuggest) {
navigationToolbar { navigationToolbar {
}.clickUrlbar { }.clickUrlbar {
// The Google related suggestions aren't always displayed on cold run
// Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1813587
clickSearchSelectorButton()
selectTemporarySearchMethod("DuckDuckGo")
typeSearch(searchTerm = sponsoredKeyWord) typeSearch(searchTerm = sponsoredKeyWord)
verifySearchEngineSuggestionResults( verifySearchEngineSuggestionResults(
rule = activityTestRule, rule = activityTestRule,
@ -129,6 +133,10 @@ class FirefoxSuggestTest : TestSetup() {
runWithCondition(TestHelper.appContext.settings().enableFxSuggest) { runWithCondition(TestHelper.appContext.settings().enableFxSuggest) {
navigationToolbar { navigationToolbar {
}.clickUrlbar { }.clickUrlbar {
// The Google related suggestions aren't always displayed on cold run
// Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1813587
clickSearchSelectorButton()
selectTemporarySearchMethod("DuckDuckGo")
typeSearch(searchTerm = sponsoredKeyWord.dropLast(1)) typeSearch(searchTerm = sponsoredKeyWord.dropLast(1))
verifySearchEngineSuggestionResults( verifySearchEngineSuggestionResults(
rule = activityTestRule, rule = activityTestRule,
@ -150,6 +158,10 @@ class FirefoxSuggestTest : TestSetup() {
runWithCondition(TestHelper.appContext.settings().enableFxSuggest) { runWithCondition(TestHelper.appContext.settings().enableFxSuggest) {
navigationToolbar { navigationToolbar {
}.clickUrlbar { }.clickUrlbar {
// The Google related suggestions aren't always displayed on cold run
// Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1813587
clickSearchSelectorButton()
selectTemporarySearchMethod("DuckDuckGo")
typeSearch(searchTerm = sponsoredKeyWord) typeSearch(searchTerm = sponsoredKeyWord)
verifySearchEngineSuggestionResults( verifySearchEngineSuggestionResults(
rule = activityTestRule, rule = activityTestRule,
@ -174,6 +186,10 @@ class FirefoxSuggestTest : TestSetup() {
runWithCondition(TestHelper.appContext.settings().enableFxSuggest) { runWithCondition(TestHelper.appContext.settings().enableFxSuggest) {
navigationToolbar { navigationToolbar {
}.clickUrlbar { }.clickUrlbar {
// The Google related suggestions aren't always displayed on cold run
// Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1813587
clickSearchSelectorButton()
selectTemporarySearchMethod("DuckDuckGo")
typeSearch(searchTerm = sponsoredKeyWord) typeSearch(searchTerm = sponsoredKeyWord)
deleteSearchKeywordCharacters(numberOfDeletionSteps = 1) deleteSearchKeywordCharacters(numberOfDeletionSteps = 1)
verifySearchEngineSuggestionResults( verifySearchEngineSuggestionResults(