nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1787290 - Cache isDefaultBrowser in ASRouter targeting r=Mardak

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D155646
This commit is contained in:
Barret Rennie 2022-08-30 03:54:39 +00:00
parent e0367698f6
commit 7dc13808c3
2 changed files with 8 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

8
browser/components/newtab/lib/ASRouterTargeting.jsm
View file

@ -277,6 +277,12 @@ const QueryCache = {
FRECENT_SITES_UPDATE_INTERVAL, FRECENT_SITES_UPDATE_INTERVAL,
ShellService ShellService
), ),
isDefaultBrowser: new CachedTargetingGetter(
"isDefaultBrowser",
null,
FRECENT_SITES_UPDATE_INTERVAL,
ShellService
),
currentThemes: new CachedTargetingGetter( currentThemes: new CachedTargetingGetter(
"getAddonsByTypes", "getAddonsByTypes",
["theme"], ["theme"],
@ -507,7 +513,7 @@ const TargetingGetters = {
}, },
get isDefaultBrowser() { get isDefaultBrowser() {
try { try {
return ShellService.isDefaultBrowser(); return QueryCache.getters.isDefaultBrowser.get();
} catch (e) {} } catch (e) {}
return null; return null;
}, },

2
browser/components/newtab/test/browser/browser_asrouter_targeting.js
View file

@ -355,7 +355,7 @@ add_task(async function checksearchEngines() {
add_task(async function checkisDefaultBrowser() { add_task(async function checkisDefaultBrowser() {
const expected = ShellService.isDefaultBrowser(); const expected = ShellService.isDefaultBrowser();
const result = ASRouterTargeting.Environment.isDefaultBrowser; const result = await ASRouterTargeting.Environment.isDefaultBrowser;
is(typeof result, "boolean", "isDefaultBrowser should be a boolean value"); is(typeof result, "boolean", "isDefaultBrowser should be a boolean value");
is( is(
result, result,