nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1309430 - Remove font-family: monospace from some mpadded reftests. r=emilio

Browse source 
These tests were initially added in bug 685628, and were relying
on `<mtext mathvariant="monospace">` so we can assume that all
glyphs have the same logical width/height even if they may have
different ink width/height.

At that time `mathvariant="monospace"` was probably always using
`font-family: monospace` but after bug 114365, these were generally
directly mapped to Mathematical Alphanumeric Symbols and sometimes
they were falling back to the old `font-family: monospace`. Tests
were added to continue checking the latter too. After bug 1846482,
the one using the legacy `mathvariant="monospace"` were just
replaced with direct use of Mathematical Alphanumeric Symbols.

To keep the spirit of the original tests, we just need a font
with two glyphs with same logical width/height but different ink
width/height. To achieve that, this commit only keeps the tests
with monospace Mathematical Alphanumeric Symbols: glyphs for
these characters should be available in modern systems and the
test would still pass with Tofu characters anyway. The cases
`font-family: monospace` with '|' and 'X' are removed as they
are redundant and on some platforms result in glyphs picked
from different monospace fonts.

Differential Revision: https://phabricator.services.mozilla.com/D200457
This commit is contained in:
Frédéric Wang 2024-02-04 11:53:19 +00:00
parent 5f70f00863
commit 7e4bfc3692
7 changed files with 3 additions and 47 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
layout/reftests/mathml/mpadded-7-ref.html
View file

@ -4,13 +4,6 @@
<title>Test mpadded</title>
</head>
<body>
<math>
<mpadded mathbackground="red" height="100height" depth="0">
<mphantom>
<mtext style="font-family: monospace">X</mtext>
</mphantom>
</mpadded>
</math>
<math>
<mpadded mathbackground="red" height="100height" depth="0">
<mphantom>

7
layout/reftests/mathml/mpadded-7.html
View file

@ -6,13 +6,6 @@
<body>
<math>
<!--height in term of height should not depend on the characters-->
<mpadded mathbackground="red" height="100height" depth="0">
<mphantom>
<mtext style="font-family: monospace">_</mtext>
</mphantom>
</mpadded>
</math>
<math>
<mpadded mathbackground="red" height="100height" depth="0">
<mphantom>
<mtext>&#x1D692;<!-- Mathematical Monospace Small I --></mtext>

7
layout/reftests/mathml/mpadded-8-ref.html
View file

@ -4,13 +4,6 @@
<title>Test mpadded</title>
</head>
<body>
<math>
<mpadded mathbackground="red" height="100width" depth="0">
<mphantom>
<mtext style="font-family: monospace">X</mtext>
</mphantom>
</mpadded>
</math>
<math>
<mpadded mathbackground="red" height="100width" depth="0">
<mphantom>

7
layout/reftests/mathml/mpadded-8.html
View file

@ -6,13 +6,6 @@
<body>
<math>
<!--height in term of width should not depend on the characters-->
<mpadded mathbackground="red" height="100width" depth="0">
<mphantom>
<mtext style="font-family: monospace">|</mtext>
</mphantom>
</mpadded>
</math>
<math>
<mpadded mathbackground="red" height="100width" depth="0">
<mphantom>
<mtext>&#x1D692;<!-- Mathematical Monospace Small I --></mtext>

8
layout/reftests/mathml/mpadded-9-ref.html
View file

@ -4,14 +4,6 @@
<title>Test mpadded</title>
</head>
<body>
<math>
<mpadded mathbackground="red" width="100width">
<mphantom>
<mtext style="font-family: monospace">X</mtext>
</mphantom>
</mpadded>
</math>
<br>
<math>
<mpadded mathbackground="red" width="100width">
<mphantom>

8
layout/reftests/mathml/mpadded-9.html
View file

@ -6,14 +6,6 @@
<body>
<math>
<!--with fixed width, height + depth should not depend on the characters-->
<mpadded mathbackground="red" width="100width">
<mphantom>
<mtext style="font-family: monospace">|</mtext>
</mphantom>
</mpadded>
</math>
<br>
<math>
<mpadded mathbackground="red" width="100width">
<mphantom>
<mtext>&#x1D692;<!-- Mathematical Monospace Small I --></mtext>

6
layout/reftests/mathml/reftest.list
View file

@ -19,9 +19,9 @@ fails-if(OSX>=1010) == scale-stretchy-3.xhtml scale-stretchy-3-ref.xhtml
!= scale-stretchy-4.xhtml scale-stretchy-4-ref.xhtml
!= scale-stretchy-5.xhtml scale-stretchy-5-ref.xhtml
!= stretchy-1.html stretchy-1-ref.html
random-if(gtkWidget) fails-if(geckoview&&device) == mpadded-7.html mpadded-7-ref.html # bug 1309430
random-if(gtkWidget) == mpadded-8.html mpadded-8-ref.html # bug 1309430
random-if(gtkWidget) == mpadded-9.html mpadded-9-ref.html # bug 1309430
== mpadded-7.html mpadded-7-ref.html
== mpadded-8.html mpadded-8-ref.html
== mpadded-9.html mpadded-9-ref.html
== scriptlevel-movablelimits-1.html scriptlevel-movablelimits-1-ref.html
== munderover-align-accent-false.html munderover-align-accent-false-ref.html
== munderover-align-accent-true.html munderover-align-accent-true-ref.html