nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1811066 - Skip correct test when isolated process is enabled. r=geckoview-reviewers,m_kato

Browse source 
In bug 1706656 I marked PermissionDelegateTest#geolocation() to be
skipped when isolated process is enabled, due to noticing that it was
failing. However, this test is still failing intermittently on
try. The reason is that PermissionDelegateTest#autoplayReject() is
actually the test that causes the crash, and the harness incorrectly
reports this as geolocation() failing.

This patch marks the correct test as being skipped.

Differential Revision: https://phabricator.services.mozilla.com/D167255
This commit is contained in:
Jamie Nicol 2023-01-20 16:05:28 +00:00
parent ee51dc922f
commit 8400fedede
1 changed files with 3 additions and 3 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

6
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/PermissionDelegateTest.kt
View file

@ -185,9 +185,6 @@ class PermissionDelegateTest : BaseSessionTest() {
} }
@Test fun geolocation() { @Test fun geolocation() {
// Bug 1810736
assumeThat(sessionRule.env.isIsolatedProcess, equalTo(false))
assertInAutomationThat( assertInAutomationThat(
"Should have location permission", "Should have location permission",
hasPermission(Manifest.permission.ACCESS_FINE_LOCATION), hasPermission(Manifest.permission.ACCESS_FINE_LOCATION),
@ -638,6 +635,9 @@ class PermissionDelegateTest : BaseSessionTest() {
@Test @Test
fun autoplayReject() { fun autoplayReject() {
// Bug 1810736
assumeThat(sessionRule.env.isIsolatedProcess, equalTo(false))
// The profile used in automation sets this to false, so we need to hack it back to true here. // The profile used in automation sets this to false, so we need to hack it back to true here.
sessionRule.setPrefsUntilTestEnd( sessionRule.setPrefsUntilTestEnd(
mapOf( mapOf(