nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1801031 - Use attribute atoms for screenX/screenY in one more place. r=smaug

Browse source 
Otherwise we hit the weird HTML-specific lowercasing of attributes,
which make these attributes "screenx" and "screeny", which means we fail
to restore the persisted position.

We should consider adding screen-x/screen-y and migrate screenX/Y to
that probably...

Differential Revision: https://phabricator.services.mozilla.com/D162391
This commit is contained in:
Emilio Cobos Álvarez 2022-11-18 13:32:33 +00:00
parent 170c2b3833
commit 8501b361e4
1 changed files with 7 additions and 6 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
xpfe/appshell/AppWindow.cpp
View file

@ -1218,7 +1218,9 @@ bool AppWindow::LoadPositionFromXUL(int32_t aSpecWidth, int32_t aSpecHeight) {
// if we're the hidden window, don't try to validate our size/position. We're
// special.
if (mIsHiddenWindow) return false;
if (mIsHiddenWindow) {
return false;
}
nsCOMPtr<dom::Element> windowElement = GetWindowDOMElement();
NS_ENSURE_TRUE(windowElement, false);
@ -1282,7 +1284,7 @@ bool AppWindow::LoadPositionFromXUL(int32_t aSpecWidth, int32_t aSpecHeight) {
static Maybe<int32_t> ReadIntAttribute(const Element& aElement, nsAtom* aAtom) {
nsAutoString attrString;
if (!aElement.GetAttr(kNameSpaceID_None, aAtom, attrString)) {
if (!aElement.GetAttr(aAtom, attrString)) {
return Nothing();
}
@ -2573,20 +2575,19 @@ void AppWindow::LoadPersistentWindowState() {
// Check if the window wants to persist anything.
nsAutoString persist;
docShellElement->GetAttr(kNameSpaceID_None, nsGkAtoms::persist, persist);
docShellElement->GetAttr(nsGkAtoms::persist, persist);
if (persist.IsEmpty()) {
return;
}
auto loadValue = [&](const nsAtom* aAttr) {
auto loadValue = [&](nsAtom* aAttr) {
nsDependentAtomString attrString(aAttr);
if (persist.Find(attrString) >= 0) {
nsAutoString value;
nsresult rv = GetPersistentValue(aAttr, value);
NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Failed to get persistent state.");
if (NS_SUCCEEDED(rv) && !value.IsEmpty()) {
IgnoredErrorResult err;
docShellElement->SetAttribute(attrString, value, err);
docShellElement->SetAttr(aAttr, value, IgnoreErrors());
}
}
};