nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1786329 - Remove signon.showAutoCompleteOrigins pref r=dimi

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D155255
This commit is contained in:
Sergey Galich 2022-08-23 01:02:24 +00:00
parent b7f9e854c5
commit 8c44b387c3
5 changed files with 1 additions and 10 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
modules/libpref/init/all.js
View file

@ -3455,7 +3455,6 @@ pref("signon.includeOtherSubdomainsInLookup", true);
// This temporarily prevents the primary password to reprompt for autocomplete. // This temporarily prevents the primary password to reprompt for autocomplete.
pref("signon.masterPasswordReprompt.timeout_ms", 900000); // 15 Minutes pref("signon.masterPasswordReprompt.timeout_ms", 900000); // 15 Minutes
pref("signon.showAutoCompleteFooter", false); pref("signon.showAutoCompleteFooter", false);
pref("signon.showAutoCompleteOrigins", true);
// Satchel (Form Manager) prefs // Satchel (Form Manager) prefs
pref("browser.formfill.debug", false); pref("browser.formfill.debug", false);

7
toolkit/components/passwordmgr/LoginAutoComplete.jsm
View file

@ -29,11 +29,6 @@ XPCOMUtils.defineLazyServiceGetter(
"@mozilla.org/satchel/form-fill-controller;1", "@mozilla.org/satchel/form-fill-controller;1",
Ci.nsIFormFillController Ci.nsIFormFillController
); );
XPCOMUtils.defineLazyPreferenceGetter(
lazy,
"SHOULD_SHOW_ORIGIN",
"signon.showAutoCompleteOrigins"
);
XPCOMUtils.defineLazyGetter(lazy, "log", () => { XPCOMUtils.defineLazyGetter(lazy, "log", () => {
return lazy.LoginHelper.createLogger("LoginAutoComplete"); return lazy.LoginHelper.createLogger("LoginAutoComplete");
}); });
@ -138,7 +133,7 @@ class LoginAutocompleteItem extends AutocompleteItem {
actor, actor,
isOriginMatched isOriginMatched
) { ) {
super(lazy.SHOULD_SHOW_ORIGIN ? "loginWithOrigin" : "login"); super("loginWithOrigin");
this.login = login.QueryInterface(Ci.nsILoginMetaInfo); this.login = login.QueryInterface(Ci.nsILoginMetaInfo);
this.#actor = actor; this.#actor = actor;

1
toolkit/components/passwordmgr/test/mochitest/test_autocomplete_basic_form_subdomain.html
View file

@ -72,7 +72,6 @@ add_setup(async () => {
await SpecialPowers.pushPrefEnv({ await SpecialPowers.pushPrefEnv({
set: [ set: [
["signon.includeOtherSubdomainsInLookup", true], ["signon.includeOtherSubdomainsInLookup", true],
["signon.showAutoCompleteOrigins", true],
], ],
}); });
listenForUnexpectedPopupShown(); listenForUnexpectedPopupShown();

1
toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation.html
View file

@ -216,7 +216,6 @@ add_task(async function test_autofillAutocompleteUsername_noGeneration2() {
await SpecialPowers.pushPrefEnv({"set": [ await SpecialPowers.pushPrefEnv({"set": [
["signon.generation.available", true], ["signon.generation.available", true],
["signon.generation.enabled", true], ["signon.generation.enabled", true],
["signon.showAutoCompleteOrigins", true],
]}); ]});
// 2nd form should not be filled // 2nd form should not be filled

1
toolkit/components/passwordmgr/test/unit/test_login_autocomplete_result.js
View file

@ -657,7 +657,6 @@ add_task(async function test_all_patterns() {
LoginHelper.createLogger("LoginAutoCompleteResult"); LoginHelper.createLogger("LoginAutoCompleteResult");
Services.prefs.setBoolPref("signon.showAutoCompleteFooter", true); Services.prefs.setBoolPref("signon.showAutoCompleteFooter", true);
Services.prefs.setBoolPref("signon.showAutoCompleteOrigins", true);
expectedResults.forEach((pattern, testIndex) => { expectedResults.forEach((pattern, testIndex) => {
info(`expectedResults[${testIndex}]`); info(`expectedResults[${testIndex}]`);