nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1786907 - Turn on MR existing user onboarding upgrade dialog in Fx106 r=Mardak

Browse source 
Modal dialog appears on major version upgrade to 106

Differential Revision: https://phabricator.services.mozilla.com/D155643
This commit is contained in:
Punam Dahiya 2022-08-31 17:00:56 +00:00
parent 02c644a11d
commit 8f02f29bf1
3 changed files with 7 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
browser/app/profile/firefox.js
View file

@ -319,7 +319,7 @@ pref("browser.startup.preXulSkeletonUI", true);
#endif
// Show an upgrade dialog on major upgrades.
pref("browser.startup.upgradeDialog.enabled", false);
pref("browser.startup.upgradeDialog.enabled", true);
// Don't create the hidden window during startup on
// platforms that don't always need it (Win/Linux).

2
browser/components/BrowserGlue.jsm
View file

@ -4298,7 +4298,7 @@ BrowserGlue.prototype = {
async _maybeShowDefaultBrowserPrompt() {
// Highest priority is the upgrade dialog, which can include a "primary
// browser" request and is limited in various ways, e.g., major upgrades.
const dialogVersion = 100;
const dialogVersion = 106;
const dialogVersionPref = "browser.startup.upgradeDialog.version";
const dialogReason = await (async () => {
if (!lazy.BrowserHandler.majorUpgrade) {

5
browser/components/tests/browser/browser_browserGlue_upgradeDialog_trigger.js
View file

@ -9,6 +9,9 @@ const { ExperimentFakes } = ChromeUtils.import(
const { NimbusFeatures, ExperimentAPI } = ChromeUtils.import(
"resource://nimbus/ExperimentAPI.jsm"
);
const { OnboardingMessageProvider } = ChromeUtils.import(
"resource://activity-stream/lib/OnboardingMessageProvider.jsm"
);
add_task(async function not_major_upgrade() {
Services.telemetry.clearEvents();
@ -72,6 +75,8 @@ add_task(async function show_major_upgrade() {
await BROWSER_GLUE._maybeShowDefaultBrowserPrompt();
const [win] = await TestUtils.topicObserved("subdialog-loaded");
const data = await OnboardingMessageProvider.getUpgradeMessage();
Assert.equal(data.id, "FX_MR_106_UPGRADE", "MR 106 Upgrade Dialog Shown");
win.close();
AssertEvents("Upgrade dialog opened from major upgrade", [