Bug 1793369 - Enable ESLint rule no-unused-vars globally on dom/indexedDB xpcshell-tests. r=asuth

Differential Revision: https://phabricator.services.mozilla.com/D158470
This commit is contained in:
Mark Banner 2022-10-03 16:30:03 +00:00
parent 2fad8f1409
commit 8f884a04f5
105 changed files with 108 additions and 27 deletions

View file

@ -156,35 +156,12 @@ module.exports = {
},
},
{
// This section enables warning of no-unused-vars globally for all test*.js
// This section enables errors of no-unused-vars globally for all test*.js
// files in xpcshell test paths.
// These are turned into errors with selected exclusions in the next
// section.
// Bug 1612907: This section should go away once the exclusions are removed
// from the following section.
// This is not done in the xpcshell-test configuration as we cannot pull
// in overrides from there. We should at some stage, aim to enable this
// for all files in xpcshell-tests.
files: testPaths.xpcshell.map(path => `${path}test*.js`),
rules: {
// No declaring variables that are never used
"no-unused-vars": [
"warn",
{
args: "none",
vars: "all",
},
],
},
},
{
// This section makes global issues with no-unused-vars be reported as
// errors - except for the excluded lists which are being fixed in the
// dependencies of bug 1612907.
files: testPaths.xpcshell.map(path => `${path}test*.js`),
excludedFiles: [
// These are more complicated bugs which may require some in-depth
// investigation or different solutions. They are also likely to be
// a reasonable size.
"dom/indexedDB/**",
],
rules: {
// No declaring variables that are never used
"no-unused-vars": [

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "Need to implement a gc() function for worker tests";
if (!this.window) {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "This test uses SpecialPowers";
var testGenerator = testSteps();

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "Need a way to set temporary prefs from a worker";
var testGenerator = testSteps();

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testSteps */
async function testSteps() {
const name = this.window ? window.location.pathname : "Splendid Test";
const objectStoreName = "foo";

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -4,6 +4,7 @@
*/
/* eslint-disable mozilla/no-arbitrary-setTimeout */
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -5,6 +5,7 @@
/* import-globals-from ../file.js */
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "FileHandle doesn't work in workers yet";
var testGenerator = testSteps();

View file

@ -5,6 +5,7 @@
/* import-globals-from ../helpers.js */
/* exported testSteps, disableWorkerTest */
var disableWorkerTest = "FileHandle doesn't work in workers yet";
async function testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -4,6 +4,7 @@
*/
/* eslint-disable mozilla/no-arbitrary-setTimeout */
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "Need to implement a gc() function for worker tests";
var testGenerator = testSteps();

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
// helper function that ensures that ArrayBuffer instances are meaningfully

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -49,6 +49,7 @@ function createTestingEnvironment(markerFileOnly = false) {
* marker-file, a databse file, and a directory exist in current idb directory.
*/
/* exported testSteps */
async function testSteps() {
SpecialPowers.setBoolPref("dom.quotaManager.testing", true);

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "Need a way to set temporary prefs from a worker";
var testGenerator = testSteps();

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -12,6 +12,7 @@
* crashed.
*/
/* exported testSteps */
async function testSteps() {
const name = "test_orphaned_files.js";

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "Need a way to set temporary prefs from a worker";
var testGenerator = testSteps();

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "Need a way to set temporary prefs from a worker";
var testGenerator = testSteps();

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -62,6 +62,7 @@ function* testSteps() {
finishTest();
}
/* exported setup */
async function setup(isXOrigin) {
// Bug 1746646: Make mochitests work with TCP enabled (cookieBehavior = 5)
// Acquire storage access permission here so that the iframe has

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -15,6 +15,7 @@ const objData = "1234567890";
const objDataCount = 5;
const loopCount = 100;
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -6,6 +6,7 @@
var self = this;
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator, disableWorkerTest */
var disableWorkerTest = "This test uses SpecialPowers";
var testGenerator = testSteps();

View file

@ -3,6 +3,7 @@
* http://creativecommons.org/publicdomain/zero/1.0/
*/
/* exported testGenerator */
var testGenerator = testSteps();
function* testSteps() {

View file

@ -33,6 +33,7 @@ function createTestingEnvironment() {
* This test verifies unexpected directories won't block idb's initialization.
*/
/* exported testSteps */
async function testSteps() {
info("Verifying open shouldn't be blocked by unexpected files");

Some files were not shown because too many files have changed in this diff Show more