nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1870336 - Remove unused nsIAppWindow.add/removeChildWindow. r=tnikkel

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D196599
This commit is contained in:
Emilio Cobos Álvarez 2023-12-16 10:47:01 +00:00
parent 313ac781af
commit 93b01a971d
3 changed files with 2 additions and 27 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

16
xpfe/appshell/AppWindow.cpp
View file

@ -476,16 +476,6 @@ AppWindow::GetLiveResizeListeners() {
return listeners; return listeners;
} }
NS_IMETHODIMP AppWindow::AddChildWindow(nsIAppWindow* aChild) {
// we're not really keeping track of this right now
return NS_OK;
}
NS_IMETHODIMP AppWindow::RemoveChildWindow(nsIAppWindow* aChild) {
// we're not really keeping track of this right now
return NS_OK;
}
NS_IMETHODIMP AppWindow::ShowModal() { NS_IMETHODIMP AppWindow::ShowModal() {
AUTO_PROFILER_LABEL("AppWindow::ShowModal", OTHER); AUTO_PROFILER_LABEL("AppWindow::ShowModal", OTHER);
@ -577,11 +567,9 @@ NS_IMETHODIMP AppWindow::Destroy() {
nsCOMPtr<nsIAppShellService> appShell( nsCOMPtr<nsIAppShellService> appShell(
do_GetService(NS_APPSHELLSERVICE_CONTRACTID)); do_GetService(NS_APPSHELLSERVICE_CONTRACTID));
NS_ASSERTION(appShell, "Couldn't get appShell... xpcom shutdown?"); NS_ASSERTION(appShell, "Couldn't get appShell... xpcom shutdown?");
if (appShell) if (appShell) {
appShell->UnregisterTopLevelWindow(static_cast<nsIAppWindow*>(this)); appShell->UnregisterTopLevelWindow(static_cast<nsIAppWindow*>(this));
}
nsCOMPtr<nsIAppWindow> parentWindow(do_QueryReferent(mParentWindow));
if (parentWindow) parentWindow->RemoveChildWindow(this);
// Remove modality (if any) and hide while destroying. More than // Remove modality (if any) and hide while destroying. More than
// a convenience, the hide prevents user interaction with the partially // a convenience, the hide prevents user interaction with the partially

1
xpfe/appshell/nsAppShellService.cpp
View file

@ -736,7 +736,6 @@ nsresult nsAppShellService::JustCreateTopWindow(
} }
window.forget(aResult); window.forget(aResult);
if (parent) parent->AddChildWindow(*aResult);
if (center) rv = (*aResult)->Center(parent, parent ? false : true, false); if (center) rv = (*aResult)->Center(parent, parent ? false : true, false);

12
xpfe/appshell/nsIAppWindow.idl
View file

@ -68,12 +68,6 @@ interface nsIAppWindow : nsISupports
[noscript,notxpcom] LiveResizeListenerArray getLiveResizeListeners(); [noscript,notxpcom] LiveResizeListenerArray getLiveResizeListeners();
/**
* Tell this window that it has picked up a child XUL window
* @param aChild the child window being added
*/
void addChildWindow(in nsIAppWindow aChild);
/** /**
* Returns the difference between the inner window size (client size) and the * Returns the difference between the inner window size (client size) and the
* outer window size, in CSS pixels. * outer window size, in CSS pixels.
@ -81,12 +75,6 @@ interface nsIAppWindow : nsISupports
[infallible] readonly attribute unsigned long outerToInnerHeightDifferenceInCSSPixels; [infallible] readonly attribute unsigned long outerToInnerHeightDifferenceInCSSPixels;
[infallible] readonly attribute unsigned long outerToInnerWidthDifferenceInCSSPixels; [infallible] readonly attribute unsigned long outerToInnerWidthDifferenceInCSSPixels;
/**
* Tell this window that it has lost a child XUL window
* @param aChild the child window being removed
*/
void removeChildWindow(in nsIAppWindow aChild);
/** /**
* Move the window to a centered position. * Move the window to a centered position.
* @param aRelative If not null, the window relative to which the window is * @param aRelative If not null, the window relative to which the window is