nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1882044 - Add some context to a few crashes. r=gfx-reviewers,aosmond

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D202708
This commit is contained in:
Nicolas Silva 2024-02-28 15:01:04 +00:00
parent 232508c0f4
commit 9a5200723e
3 changed files with 6 additions and 3 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
gfx/wr/webrender/src/picture.rs
View file

@ -5014,7 +5014,7 @@ impl PicturePrimitive {
let content_device_rect = content_device_rect let content_device_rect = content_device_rect
.intersection(&max_content_rect) .intersection(&max_content_rect)
.expect("bug: no intersection with tile dirty rect"); .expect("bug: no intersection with tile dirty rect: {content_device_rect:?} / {max_content_rect:?}");
let content_task_size = content_device_rect.size(); let content_task_size = content_device_rect.size();
let normalized_content_rect = content_task_size.into(); let normalized_content_rect = content_task_size.into();

5
gfx/wr/webrender/src/render_task.rs
View file

@ -10,7 +10,7 @@ use crate::clip::{ClipDataStore, ClipItemKind, ClipStore, ClipNodeRange};
use crate::command_buffer::{CommandBufferIndex, QuadFlags}; use crate::command_buffer::{CommandBufferIndex, QuadFlags};
use crate::spatial_tree::SpatialNodeIndex; use crate::spatial_tree::SpatialNodeIndex;
use crate::filterdata::SFilterData; use crate::filterdata::SFilterData;
use crate::frame_builder::{FrameBuilderConfig}; use crate::frame_builder::FrameBuilderConfig;
use crate::gpu_cache::{GpuCache, GpuCacheAddress, GpuCacheHandle}; use crate::gpu_cache::{GpuCache, GpuCacheAddress, GpuCacheHandle};
use crate::gpu_types::{BorderInstance, ImageSource, UvRectKind, TransformPaletteId}; use crate::gpu_types::{BorderInstance, ImageSource, UvRectKind, TransformPaletteId};
use crate::internal_types::{CacheTextureId, FastHashMap, TextureSource, Swizzle}; use crate::internal_types::{CacheTextureId, FastHashMap, TextureSource, Swizzle};
@ -940,6 +940,9 @@ impl RenderTask {
size: DeviceIntSize, size: DeviceIntSize,
kind: RenderTaskKind, kind: RenderTaskKind,
) -> Self { ) -> Self {
if size.is_empty() {
log::warn!("Bad {} render task size: {:?}", kind.as_str(), size);
}
RenderTask::new( RenderTask::new(
RenderTaskLocation::Unallocated { size }, RenderTaskLocation::Unallocated { size },
kind, kind,

2
gfx/wr/webrender/src/renderer/upload.rs
View file

@ -660,7 +660,7 @@ impl UploadTexturePool {
ImageFormat::RGBA8 => 0, ImageFormat::RGBA8 => 0,
ImageFormat::BGRA8 => 1, ImageFormat::BGRA8 => 1,
ImageFormat::R8 => 2, ImageFormat::R8 => 2,
_ => { panic!("unexpected format"); } _ => { panic!("unexpected format {:?}", format); }
} }
} }