Bug 1880569 - Remove default modifier in font weight token r=desktop-theme-reviewers,reusable-components-reviewers,credential-management-reviewers,hjones,issammani,emilio

Differential Revision: https://phabricator.services.mozilla.com/D202491
This commit is contained in:
Jules Simplicio 2024-02-23 16:27:47 +00:00
parent 581a972ff7
commit 9bccb764c8
7 changed files with 6 additions and 17 deletions

View file

@ -246,7 +246,7 @@ login-command-button {
.alert-title {
font-size: var(--font-size-xlarge);
font-weight: var(--font-weight-default);
font-weight: var(--font-weight);
line-height: 1em;
margin-block: 0 12px;
}

View file

@ -34,7 +34,7 @@
}
#login-sort > option {
font-weight: var(--font-weight-default);
font-weight: var(--font-weight);
}
.count {

View file

@ -68,7 +68,7 @@
box-sizing: border-box;
display: flex;
font-size: 0.87rem;
font-weight: var(--font-weight-default);
font-weight: var(--font-weight);
margin: 0;
padding: 0.125rem 0.5rem;
}

View file

@ -47,7 +47,7 @@
#beta-marker {
font-size: var(--font-size-small);
font-weight: var(--font-weight-default);
font-weight: var(--font-weight);
padding: 2px 4px;
margin: 0;
line-height: 150%;

View file

@ -260,7 +260,7 @@ Type setting relies on design tokens for font size and font weight.
<tbody>
<tr>
<th>
<code>--font-weight-default</code>
<code>--font-weight</code>
</th>
<td>
<code>normal</code>

View file

@ -451,17 +451,6 @@ The `--font-size-root` token was created for specific use under the document's `
</div>
</div>
Just like the specific HTML term 'root', we tend to include the term 'default' on scales in order to identify values that are used as a default, or at the global level (`:root` or `body` tag):
<div class="box">
<div class="post-it blue big">
font-weight
</div>
<div class="post-it big">
<strong>default</strong>
</div>
</div>
It's okay to include intentional terms within scales that better represent the meaning of a value and when to use it. For example, our border radius collection, which uses t-shirt sizing, also mixes the 'circle' option within its scale in order to describe a border radius that will create a circular effect:
<div class="box">

View file

@ -61,7 +61,7 @@
--color-error-outline: light-dark(var(--color-red-50), var(--color-red-20));
/** Font weight **/
--font-weight-default: normal;
--font-weight: normal;
--font-weight-bold: 600;
/** Focus outline **/